[jira] [Work logged] (ARTEMIS-2183) Useless statement in public synchronized List RefsOperation#getRelatedMessageReferences()

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-2183?focusedWorklogId=203014&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-203014 ]

ASF GitHub Bot logged work on ARTEMIS-2183:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Feb/19 08:07
            Start Date: 23/Feb/19 08:07
    Worklog Time Spent: 10m 
      Work Description: orpiske commented on pull request #2564: ARTEMIS-2183 Useless statement in public synchronized List
URL: https://github.com/apache/activemq-artemis/pull/2564
 
 
   Removes the seemingly unnecessary call to addAll to self.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 203014)
            Time Spent: 10m
    Remaining Estimate: 0h

> Useless statement in public synchronized List<MessageReference> RefsOperation#getRelatedMessageReferences()
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2183
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2183
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>            Reporter: Jiri Daněk
>            Priority: Trivial
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {code}
>    @Override
>    public synchronized List<MessageReference> getRelatedMessageReferences() {
>       List<MessageReference> listRet = new LinkedList<>();
>       listRet.addAll(listRet);  // 🐟
>       return listRet;
>    }
> {code}
> https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java#L184
> The method returns empty list, which may be wrong (looking at the method name). There is absolutely nothing gained by adding content of empty inst into itself, as in {{listRet.addAll(listRet)}}.
> Doing the addAll thing can be an error under ErrorProne compiler.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)