You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Endi S. Dewata (JIRA)" <di...@incubator.apache.org> on 2005/02/25 22:22:49 UTC

[jira] Created: (DIREVE-141) Custom backend integration

Custom backend integration
--------------------------

         Key: DIREVE-141
         URL: http://issues.apache.org/jira/browse/DIREVE-141
     Project: Directory Server
        Type: Improvement
  Components: jndi-provider, interceptors, schema  
    Versions: 0.8    
    Reporter: Endi S. Dewata
 Assigned to: Alex Karasulu 
    Priority: Minor
 Attachments: apacheds.patch

Currently ApacheDS doesn't provide API for integrating a custom backend. I've made some improvements based on conversation with Alex. I will attach a patch file that contains those improvements as well as several other things that I can contribute to ApacheDS. This patch file contains:

- Custom Authenticator API
- Custom Partition support
- Samba schema (http://issues.apache.org/jira/browse/DIREVE-100)
- Test case for the mixed-case bug (http://issues.apache.org/jira/browse/DIREVE-137)

Please feel free to review the patch and make any changes. Let me know if I need to separate them into different patch files. Thanks.

--
Endi S. Dewata

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DIREVE-141) Custom backend integration

Posted by "Alex Karasulu (JIRA)" <di...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/DIREVE-141?page=history ]

Alex Karasulu updated DIREVE-141:
---------------------------------

    Fix Version: 0.9

> Custom backend integration
> --------------------------
>
>          Key: DIREVE-141
>          URL: http://issues.apache.org/jira/browse/DIREVE-141
>      Project: Directory Server
>         Type: Improvement
>   Components: jndi-provider, interceptors, schema
>     Versions: 0.8
>     Reporter: Endi S. Dewata
>     Assignee: Alex Karasulu
>     Priority: Minor
>      Fix For: 0.9
>  Attachments: apacheds.patch, authenticator.patch, partition.patch
>
> Currently ApacheDS doesn't provide API for integrating a custom backend. I've made some improvements based on conversation with Alex. I will attach a patch file that contains those improvements as well as several other things that I can contribute to ApacheDS. This patch file contains:
> - Custom Authenticator API
> - Custom Partition support
> - Samba schema (http://issues.apache.org/jira/browse/DIREVE-100)
> - Test case for the mixed-case bug (http://issues.apache.org/jira/browse/DIREVE-137)
> Please feel free to review the patch and make any changes. Let me know if I need to separate them into different patch files. Thanks.
> --
> Endi S. Dewata

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DIREVE-141) Custom backend integration

Posted by "Endi S. Dewata (JIRA)" <di...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/DIREVE-141?page=history ]

Endi S. Dewata updated DIREVE-141:
----------------------------------

    Attachment: partition.patch

> Custom backend integration
> --------------------------
>
>          Key: DIREVE-141
>          URL: http://issues.apache.org/jira/browse/DIREVE-141
>      Project: Directory Server
>         Type: Improvement
>   Components: jndi-provider, interceptors, schema
>     Versions: 0.8
>     Reporter: Endi S. Dewata
>     Assignee: Alex Karasulu
>     Priority: Minor
>  Attachments: apacheds.patch, authenticator.patch, partition.patch
>
> Currently ApacheDS doesn't provide API for integrating a custom backend. I've made some improvements based on conversation with Alex. I will attach a patch file that contains those improvements as well as several other things that I can contribute to ApacheDS. This patch file contains:
> - Custom Authenticator API
> - Custom Partition support
> - Samba schema (http://issues.apache.org/jira/browse/DIREVE-100)
> - Test case for the mixed-case bug (http://issues.apache.org/jira/browse/DIREVE-137)
> Please feel free to review the patch and make any changes. Let me know if I need to separate them into different patch files. Thanks.
> --
> Endi S. Dewata

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DIREVE-141) Custom backend integration

Posted by "Endi S. Dewata (JIRA)" <di...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/DIREVE-141?page=history ]

Endi S. Dewata updated DIREVE-141:
----------------------------------

    Attachment: apacheds.patch

> Custom backend integration
> --------------------------
>
>          Key: DIREVE-141
>          URL: http://issues.apache.org/jira/browse/DIREVE-141
>      Project: Directory Server
>         Type: Improvement
>   Components: jndi-provider, interceptors, schema
>     Versions: 0.8
>     Reporter: Endi S. Dewata
>     Assignee: Alex Karasulu
>     Priority: Minor
>  Attachments: apacheds.patch
>
> Currently ApacheDS doesn't provide API for integrating a custom backend. I've made some improvements based on conversation with Alex. I will attach a patch file that contains those improvements as well as several other things that I can contribute to ApacheDS. This patch file contains:
> - Custom Authenticator API
> - Custom Partition support
> - Samba schema (http://issues.apache.org/jira/browse/DIREVE-100)
> - Test case for the mixed-case bug (http://issues.apache.org/jira/browse/DIREVE-137)
> Please feel free to review the patch and make any changes. Let me know if I need to separate them into different patch files. Thanks.
> --
> Endi S. Dewata

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


Re: [jira] Commented: (DIREVE-141) Custom backend integration

Posted by Alex Karasulu <ao...@bellsouth.net>.
Endi S. Dewata (JIRA) wrote:

>     [ http://issues.apache.org/jira/browse/DIREVE-141?page=comments#action_59778 ]
>     
>Endi S. Dewata commented on DIREVE-141:
>---------------------------------------
>
>Just a note, this patch was made against ApacheDS 0.8.
>  
>
Hey Endi thanks a bunch for submiting these patches.  However just a 
heads up 0.8 is a "stable" release for whatever that's worth.  0.9 is 
the new feature branch which we are working on in the trunk.  In 0.8 we 
can do small obvious bug fixes but 0.9 is where you want to introduce 
these new features.  I'm pretty sure your patch will still be good but 
just in case could you regenerate and compare patches to see if there in 
fact is a difference?

Thanks Endi!
-Alex


[jira] Commented: (DIREVE-141) Custom backend integration

Posted by "Endi S. Dewata (JIRA)" <di...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/DIREVE-141?page=comments#action_59778 ]
     
Endi S. Dewata commented on DIREVE-141:
---------------------------------------

Just a note, this patch was made against ApacheDS 0.8.

> Custom backend integration
> --------------------------
>
>          Key: DIREVE-141
>          URL: http://issues.apache.org/jira/browse/DIREVE-141
>      Project: Directory Server
>         Type: Improvement
>   Components: jndi-provider, interceptors, schema
>     Versions: 0.8
>     Reporter: Endi S. Dewata
>     Assignee: Alex Karasulu
>     Priority: Minor
>  Attachments: apacheds.patch
>
> Currently ApacheDS doesn't provide API for integrating a custom backend. I've made some improvements based on conversation with Alex. I will attach a patch file that contains those improvements as well as several other things that I can contribute to ApacheDS. This patch file contains:
> - Custom Authenticator API
> - Custom Partition support
> - Samba schema (http://issues.apache.org/jira/browse/DIREVE-100)
> - Test case for the mixed-case bug (http://issues.apache.org/jira/browse/DIREVE-137)
> Please feel free to review the patch and make any changes. Let me know if I need to separate them into different patch files. Thanks.
> --
> Endi S. Dewata

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DIREVE-141) Custom backend integration

Posted by "Alex Karasulu (JIRA)" <di...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/DIREVE-141?page=comments#action_60022 ]
     
Alex Karasulu commented on DIREVE-141:
--------------------------------------

Endi,

I committed this partion.patch under the following revision 155862.  You can see it here:

http://svn.apache.org/viewcvs.cgi?rev=155862&view=rev

If this was aa separate issue from the Authenticator stuff we could close this puppy.  No worries for now but submit different feature patches in different issues.  It's easier to track and do a change log that way when we release.

> Custom backend integration
> --------------------------
>
>          Key: DIREVE-141
>          URL: http://issues.apache.org/jira/browse/DIREVE-141
>      Project: Directory Server
>         Type: Improvement
>   Components: jndi-provider, interceptors, schema
>     Versions: 0.8
>     Reporter: Endi S. Dewata
>     Assignee: Alex Karasulu
>     Priority: Minor
>  Attachments: apacheds.patch, authenticator.patch, partition.patch
>
> Currently ApacheDS doesn't provide API for integrating a custom backend. I've made some improvements based on conversation with Alex. I will attach a patch file that contains those improvements as well as several other things that I can contribute to ApacheDS. This patch file contains:
> - Custom Authenticator API
> - Custom Partition support
> - Samba schema (http://issues.apache.org/jira/browse/DIREVE-100)
> - Test case for the mixed-case bug (http://issues.apache.org/jira/browse/DIREVE-137)
> Please feel free to review the patch and make any changes. Let me know if I need to separate them into different patch files. Thanks.
> --
> Endi S. Dewata

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DIREVE-141) Custom backend integration

Posted by "Endi S. Dewata (JIRA)" <di...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/DIREVE-141?page=comments#action_60239 ]
     
Endi S. Dewata commented on DIREVE-141:
---------------------------------------

Alex,

I have written a documentation for the custom partition here:

http://wiki.apache.org/directory/EveGeneral

You can go ahead an close this issue. I will redo the Authenticator SPI without using the digester, and resubmit it under a different issue. Thanks!

Endi

> Custom backend integration
> --------------------------
>
>          Key: DIREVE-141
>          URL: http://issues.apache.org/jira/browse/DIREVE-141
>      Project: Directory Server
>         Type: Improvement
>   Components: jndi-provider, interceptors, schema
>     Versions: 0.8
>     Reporter: Endi S. Dewata
>     Assignee: Alex Karasulu
>     Priority: Minor
>  Attachments: apacheds.patch, authenticator.patch, partition.patch
>
> Currently ApacheDS doesn't provide API for integrating a custom backend. I've made some improvements based on conversation with Alex. I will attach a patch file that contains those improvements as well as several other things that I can contribute to ApacheDS. This patch file contains:
> - Custom Authenticator API
> - Custom Partition support
> - Samba schema (http://issues.apache.org/jira/browse/DIREVE-100)
> - Test case for the mixed-case bug (http://issues.apache.org/jira/browse/DIREVE-137)
> Please feel free to review the patch and make any changes. Let me know if I need to separate them into different patch files. Thanks.
> --
> Endi S. Dewata

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DIREVE-141) Custom backend integration

Posted by "Alex Karasulu (JIRA)" <di...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/DIREVE-141?page=comments#action_60020 ]
     
Alex Karasulu commented on DIREVE-141:
--------------------------------------

Endi this all looks really good - you did a great job.  

I want to just push this patch in however I only have a couple issues that we can work through.

1). [blocker] I would like to avoid the introduction of dependencies from the commons.  We're trying to minimize and even remove several commons dependencies throughout the project.  There's nothing wrong with these APIs however.  If the functionality is small it can be forked without worries of namespace conflicts. When we can we try to use standard JDK API's.  I think we can parse XML without a problem.  Would it be too much to ask to build the authenticator without this dependency?

2). [non-blocker] Could you add some docs to describe this new Authentication mechanism?  It would be nice to have xdocs and/or a wiki page for this.  It's a great feature that I'm sure many will want to use.  Do you think this interface will fullfill all the posible uses in the future like encrypted passwords using md5 etc?  Perhaps you can write about this - feel free to hit the wiki if you perfer leaving your mark ;).

3). [non-blocker] not tryng to be nit picky since I change my style all the time but try to follow the style of the file.  And make sure you put brackets around all while, for, ... etc especially when you have a single lined block.  This always creates problems for :).

Thanks much Endi,
Alex

> Custom backend integration
> --------------------------
>
>          Key: DIREVE-141
>          URL: http://issues.apache.org/jira/browse/DIREVE-141
>      Project: Directory Server
>         Type: Improvement
>   Components: jndi-provider, interceptors, schema
>     Versions: 0.8
>     Reporter: Endi S. Dewata
>     Assignee: Alex Karasulu
>     Priority: Minor
>  Attachments: apacheds.patch, authenticator.patch, partition.patch
>
> Currently ApacheDS doesn't provide API for integrating a custom backend. I've made some improvements based on conversation with Alex. I will attach a patch file that contains those improvements as well as several other things that I can contribute to ApacheDS. This patch file contains:
> - Custom Authenticator API
> - Custom Partition support
> - Samba schema (http://issues.apache.org/jira/browse/DIREVE-100)
> - Test case for the mixed-case bug (http://issues.apache.org/jira/browse/DIREVE-137)
> Please feel free to review the patch and make any changes. Let me know if I need to separate them into different patch files. Thanks.
> --
> Endi S. Dewata

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DIREVE-141) Custom backend integration

Posted by "Endi S. Dewata (JIRA)" <di...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/DIREVE-141?page=history ]

Endi S. Dewata updated DIREVE-141:
----------------------------------

    Attachment: authenticator.patch

> Custom backend integration
> --------------------------
>
>          Key: DIREVE-141
>          URL: http://issues.apache.org/jira/browse/DIREVE-141
>      Project: Directory Server
>         Type: Improvement
>   Components: jndi-provider, interceptors, schema
>     Versions: 0.8
>     Reporter: Endi S. Dewata
>     Assignee: Alex Karasulu
>     Priority: Minor
>  Attachments: apacheds.patch, authenticator.patch, partition.patch
>
> Currently ApacheDS doesn't provide API for integrating a custom backend. I've made some improvements based on conversation with Alex. I will attach a patch file that contains those improvements as well as several other things that I can contribute to ApacheDS. This patch file contains:
> - Custom Authenticator API
> - Custom Partition support
> - Samba schema (http://issues.apache.org/jira/browse/DIREVE-100)
> - Test case for the mixed-case bug (http://issues.apache.org/jira/browse/DIREVE-137)
> Please feel free to review the patch and make any changes. Let me know if I need to separate them into different patch files. Thanks.
> --
> Endi S. Dewata

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DIREVE-141) Custom backend integration

Posted by "Alex Karasulu (JIRA)" <di...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/DIREVE-141?page=comments#action_60021 ]
     
Alex Karasulu commented on DIREVE-141:
--------------------------------------

Oh and please, if you could, document the mechanism for the way to add new partitions.  This is stuff many asked already.  Feel free to change the site xdocs that talk about seting up partitions.  Submit that patch and I can apply it right away.


It might be good to add a test case with a mock backend.  You can refer to the test case to show the mechanism your docs.  Also it will give us code overage of your changes protecting them.  If I or others break this feature which you depend on your test case will scream :).

Thanks again,
-Alex

P.S. Yeah I should take my own advice with test cases - trying to with all new code now - it really helps.

> Custom backend integration
> --------------------------
>
>          Key: DIREVE-141
>          URL: http://issues.apache.org/jira/browse/DIREVE-141
>      Project: Directory Server
>         Type: Improvement
>   Components: jndi-provider, interceptors, schema
>     Versions: 0.8
>     Reporter: Endi S. Dewata
>     Assignee: Alex Karasulu
>     Priority: Minor
>  Attachments: apacheds.patch, authenticator.patch, partition.patch
>
> Currently ApacheDS doesn't provide API for integrating a custom backend. I've made some improvements based on conversation with Alex. I will attach a patch file that contains those improvements as well as several other things that I can contribute to ApacheDS. This patch file contains:
> - Custom Authenticator API
> - Custom Partition support
> - Samba schema (http://issues.apache.org/jira/browse/DIREVE-100)
> - Test case for the mixed-case bug (http://issues.apache.org/jira/browse/DIREVE-137)
> Please feel free to review the patch and make any changes. Let me know if I need to separate them into different patch files. Thanks.
> --
> Endi S. Dewata

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DIREVE-141) Custom backend integration

Posted by "Endi S. Dewata (JIRA)" <di...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/DIREVE-141?page=comments#action_59788 ]
     
Endi S. Dewata commented on DIREVE-141:
---------------------------------------

Please disregard the first attachment. I've broken it down into 2 separate patch files and recreated it against the 0.9 version. The patch on Samba and mixed-case bug have been submitted to the respective bug.

> Custom backend integration
> --------------------------
>
>          Key: DIREVE-141
>          URL: http://issues.apache.org/jira/browse/DIREVE-141
>      Project: Directory Server
>         Type: Improvement
>   Components: jndi-provider, interceptors, schema
>     Versions: 0.8
>     Reporter: Endi S. Dewata
>     Assignee: Alex Karasulu
>     Priority: Minor
>  Attachments: apacheds.patch, authenticator.patch, partition.patch
>
> Currently ApacheDS doesn't provide API for integrating a custom backend. I've made some improvements based on conversation with Alex. I will attach a patch file that contains those improvements as well as several other things that I can contribute to ApacheDS. This patch file contains:
> - Custom Authenticator API
> - Custom Partition support
> - Samba schema (http://issues.apache.org/jira/browse/DIREVE-100)
> - Test case for the mixed-case bug (http://issues.apache.org/jira/browse/DIREVE-137)
> Please feel free to review the patch and make any changes. Let me know if I need to separate them into different patch files. Thanks.
> --
> Endi S. Dewata

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira