You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Balazs Meszaros <ba...@cloudera.com.INVALID> on 2019/04/26 13:02:20 UTC
[VOTE] HBase Connectors 1.0.0RC1
Please vote on this Apache HBase Connectors release candidate.
The release files including signatures can be found at:
http://home.apache.org/~meszibalu/hbase-connectors-1.0.0RC1/
and maven artifacts are available here:
https://repository.apache.org/content/repositories/orgapachehbase-1307/
Artifacts were signed with meszibalu@apache.org key which can be found at:
https://dist.apache.org/repos/dist/release/hbase/KEYS
Compatibility information:
- scala 2.11
- spark 2.4
- kafka 2.0
It's going to be the first release of hbase-connectors. I have updated the
documentation for kafka connector [1]. Please follow those steps when
testing. Spark documentation is pretty good in the refguide [2].
Please note that HBASE-20884 [3] is required for spark, so HBase-2.0.4 or
HBase-2.1.1 is required at least.
Please try out the candidate and vote +1/0/-1.
Let me be the first who votes.
+1 (not surprisingly)
- signatures, checksums: OK
- apache rat check: OK
- built from source (8u112): OK
- unit tests: OK
- kafka connector between hbase-2.1.4 and kafka-2.0.0 : OK
- spark sql select / insert between hbase-2.1.4 and spark-2.4.0: OK
Best regards,
Balazs
[1] https://github.com/apache/hbase-connectors/tree/master/kafka
[2] http://hbase.apache.org/book.html#spark
[3] https://issues.apache.org/jira/browse/HBASE-20884
Re: [VOTE] HBase Connectors 1.0.0RC1
Posted by Balazs Meszaros <ba...@cloudera.com.INVALID>.
With 3 binding +1 votes (Josh, Stack, Peter) this vote passes.
Thanks everyone who participated in the vote.
Best regards,
Balazs
On Thu, May 2, 2019 at 3:14 PM Sean Busbey <bu...@apache.org> wrote:
> On Thu, May 2, 2019, 04:38 Balazs Meszaros
> <ba...@cloudera.com.invalid> wrote:
>
> >
> > > * We get the ${project.basedir} in the local copy when building because
> > of the HBase dep of 2.1.0 doesn't have HBASE-21005. Do we want to choose
> > the latest 2.1.x?
> >
> > I do not know the answer for that. We can depend on the latest HBase
> > release, but unfortunately we can depend on only one release. How can we
> > ensure compatibility with other versions?
> >
> >
> We should avoid putting a discussion here in the VOTE thread. A jira or a
> new DISCUSS thread would be good.
>
Re: [VOTE] HBase Connectors 1.0.0RC1
Posted by Sean Busbey <bu...@apache.org>.
On Thu, May 2, 2019, 04:38 Balazs Meszaros
<ba...@cloudera.com.invalid> wrote:
>
> > * We get the ${project.basedir} in the local copy when building because
> of the HBase dep of 2.1.0 doesn't have HBASE-21005. Do we want to choose
> the latest 2.1.x?
>
> I do not know the answer for that. We can depend on the latest HBase
> release, but unfortunately we can depend on only one release. How can we
> ensure compatibility with other versions?
>
>
We should avoid putting a discussion here in the VOTE thread. A jira or a
new DISCUSS thread would be good.
Re: [VOTE] HBase Connectors 1.0.0RC1
Posted by Balazs Meszaros <ba...@cloudera.com.INVALID>.
> * Binary release's LICENSE file is missing some stuff. e.g. we bundle
jcodings which is MIT licensed but that is not included in LICENSE. IMO,
we can come back and fix these for the next release.
HBASE-22338 is filed. (Thanks Peter)
> * We get the ${project.basedir} in the local copy when building because
of the HBase dep of 2.1.0 doesn't have HBASE-21005. Do we want to choose
the latest 2.1.x?
I do not know the answer for that. We can depend on the latest HBase
release, but unfortunately we can depend on only one release. How can we
ensure compatibility with other versions?
> * The rogue .flattened-pom.xml that shows up. Not sure who/what creates
that, but we should figure it out and squash it.
This is because of maven-flatten-plugin. More details here:
https://maven.apache.org/maven-ci-friendly.html
Re: [VOTE] HBase Connectors 1.0.0RC1
Posted by Peter Somogyi <ps...@apache.org>.
+1
signatures, checksums: OK
build from source: OK (Oracle 1.8.0_171, Maven 3.6.1)
Apache rat check: OK
Unit / IT tests: OK
Filed issues for Josh's and Artem's findings:
HBASE-22336
HBASE-22337
HBASE-22338
On Mon, Apr 29, 2019 at 7:07 PM Artem Ervits <ar...@gmail.com> wrote:
> +1 (non-binding)
>
> signatures and sums for src: OK
> signatures and sums for bin: OK
> compile from src: OpenJDK 1.8.0_212-b04: OK
> UTs: OK
> ITs: OK
> Ratcheck: OK
>
> Additionally, the following nits found during review:
> ${project.basedir} is in the root of the project after compile
> after build, RELEASENOTES.txt, README.txt, CHANGELOG.txt are not in the
> built assembly
>
>
> On Mon, Apr 29, 2019 at 6:53 AM Andor Molnar <an...@cloudera.com.invalid>
> wrote:
>
> > +1 (non-binding)
> >
> > - Checked signature, checksum
> > - Built from source
> > - Ran all unit / integration tests
> >
> > I did not run tests with Kafka / Spark.
> >
> > Regards,
> > Andor
> >
> >
> >
> >
> > On Sat, Apr 27, 2019 at 9:39 PM Stack <st...@duboce.net> wrote:
> >
> > > +1
> > >
> > > Sig, hash, license, rat, and build from src all good (I see same
> detritus
> > > as our Josh reports).
> > >
> > > Thanks Balazs,
> > > S
> > >
> > > On Fri, Apr 26, 2019 at 6:02 AM Balazs Meszaros
> > > <ba...@cloudera.com.invalid> wrote:
> > >
> > > > Please vote on this Apache HBase Connectors release candidate.
> > > >
> > > > The release files including signatures can be found at:
> > > > http://home.apache.org/~meszibalu/hbase-connectors-1.0.0RC1/
> > > > and maven artifacts are available here:
> > > >
> > https://repository.apache.org/content/repositories/orgapachehbase-1307/
> > > >
> > > > Artifacts were signed with meszibalu@apache.org key which can be
> found
> > > at:
> > > > https://dist.apache.org/repos/dist/release/hbase/KEYS
> > > >
> > > > Compatibility information:
> > > > - scala 2.11
> > > > - spark 2.4
> > > > - kafka 2.0
> > > >
> > > > It's going to be the first release of hbase-connectors. I have
> updated
> > > the
> > > > documentation for kafka connector [1]. Please follow those steps when
> > > > testing. Spark documentation is pretty good in the refguide [2].
> > > >
> > > > Please note that HBASE-20884 [3] is required for spark, so
> HBase-2.0.4
> > or
> > > > HBase-2.1.1 is required at least.
> > > >
> > > > Please try out the candidate and vote +1/0/-1.
> > > >
> > > > Let me be the first who votes.
> > > >
> > > > +1 (not surprisingly)
> > > >
> > > > - signatures, checksums: OK
> > > > - apache rat check: OK
> > > > - built from source (8u112): OK
> > > > - unit tests: OK
> > > > - kafka connector between hbase-2.1.4 and kafka-2.0.0 : OK
> > > > - spark sql select / insert between hbase-2.1.4 and spark-2.4.0: OK
> > > >
> > > > Best regards,
> > > > Balazs
> > > >
> > > > [1] https://github.com/apache/hbase-connectors/tree/master/kafka
> > > > [2] http://hbase.apache.org/book.html#spark
> > > > [3] https://issues.apache.org/jira/browse/HBASE-20884
> > > >
> > >
> >
>
Re: [VOTE] HBase Connectors 1.0.0RC1
Posted by Artem Ervits <ar...@gmail.com>.
+1 (non-binding)
signatures and sums for src: OK
signatures and sums for bin: OK
compile from src: OpenJDK 1.8.0_212-b04: OK
UTs: OK
ITs: OK
Ratcheck: OK
Additionally, the following nits found during review:
${project.basedir} is in the root of the project after compile
after build, RELEASENOTES.txt, README.txt, CHANGELOG.txt are not in the
built assembly
On Mon, Apr 29, 2019 at 6:53 AM Andor Molnar <an...@cloudera.com.invalid>
wrote:
> +1 (non-binding)
>
> - Checked signature, checksum
> - Built from source
> - Ran all unit / integration tests
>
> I did not run tests with Kafka / Spark.
>
> Regards,
> Andor
>
>
>
>
> On Sat, Apr 27, 2019 at 9:39 PM Stack <st...@duboce.net> wrote:
>
> > +1
> >
> > Sig, hash, license, rat, and build from src all good (I see same detritus
> > as our Josh reports).
> >
> > Thanks Balazs,
> > S
> >
> > On Fri, Apr 26, 2019 at 6:02 AM Balazs Meszaros
> > <ba...@cloudera.com.invalid> wrote:
> >
> > > Please vote on this Apache HBase Connectors release candidate.
> > >
> > > The release files including signatures can be found at:
> > > http://home.apache.org/~meszibalu/hbase-connectors-1.0.0RC1/
> > > and maven artifacts are available here:
> > >
> https://repository.apache.org/content/repositories/orgapachehbase-1307/
> > >
> > > Artifacts were signed with meszibalu@apache.org key which can be found
> > at:
> > > https://dist.apache.org/repos/dist/release/hbase/KEYS
> > >
> > > Compatibility information:
> > > - scala 2.11
> > > - spark 2.4
> > > - kafka 2.0
> > >
> > > It's going to be the first release of hbase-connectors. I have updated
> > the
> > > documentation for kafka connector [1]. Please follow those steps when
> > > testing. Spark documentation is pretty good in the refguide [2].
> > >
> > > Please note that HBASE-20884 [3] is required for spark, so HBase-2.0.4
> or
> > > HBase-2.1.1 is required at least.
> > >
> > > Please try out the candidate and vote +1/0/-1.
> > >
> > > Let me be the first who votes.
> > >
> > > +1 (not surprisingly)
> > >
> > > - signatures, checksums: OK
> > > - apache rat check: OK
> > > - built from source (8u112): OK
> > > - unit tests: OK
> > > - kafka connector between hbase-2.1.4 and kafka-2.0.0 : OK
> > > - spark sql select / insert between hbase-2.1.4 and spark-2.4.0: OK
> > >
> > > Best regards,
> > > Balazs
> > >
> > > [1] https://github.com/apache/hbase-connectors/tree/master/kafka
> > > [2] http://hbase.apache.org/book.html#spark
> > > [3] https://issues.apache.org/jira/browse/HBASE-20884
> > >
> >
>
Re: [VOTE] HBase Connectors 1.0.0RC1
Posted by Andor Molnar <an...@cloudera.com.INVALID>.
+1 (non-binding)
- Checked signature, checksum
- Built from source
- Ran all unit / integration tests
I did not run tests with Kafka / Spark.
Regards,
Andor
On Sat, Apr 27, 2019 at 9:39 PM Stack <st...@duboce.net> wrote:
> +1
>
> Sig, hash, license, rat, and build from src all good (I see same detritus
> as our Josh reports).
>
> Thanks Balazs,
> S
>
> On Fri, Apr 26, 2019 at 6:02 AM Balazs Meszaros
> <ba...@cloudera.com.invalid> wrote:
>
> > Please vote on this Apache HBase Connectors release candidate.
> >
> > The release files including signatures can be found at:
> > http://home.apache.org/~meszibalu/hbase-connectors-1.0.0RC1/
> > and maven artifacts are available here:
> > https://repository.apache.org/content/repositories/orgapachehbase-1307/
> >
> > Artifacts were signed with meszibalu@apache.org key which can be found
> at:
> > https://dist.apache.org/repos/dist/release/hbase/KEYS
> >
> > Compatibility information:
> > - scala 2.11
> > - spark 2.4
> > - kafka 2.0
> >
> > It's going to be the first release of hbase-connectors. I have updated
> the
> > documentation for kafka connector [1]. Please follow those steps when
> > testing. Spark documentation is pretty good in the refguide [2].
> >
> > Please note that HBASE-20884 [3] is required for spark, so HBase-2.0.4 or
> > HBase-2.1.1 is required at least.
> >
> > Please try out the candidate and vote +1/0/-1.
> >
> > Let me be the first who votes.
> >
> > +1 (not surprisingly)
> >
> > - signatures, checksums: OK
> > - apache rat check: OK
> > - built from source (8u112): OK
> > - unit tests: OK
> > - kafka connector between hbase-2.1.4 and kafka-2.0.0 : OK
> > - spark sql select / insert between hbase-2.1.4 and spark-2.4.0: OK
> >
> > Best regards,
> > Balazs
> >
> > [1] https://github.com/apache/hbase-connectors/tree/master/kafka
> > [2] http://hbase.apache.org/book.html#spark
> > [3] https://issues.apache.org/jira/browse/HBASE-20884
> >
>
Re: [VOTE] HBase Connectors 1.0.0RC1
Posted by Stack <st...@duboce.net>.
+1
Sig, hash, license, rat, and build from src all good (I see same detritus
as our Josh reports).
Thanks Balazs,
S
On Fri, Apr 26, 2019 at 6:02 AM Balazs Meszaros
<ba...@cloudera.com.invalid> wrote:
> Please vote on this Apache HBase Connectors release candidate.
>
> The release files including signatures can be found at:
> http://home.apache.org/~meszibalu/hbase-connectors-1.0.0RC1/
> and maven artifacts are available here:
> https://repository.apache.org/content/repositories/orgapachehbase-1307/
>
> Artifacts were signed with meszibalu@apache.org key which can be found at:
> https://dist.apache.org/repos/dist/release/hbase/KEYS
>
> Compatibility information:
> - scala 2.11
> - spark 2.4
> - kafka 2.0
>
> It's going to be the first release of hbase-connectors. I have updated the
> documentation for kafka connector [1]. Please follow those steps when
> testing. Spark documentation is pretty good in the refguide [2].
>
> Please note that HBASE-20884 [3] is required for spark, so HBase-2.0.4 or
> HBase-2.1.1 is required at least.
>
> Please try out the candidate and vote +1/0/-1.
>
> Let me be the first who votes.
>
> +1 (not surprisingly)
>
> - signatures, checksums: OK
> - apache rat check: OK
> - built from source (8u112): OK
> - unit tests: OK
> - kafka connector between hbase-2.1.4 and kafka-2.0.0 : OK
> - spark sql select / insert between hbase-2.1.4 and spark-2.4.0: OK
>
> Best regards,
> Balazs
>
> [1] https://github.com/apache/hbase-connectors/tree/master/kafka
> [2] http://hbase.apache.org/book.html#spark
> [3] https://issues.apache.org/jira/browse/HBASE-20884
>
Re: [VOTE] HBase Connectors 1.0.0RC1
Posted by Josh Elser <el...@apache.org>.
+1 (binding)
* xsums/sigs good
* KEYS up to date
* Can build/test from src
* L&N good for src
Nits:
* Binary release's LICENSE file is missing some stuff. e.g. we bundle
jcodings which is MIT licensed but that is not included in LICENSE. IMO,
we can come back and fix these for the next release.
* We get the ${project.basedir} in the local copy when building because
of the HBase dep of 2.1.0 doesn't have HBASE-21005. Do we want to choose
the latest 2.1.x?
* The rogue .flattened-pom.xml that shows up. Not sure who/what creates
that, but we should figure it out and squash it.
Thanks for putting this together Balazs!!
- Josh
On 4/26/19 9:02 AM, Balazs Meszaros wrote:
> Please vote on this Apache HBase Connectors release candidate.
>
> The release files including signatures can be found at:
> http://home.apache.org/~meszibalu/hbase-connectors-1.0.0RC1/
> and maven artifacts are available here:
> https://repository.apache.org/content/repositories/orgapachehbase-1307/
>
> Artifacts were signed with meszibalu@apache.org key which can be found at:
> https://dist.apache.org/repos/dist/release/hbase/KEYS
>
> Compatibility information:
> - scala 2.11
> - spark 2.4
> - kafka 2.0
>
> It's going to be the first release of hbase-connectors. I have updated the
> documentation for kafka connector [1]. Please follow those steps when
> testing. Spark documentation is pretty good in the refguide [2].
>
> Please note that HBASE-20884 [3] is required for spark, so HBase-2.0.4 or
> HBase-2.1.1 is required at least.
>
> Please try out the candidate and vote +1/0/-1.
>
> Let me be the first who votes.
>
> +1 (not surprisingly)
>
> - signatures, checksums: OK
> - apache rat check: OK
> - built from source (8u112): OK
> - unit tests: OK
> - kafka connector between hbase-2.1.4 and kafka-2.0.0 : OK
> - spark sql select / insert between hbase-2.1.4 and spark-2.4.0: OK
>
> Best regards,
> Balazs
>
> [1] https://github.com/apache/hbase-connectors/tree/master/kafka
> [2] http://hbase.apache.org/book.html#spark
> [3] https://issues.apache.org/jira/browse/HBASE-20884
>