You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2021/01/28 15:38:48 UTC
[kudu-CR](branch-1.14.x) [build] Fix occasional Gradle build failures
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17001
Change subject: [build] Fix occasional Gradle build failures
......................................................................
[build] Fix occasional Gradle build failures
Occasionally, on a clean build environment often as a part of the
CI pipline, the C++ build will fail with cryptic often Protobuf
related failures. It turns out this is a result of multiple
./gradlew calls which depend on the kudu-proto module.
This change fixes the issue by defining a single CMake target
to build the kudu-proto jar.
Change-Id: Iefa02e52a74f8a60c3029188995574ffdb0d3d5c
Reviewed-on: http://gerrit.cloudera.org:8080/16968
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
(cherry picked from commit 202bcae7f12ca0d7ac43e0a07e57f3236c8f968d)
---
M CMakeLists.txt
M src/kudu/hms/CMakeLists.txt
M src/kudu/subprocess/CMakeLists.txt
3 files changed, 13 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/17001/1
--
To view, visit http://gerrit.cloudera.org:8080/17001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iefa02e52a74f8a60c3029188995574ffdb0d3d5c
Gerrit-Change-Number: 17001
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR](branch-1.14.x) [build] Fix occasional Gradle build failures
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17001 )
Change subject: [build] Fix occasional Gradle build failures
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefa02e52a74f8a60c3029188995574ffdb0d3d5c
Gerrit-Change-Number: 17001
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 28 Jan 2021 17:56:46 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.14.x) [build] Fix occasional Gradle build failures
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17001 )
Change subject: [build] Fix occasional Gradle build failures
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefa02e52a74f8a60c3029188995574ffdb0d3d5c
Gerrit-Change-Number: 17001
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 28 Jan 2021 18:04:03 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.14.x) [build] Fix occasional Gradle build failures
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [build] Fix occasional Gradle build failures
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iefa02e52a74f8a60c3029188995574ffdb0d3d5c
Gerrit-Change-Number: 17001
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.14.x) [build] Fix occasional Gradle build failures
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17001 )
Change subject: [build] Fix occasional Gradle build failures
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefa02e52a74f8a60c3029188995574ffdb0d3d5c
Gerrit-Change-Number: 17001
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 28 Jan 2021 17:36:49 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.14.x) [build] Fix occasional Gradle build failures
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17001 )
Change subject: [build] Fix occasional Gradle build failures
......................................................................
[build] Fix occasional Gradle build failures
Occasionally, on a clean build environment often as a part of the
CI pipline, the C++ build will fail with cryptic often Protobuf
related failures. It turns out this is a result of multiple
./gradlew calls which depend on the kudu-proto module.
This change fixes the issue by defining a single CMake target
to build the kudu-proto jar.
Change-Id: Iefa02e52a74f8a60c3029188995574ffdb0d3d5c
Reviewed-on: http://gerrit.cloudera.org:8080/16968
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
(cherry picked from commit 202bcae7f12ca0d7ac43e0a07e57f3236c8f968d)
Reviewed-on: http://gerrit.cloudera.org:8080/17001
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M CMakeLists.txt
M src/kudu/hms/CMakeLists.txt
M src/kudu/subprocess/CMakeLists.txt
3 files changed, 13 insertions(+), 2 deletions(-)
Approvals:
Grant Henke: Verified
Alexey Serbin: Looks good to me, approved
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefa02e52a74f8a60c3029188995574ffdb0d3d5c
Gerrit-Change-Number: 17001
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)