[GitHub] [spark] srowen commented on a change in pull request #26315: [SPARK-29152] Executor Plugin shutdown when dynamic allocation is ena…

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #26315: [SPARK-29152] Executor Plugin shutdown when dynamic allocation is ena…
URL: https://github.com/apache/spark/pull/26315#discussion_r340606461
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
 ##########
 @@ -288,19 +294,24 @@ private[spark] class Executor(
     threadPool.shutdown()
 
     // Notify plugins that executor is shutting down so they can terminate cleanly
+    pluginShutdown
+    if (!isLocal) {
+      env.stop()
+    }
+  }
+
+  private def pluginShutdown: Unit = {
 
 Review comment:
   This should have `()`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org