You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by yukon <yu...@apache.org> on 2017/02/02 14:01:17 UTC
[REVIEW]: Release Apache RocketMQ 4.0.0(incubating)
Hi,
Apache RocketMQ 4.0.0 is a first release version of RocketMQ in ASF, so we
want to mentors, committers and contributors help review and check the RC
before calling a vote:
1.
https://dist.apache.org/repos/dist/dev/incubator/rocketmq/4.0.0-incubating/
KEYS file:
2. https://dist.apache.org/repos/dist/dev/incubator/rocketmq/KEYS
We are performing a source-only release, please kindly let us know if you
have any advice to help we pass the upcoming RocketMQ community vote and
the IPMC vote.
Regards,
yukon
Re: [REVIEW]: Release Apache RocketMQ 4.0.0(incubating)
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Many thanks for your scrupulous check, the mentioned
> file(hs_err_pid87490.log) shouldn't be in the release, the branding issues
> of rocketmq-site and the concerns in README will be resolved before a vote.
As this is your first release, not everything needs to be fixed or be perfect before a vote is called. In fact as long it’s fixed before graduating that’s fine.
Looks to me that the release is in a good shape, there’s some minor branding issues and year wrong in NOTICE and an extra error log file.
There are not serious issues and could even be fixed next release, but also they are easy to fix now :-)
> As for https://github.com/rocketmq, we are considering moving these
> projects into RocketMQ when there are some release versions.
Great! I would consider moving them sooner (before making a release) rather than later. There is likely to be less process involved if you move sooner ie you may need to fill out a software grant to move a large amount of code into the RocketMQ repo.You may also need to get all GitHub users to sign ICLAs if they haven’t done so. IMO it's far better to have active development on those projects here rather than in github.
Thanks,
Justin
Re: [REVIEW]: Release Apache RocketMQ 4.0.0(incubating)
Posted by stevenschew <st...@apache.org>.
Hi, Roman, in view of the urgency of the release of the version, I have
been modified here, thank you
2017-02-06 14:14 GMT+08:00 Roman Shtykh <rs...@yahoo.com.invalid>:
> Hi,
> I would fix [1] before the release. Having tests that fail in the release
> doesn't seem nice to me.(You won't find them in "Errors" because they are
> not handled, but you can find them in the console output).
> [1] https://issues.apache.org/jira/browse/ROCKETMQ-77
>
>
> --Roman
>
>
> On Friday, February 3, 2017 5:26 PM, yukon <yu...@apache.org> wrote:
>
>
> Got it, thanks Justin.
>
> Regards,
> yukon
>
> On Fri, Feb 3, 2017 at 3:40 PM, Justin Mclean <ju...@classsoftware.com>
> wrote:
>
> > Hi,
> >
> > A couple of other things:
> > - You may want to discuss a draft of the announcement on the dev list
> > before making a release.
> > - You also want to update the download page on your incubating website
> [1]
> > via the closer.cgi script.
> >
> > Thanks,
> > Justin
> >
> > 1. http://www.apache.org/dev/release-download-pages.html#links
> > 2. http://www.apache.org/dev/release-download-pages.html#closer
>
>
>
>
Re: [REVIEW]: Release Apache RocketMQ 4.0.0(incubating)
Posted by Roman Shtykh <rs...@yahoo.com.INVALID>.
Hi,
I would fix [1] before the release. Having tests that fail in the release doesn't seem nice to me.(You won't find them in "Errors" because they are not handled, but you can find them in the console output).
[1] https://issues.apache.org/jira/browse/ROCKETMQ-77
--Roman
On Friday, February 3, 2017 5:26 PM, yukon <yu...@apache.org> wrote:
Got it, thanks Justin.
Regards,
yukon
On Fri, Feb 3, 2017 at 3:40 PM, Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> A couple of other things:
> - You may want to discuss a draft of the announcement on the dev list
> before making a release.
> - You also want to update the download page on your incubating website [1]
> via the closer.cgi script.
>
> Thanks,
> Justin
>
> 1. http://www.apache.org/dev/release-download-pages.html#links
> 2. http://www.apache.org/dev/release-download-pages.html#closer
Re: [REVIEW]: Release Apache RocketMQ 4.0.0(incubating)
Posted by yukon <yu...@apache.org>.
Got it, thanks Justin.
Regards,
yukon
On Fri, Feb 3, 2017 at 3:40 PM, Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> A couple of other things:
> - You may want to discuss a draft of the announcement on the dev list
> before making a release.
> - You also want to update the download page on your incubating website [1]
> via the closer.cgi script.
>
> Thanks,
> Justin
>
> 1. http://www.apache.org/dev/release-download-pages.html#links
> 2. http://www.apache.org/dev/release-download-pages.html#closer
Re: [REVIEW]: Release Apache RocketMQ 4.0.0(incubating)
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
A couple of other things:
- You may want to discuss a draft of the announcement on the dev list before making a release.
- You also want to update the download page on your incubating website [1] via the closer.cgi script.
Thanks,
Justin
1. http://www.apache.org/dev/release-download-pages.html#links
2. http://www.apache.org/dev/release-download-pages.html#closer
Re: [REVIEW]: Release Apache RocketMQ 4.0.0(incubating)
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Is this process ok?
Sounds good to me.
You may have to wait 24 hours before announcing the release to allow for the mirrors to catch up. Take a look at the last graph on [1]
Thanks,
Justin
1. https://www.apache.org/mirrors/
Re: [REVIEW]: Release Apache RocketMQ 4.0.0(incubating)
Posted by yukon <yu...@apache.org>.
Hi,
Thanks everyone for this review, this is the TODO list before calling a
vote:
1. Update 2016 to 2016-2017 in notice file.
2. Add notice and disclaimer files to incubator-rocketmq-site.
3. Remove hs_err_pid87490.log from the RC.
4. Polish the README file in RocketMQ repo.
When the TODO list is resolved, we will prepare the RC and upload it to
dist/dev, then call a vote.
After both the PPMC vote and IPMC vote are passed, we will move the RC to
dist/release/, then separately publish to maven, announce the release,
update the rocketmq site.
Is this process ok?
Regards,
yukon
On Fri, Feb 3, 2017 at 9:19 AM, Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> > We want to do source-only release in dist-dir[1] and publish the binary
> > *.jar to maven central repo, is this ok?
>
> The convenience binary may bundle different software and so the LICENSE
> and NOTICE files continued inside may need to be different. [1] Has this
> been checked?
>
> It’s also useful for checking the dependancies and that the convenience
> binary consists only of code made from the source release. [2]
>
> But as the source is considered the official release and the binary just
> there to help out user who don’t want to compile it there is a few way of
> doing this. [3]
>
> Thanks,
> Justin
>
> 1. http://www.apache.org/dev/licensing-howto.html#binary
> 2. http://www.apache.org/legal/release-policy.html#compiled-packages
> 3. http://www.apache.org/legal/release-policy.html#what
Re: [REVIEW]: Release Apache RocketMQ 4.0.0(incubating)
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> We want to do source-only release in dist-dir[1] and publish the binary
> *.jar to maven central repo, is this ok?
The convenience binary may bundle different software and so the LICENSE and NOTICE files continued inside may need to be different. [1] Has this been checked?
It’s also useful for checking the dependancies and that the convenience binary consists only of code made from the source release. [2]
But as the source is considered the official release and the binary just there to help out user who don’t want to compile it there is a few way of doing this. [3]
Thanks,
Justin
1. http://www.apache.org/dev/licensing-howto.html#binary
2. http://www.apache.org/legal/release-policy.html#compiled-packages
3. http://www.apache.org/legal/release-policy.html#what
Re: [REVIEW]: Release Apache RocketMQ 4.0.0(incubating)
Posted by yukon <yu...@apache.org>.
Hi,
@Willem
We want to do source-only release in dist-dir[1] and publish the binary
*.jar to maven central repo, is this ok?
[1]. https://dist.apache.org/repos/dist/.....
@Justin
> Tags in git are changeable so it best to include a tag and a hash in the
official vote email.
Great idea, we will include a tag and the hash in the vote email:
The tag is here:
https://github.com/apache/incubator-rocketmq/tree/rocketmq-all-4.0.0-incubating
The tag hash is: 5cd35c871d06c21b5fd9f148858ed5a9a27b9d5e
Regards,
yukon
On Fri, Feb 3, 2017 at 8:57 AM, yukon <yu...@apache.org> wrote:
> Hi Justin,
>
> Many thanks for your scrupulous check, the mentioned
> file(hs_err_pid87490.log) shouldn't be in the release, the branding issues
> of rocketmq-site and the concerns in README will be resolved before a vote.
>
> As for https://github.com/rocketmq, we are considering moving these
> projects into RocketMQ when there are some release versions.
>
> Regards,
> yukon
>
>
> On Fri, Feb 3, 2017 at 6:13 AM, Justin Mclean <ju...@classsoftware.com>
> wrote:
>
>> Hi,
>>
>> I checked:
>> - incubating in name
>> - contains DISCLAIMER
>> - LICENSE and NOTICE good. NOTICE year needs to be updated to 2017.
>> - No unexpected binary files in source release
>> - All source file have ASF headers
>> - Can compile form source
>>
>> And that would be enough the get a +1 from me on the incubator general
>> list.
>>
>> Should this file be in the release? [1]
>>
>> The incubating site has a few minor branding issues. The IPMC often look
>> at your site when voting on a release so might be a good idea to update it.
>>
>> Some minor concerns I have over the README:
>> - it seems to has a number of links to a commercial 3rd party product
>> product? (https://cn.aliyun.com/product/ons)
>> - it points users at stack overflow and quora to ask question, users
>> should be directed to the mailing lists first
>> - under a header “RocketMQ Community” it includes links to docker and
>> this GitHub https://github.com/rocketmq
>> - branding wise it better to use “Apache RocketMQ” rather than just
>> RocketMQ
>>
>> Why is there code being developed at https://github.com/rocketmq outside
>> of the RocketMQ project?
>>
>> Thanks,
>> Justin
>>
>> 1. rocketmq-all-4.0.0-incubating/store/hs_err_pid87490.log
>
>
>
Re: [REVIEW]: Release Apache RocketMQ 4.0.0(incubating)
Posted by yukon <yu...@apache.org>.
Hi Justin,
Many thanks for your scrupulous check, the mentioned
file(hs_err_pid87490.log) shouldn't be in the release, the branding issues
of rocketmq-site and the concerns in README will be resolved before a vote.
As for https://github.com/rocketmq, we are considering moving these
projects into RocketMQ when there are some release versions.
Regards,
yukon
On Fri, Feb 3, 2017 at 6:13 AM, Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> I checked:
> - incubating in name
> - contains DISCLAIMER
> - LICENSE and NOTICE good. NOTICE year needs to be updated to 2017.
> - No unexpected binary files in source release
> - All source file have ASF headers
> - Can compile form source
>
> And that would be enough the get a +1 from me on the incubator general
> list.
>
> Should this file be in the release? [1]
>
> The incubating site has a few minor branding issues. The IPMC often look
> at your site when voting on a release so might be a good idea to update it.
>
> Some minor concerns I have over the README:
> - it seems to has a number of links to a commercial 3rd party product
> product? (https://cn.aliyun.com/product/ons)
> - it points users at stack overflow and quora to ask question, users
> should be directed to the mailing lists first
> - under a header “RocketMQ Community” it includes links to docker and this
> GitHub https://github.com/rocketmq
> - branding wise it better to use “Apache RocketMQ” rather than just
> RocketMQ
>
> Why is there code being developed at https://github.com/rocketmq outside
> of the RocketMQ project?
>
> Thanks,
> Justin
>
> 1. rocketmq-all-4.0.0-incubating/store/hs_err_pid87490.log
Re: [REVIEW]: Release Apache RocketMQ 4.0.0(incubating)
Posted by Bruce Snyder <br...@gmail.com>.
Looks good, Von. Thank you.
Bruce
On Thu, Feb 9, 2017 at 6:43 PM, Von Gosling <vo...@apache.org> wrote:
>
> Hi Bruce,
>
> I have polished it as you suggest, please review it :-)
>
>
> > 在 2017年2月9日，22:09，Bruce Snyder <br...@gmail.com> 写道：
> >
> > all project development is now taking
> > place in the Apache Incubator and direct people there
>
>
--
perl -e 'print
unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*" );'
ActiveMQ in Action: http://bit.ly/2je6cQ
Blog: http://bsnyder.org/ <http://bruceblog.org/>
Twitter: http://twitter.com/brucesnyder
Re: [REVIEW]: Release Apache RocketMQ 4.0.0(incubating)
Posted by Von Gosling <vo...@apache.org>.
Hi Bruce,
I have polished it as you suggest, please review it :-)
> 在 2017年2月9日，22:09，Bruce Snyder <br...@gmail.com> 写道：
>
> all project development is now taking
> place in the Apache Incubator and direct people there
Re: [REVIEW]: Release Apache RocketMQ 4.0.0(incubating)
Posted by Bruce Snyder <br...@gmail.com>.
I don't think it's a problem to leave it for now, but we should not be
linking to it. In fact, I would recommend adding a message to the Github
RocketMQ README to indicate that all project development is now taking
place in the Apache Incubator and direct people there.
Bruce
On Mon, Feb 6, 2017 at 6:52 PM, Von Gosling <vo...@apache.org> wrote:
> > the concerns he has pointed out in the README must be
> > fixed before release. I also do not understand why the Github RocketMQ
> > project still exists?
>
> Some points have been fixed before we started a vote thread yesterday :-)
>
> Actually, i am not sure the necessity of the existence of the Github
> RocketMQ. Bruce, could we just leave it until the graduation of the
> RocketMQ TLP stage coming. May be it can provide some vestiges of RocketMQ
> project.
>
>
>
> > 在 2017年2月7日，00:11，Bruce Snyder <br...@gmail.com> 写道：
> >
> > I agree with Justin, the concerns he has pointed out in the README must
> be
> > fixed before release. I also do not understand why the Github RocketMQ
> > project still exists?
> >
> > Bruce
> >
> > On Thu, Feb 2, 2017 at 3:13 PM, Justin Mclean <ju...@classsoftware.com>
> > wrote:
> >
> >> Hi,
> >>
> >> I checked:
> >> - incubating in name
> >> - contains DISCLAIMER
> >> - LICENSE and NOTICE good. NOTICE year needs to be updated to 2017.
> >> - No unexpected binary files in source release
> >> - All source file have ASF headers
> >> - Can compile form source
> >>
> >> And that would be enough the get a +1 from me on the incubator general
> >> list.
> >>
> >> Should this file be in the release? [1]
> >>
> >> The incubating site has a few minor branding issues. The IPMC often look
> >> at your site when voting on a release so might be a good idea to update
> it.
> >>
> >> Some minor concerns I have over the README:
> >> - it seems to has a number of links to a commercial 3rd party product
> >> product? (https://cn.aliyun.com/product/ons)
> >> - it points users at stack overflow and quora to ask question, users
> >> should be directed to the mailing lists first
> >> - under a header “RocketMQ Community” it includes links to docker and
> this
> >> GitHub https://github.com/rocketmq
> >> - branding wise it better to use “Apache RocketMQ” rather than just
> >> RocketMQ
> >>
> >> Why is there code being developed at https://github.com/rocketmq
> outside
> >> of the RocketMQ project?
> >>
> >> Thanks,
> >> Justin
> >>
> >> 1. rocketmq-all-4.0.0-incubating/store/hs_err_pid87490.log
> >
> >
> >
> >
> > --
> > perl -e 'print
> > unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*" );'
> >
> > ActiveMQ in Action: http://bit.ly/2je6cQ
> > Blog: http://bsnyder.org/ <http://bruceblog.org/>
> > Twitter: http://twitter.com/brucesnyder
>
>
--
perl -e 'print
unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*" );'
ActiveMQ in Action: http://bit.ly/2je6cQ
Blog: http://bsnyder.org/ <http://bruceblog.org/>
Twitter: http://twitter.com/brucesnyder
Re: [REVIEW]: Release Apache RocketMQ 4.0.0(incubating)
Posted by Von Gosling <vo...@apache.org>.
> the concerns he has pointed out in the README must be
> fixed before release. I also do not understand why the Github RocketMQ
> project still exists?
Some points have been fixed before we started a vote thread yesterday :-)
Actually, i am not sure the necessity of the existence of the Github RocketMQ. Bruce, could we just leave it until the graduation of the RocketMQ TLP stage coming. May be it can provide some vestiges of RocketMQ project.
> 在 2017年2月7日，00:11，Bruce Snyder <br...@gmail.com> 写道：
>
> I agree with Justin, the concerns he has pointed out in the README must be
> fixed before release. I also do not understand why the Github RocketMQ
> project still exists?
>
> Bruce
>
> On Thu, Feb 2, 2017 at 3:13 PM, Justin Mclean <ju...@classsoftware.com>
> wrote:
>
>> Hi,
>>
>> I checked:
>> - incubating in name
>> - contains DISCLAIMER
>> - LICENSE and NOTICE good. NOTICE year needs to be updated to 2017.
>> - No unexpected binary files in source release
>> - All source file have ASF headers
>> - Can compile form source
>>
>> And that would be enough the get a +1 from me on the incubator general
>> list.
>>
>> Should this file be in the release? [1]
>>
>> The incubating site has a few minor branding issues. The IPMC often look
>> at your site when voting on a release so might be a good idea to update it.
>>
>> Some minor concerns I have over the README:
>> - it seems to has a number of links to a commercial 3rd party product
>> product? (https://cn.aliyun.com/product/ons)
>> - it points users at stack overflow and quora to ask question, users
>> should be directed to the mailing lists first
>> - under a header “RocketMQ Community” it includes links to docker and this
>> GitHub https://github.com/rocketmq
>> - branding wise it better to use “Apache RocketMQ” rather than just
>> RocketMQ
>>
>> Why is there code being developed at https://github.com/rocketmq outside
>> of the RocketMQ project?
>>
>> Thanks,
>> Justin
>>
>> 1. rocketmq-all-4.0.0-incubating/store/hs_err_pid87490.log
>
>
>
>
> --
> perl -e 'print
> unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*" );'
>
> ActiveMQ in Action: http://bit.ly/2je6cQ
> Blog: http://bsnyder.org/ <http://bruceblog.org/>
> Twitter: http://twitter.com/brucesnyder
Re: [REVIEW]: Release Apache RocketMQ 4.0.0(incubating)
Posted by Bruce Snyder <br...@gmail.com>.
I agree with Justin, the concerns he has pointed out in the README must be
fixed before release. I also do not understand why the Github RocketMQ
project still exists?
Bruce
On Thu, Feb 2, 2017 at 3:13 PM, Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> I checked:
> - incubating in name
> - contains DISCLAIMER
> - LICENSE and NOTICE good. NOTICE year needs to be updated to 2017.
> - No unexpected binary files in source release
> - All source file have ASF headers
> - Can compile form source
>
> And that would be enough the get a +1 from me on the incubator general
> list.
>
> Should this file be in the release? [1]
>
> The incubating site has a few minor branding issues. The IPMC often look
> at your site when voting on a release so might be a good idea to update it.
>
> Some minor concerns I have over the README:
> - it seems to has a number of links to a commercial 3rd party product
> product? (https://cn.aliyun.com/product/ons)
> - it points users at stack overflow and quora to ask question, users
> should be directed to the mailing lists first
> - under a header “RocketMQ Community” it includes links to docker and this
> GitHub https://github.com/rocketmq
> - branding wise it better to use “Apache RocketMQ” rather than just
> RocketMQ
>
> Why is there code being developed at https://github.com/rocketmq outside
> of the RocketMQ project?
>
> Thanks,
> Justin
>
> 1. rocketmq-all-4.0.0-incubating/store/hs_err_pid87490.log
--
perl -e 'print
unpack("u30","D0G)U8V4\@4VYY9&5R\"F)R=6-E+G-N>61E<D\!G;6%I;\"YC;VT*" );'
ActiveMQ in Action: http://bit.ly/2je6cQ
Blog: http://bsnyder.org/ <http://bruceblog.org/>
Twitter: http://twitter.com/brucesnyder
Re: [REVIEW]: Release Apache RocketMQ 4.0.0(incubating)
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
I checked:
- incubating in name
- contains DISCLAIMER
- LICENSE and NOTICE good. NOTICE year needs to be updated to 2017.
- No unexpected binary files in source release
- All source file have ASF headers
- Can compile form source
And that would be enough the get a +1 from me on the incubator general list.
Should this file be in the release? [1]
The incubating site has a few minor branding issues. The IPMC often look at your site when voting on a release so might be a good idea to update it.
Some minor concerns I have over the README:
- it seems to has a number of links to a commercial 3rd party product product? (https://cn.aliyun.com/product/ons)
- it points users at stack overflow and quora to ask question, users should be directed to the mailing lists first
- under a header “RocketMQ Community” it includes links to docker and this GitHub https://github.com/rocketmq
- branding wise it better to use “Apache RocketMQ” rather than just RocketMQ
Why is there code being developed at https://github.com/rocketmq outside of the RocketMQ project?
Thanks,
Justin
1. rocketmq-all-4.0.0-incubating/store/hs_err_pid87490.log
Re: [REVIEW]: Release Apache RocketMQ 4.0.0(incubating)
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> BTW, we also need a tag to keep tracking the released source.
Tags in git are changeable so it best to include a tag and a hash in the official vote email.
Thanks,
Justin
Re: [REVIEW]: Release Apache RocketMQ 4.0.0(incubating)
Posted by Willem Jiang <wi...@gmail.com>.
Just a quick question about this 4.0.0 release, do we have any binary
release plan?
BTW, we also need a tag to keep tracking the released source.
Willem Jiang
Blog: http://willemjiang.blogspot.com (English)
http://jnn.iteye.com (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem
On Thu, Feb 2, 2017 at 10:01 PM, yukon <yu...@apache.org> wrote:
> Hi,
>
> Apache RocketMQ 4.0.0 is a first release version of RocketMQ in ASF, so we
> want to mentors, committers and contributors help review and check the RC
> before calling a vote:
>
> 1.
> https://dist.apache.org/repos/dist/dev/incubator/rocketmq/4.
> 0.0-incubating/
>
> KEYS file:
>
> 2. https://dist.apache.org/repos/dist/dev/incubator/rocketmq/KEYS
>
> We are performing a source-only release, please kindly let us know if you
> have any advice to help we pass the upcoming RocketMQ community vote and
> the IPMC vote.
>
> Regards,
> yukon
>