You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by arpadboda <gi...@git.apache.org> on 2018/11/26 10:31:19 UTC
[GitHub] nifi-minifi-cpp pull request #449: MINIFICPP-685 - Improve const correctness...
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/449
MINIFICPP-685 - Improve const correctness of property getters
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arpadboda/nifi-minifi-cpp MINIFICPP-685
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/449.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #449
----
commit 480929ac554b48ee717b19de4d589c0abfa14513
Author: Arpad Boda <ab...@...>
Date: 2018-11-26T10:30:20Z
MINIFICPP-685 - Improve const correctness of property getters
----
---
[GitHub] nifi-minifi-cpp pull request #449: MINIFICPP-685 - Improve const correctness...
Posted by arpadboda <gi...@git.apache.org>.
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/449#discussion_r236665802
--- Diff: libminifi/include/core/ConfigurableComponent.h ---
@@ -153,14 +153,14 @@ class ConfigurableComponent {
*
* @return vector of property keys
*/
- std::vector<std::string> getDynamicPropertyKeys();
+ std::vector<std::string> getDynamicPropertyKeys() const;
/**
* Returns a vector all properties
*
* @return map of property keys to Property instances.
*/
- std::map<std::string, Property> getProperties();
+ std::map<std::string, Property> getProperties() const;
--- End diff --
Nope, the map is created upon execution, (a merge of dynamic and static properties), so there is no real point in returning const ref.
---
[GitHub] nifi-minifi-cpp pull request #449: MINIFICPP-685 - Improve const correctness...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/449#discussion_r236664502
--- Diff: libminifi/include/core/ConfigurableComponent.h ---
@@ -153,14 +153,14 @@ class ConfigurableComponent {
*
* @return vector of property keys
*/
- std::vector<std::string> getDynamicPropertyKeys();
+ std::vector<std::string> getDynamicPropertyKeys() const;
/**
* Returns a vector all properties
*
* @return map of property keys to Property instances.
*/
- std::map<std::string, Property> getProperties();
+ std::map<std::string, Property> getProperties() const;
--- End diff --
Did you not change to const ref map because current implementations expect to modify this map?
---
[GitHub] nifi-minifi-cpp pull request #449: MINIFICPP-685 - Improve const correctness...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/449
---