You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/03/13 14:26:07 UTC
Review Request 57558: Add a property to enable Status commands on
separate process (non-default)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57558/
-----------------------------------------------------------
Review request for Ambari and Eugene Chekanskiy.
Bugs: AMBARI-20419
https://issues.apache.org/jira/browse/AMBARI-20419
Repository: ambari
Description
-------
It reproduces in tests but not so rare race condition that affects running status
commands on separate process and mechanics of killing and re-spawning the
process on command timeouts.
The suggestion is to add a flag and enable this functionality only as needed.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/ActionQueue.py 15ae03d
ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 26e54ec
ambari-agent/src/main/python/ambari_agent/Controller.py a123f2f
ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 5c1c54a
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 8701a24
Diff: https://reviews.apache.org/r/57558/diff/1/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 57558: Add a property to enable Status commands on
separate process (non-default)
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57558/#review168761
-----------------------------------------------------------
Ship it!
Ship It!
- Eugene Chekanskiy
On March 13, 2017, 2:26 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57558/
> -----------------------------------------------------------
>
> (Updated March 13, 2017, 2:26 p.m.)
>
>
> Review request for Ambari and Eugene Chekanskiy.
>
>
> Bugs: AMBARI-20419
> https://issues.apache.org/jira/browse/AMBARI-20419
>
>
> Repository: ambari
>
>
> Description
> -------
>
> It reproduces in tests but not so rare race condition that affects running status
> commands on separate process and mechanics of killing and re-spawning the
> process on command timeouts.
>
> The suggestion is to add a flag and enable this functionality only as needed.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py 15ae03d
> ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 26e54ec
> ambari-agent/src/main/python/ambari_agent/Controller.py a123f2f
> ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 5c1c54a
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 8701a24
>
>
> Diff: https://reviews.apache.org/r/57558/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>