You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jan Høydahl (JIRA)" <ji...@apache.org> on 2018/04/08 20:19:00 UTC
[jira] [Commented] (SOLR-10453) setBasicAuthHeader should be
deprecated in favor of SolrClientBuilder methods
[ https://issues.apache.org/jira/browse/SOLR-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429874#comment-16429874 ]
Jan Høydahl commented on SOLR-10453:
------------------------------------
Perhaps I was too quick in marking this as duplicate of SOLR-12194. [~gerlowskija] can you elaborate on which {{setBasicAuthHeader}} method your are referring to here, I can only find one private method in {{HttpSolrClient}}? and why it should be deprecated?
> setBasicAuthHeader should be deprecated in favor of SolrClientBuilder methods
> -----------------------------------------------------------------------------
>
> Key: SOLR-10453
> URL: https://issues.apache.org/jira/browse/SOLR-10453
> Project: Solr
> Issue Type: Sub-task
> Components: SolrJ
> Reporter: Jason Gerlowski
> Assignee: Jan Høydahl
> Priority: Minor
> Fix For: 7.0
>
>
> Now that builders are in place for {{SolrClients}}, the setters used in each {{SolrClient}} can be deprecated, and their functionality moved over to the Builders. This change brings a few benefits:
> - unifies {{SolrClient}} configuration under the new Builders. It'll be nice to have all the knobs, and levers used to tweak {{SolrClient}}s available in a single place (the Builders).
> - reduces {{SolrClient}} thread-safety concerns. Currently, clients are mutable. Using some {{SolrClient}} setters can result in erratic and "trappy" behavior when the clients are used across multiple threads.
> This subtask endeavors to change this behavior for the {{setBasicAuthHeader}} setter on all {{SolrClient}} implementations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org