You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/10 11:15:08 UTC
[GitHub] [superset] codecov[bot] edited a comment on pull request #14069: feat: impersonate supports in trino engine
codecov[bot] edited a comment on pull request #14069:
URL: https://github.com/apache/superset/pull/14069#issuecomment-817119409
# [Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=h1) Report
> Merging [#14069](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=desc) (99426ed) into [master](https://codecov.io/gh/apache/superset/commit/fe08b698f5fd4ccc0b511f755007a4aa6db8b3ca?el=desc) (fe08b69) will **decrease** coverage by `0.28%`.
> The diff coverage is `60.00%`.
> :exclamation: Current head 99426ed differs from pull request most recent head 90b8c7d. Consider uploading reports for the commit 90b8c7d to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14069 +/- ##
==========================================
- Coverage 79.35% 79.06% -0.29%
==========================================
Files 939 939
Lines 47538 47547 +9
Branches 5938 5938
==========================================
- Hits 37723 37594 -129
- Misses 9693 9831 +138
Partials 122 122
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.74% <60.00%> (-0.01%)` | :arrow_down: |
| presto | `?` | |
| python | `80.78% <60.00%> (-0.54%)` | :arrow_down: |
| sqlite | `80.34% <60.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <ø> (ø)` | |
| [superset/db\_engine\_specs/trino.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RyaW5vLnB5) | `80.00% <60.00%> (-10.48%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-8.16%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.44% <0.00%> (-1.71%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.66% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.28% <0.00%> (-1.09%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.99% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/14069/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=footer). Last update [fe08b69...90b8c7d](https://codecov.io/gh/apache/superset/pull/14069?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org