You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by kevinlacire <gi...@git.apache.org> on 2017/12/18 12:53:13 UTC

[GitHub] lucene-solr pull request #293: spellcheck prefix already contains a trailing...

GitHub user kevinlacire opened a pull request:

    https://github.com/apache/lucene-solr/pull/293

    spellcheck prefix already contains a trailing dot

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kevinlacire/lucene-solr patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/293.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #293
    
----
commit 42a9aefc6fcba154ed9d969d04658fd563f07421
Author: Kévin <ke...@gmail.com>
Date:   2017-12-18T12:53:04Z

    spellcheck prefix already contains a trailing dot

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[GitHub] lucene-solr pull request #293: spellcheck prefix already contains a trailing...

Posted by diegoceccarelli <gi...@git.apache.org>.
Github user diegoceccarelli commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/293#discussion_r159154912
  
    --- Diff: solr/core/src/java/org/apache/solr/handler/component/SpellCheckComponent.java ---
    @@ -339,7 +339,7 @@ private void addOriginalTermsToResponse(NamedList response, Collection<Token> or
       protected SolrParams getCustomParams(String dictionary, SolrParams params) {
         ModifiableSolrParams result = new ModifiableSolrParams();
         Iterator<String> iter = params.getParameterNamesIterator();
    -    String prefix = SpellingParams.SPELLCHECK_PREFIX + "." + dictionary + ".";
    +    String prefix = SpellingParams.SPELLCHECK_PREFIX + dictionary + ".";
    --- End diff --
    
    What about checking if dictionary containing the trailing dot in the code? 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org