You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "ByteFlow777 (via GitHub)" <gi...@apache.org> on 2023/02/18 14:42:27 UTC
[GitHub] [incubator-eventmesh] ByteFlow777 opened a new pull request, #3200: Remove unused setters in enum type
ByteFlow777 opened a new pull request, #3200:
URL: https://github.com/apache/incubator-eventmesh/pull/3200
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
### Motivation
Enum type should be immutable, we should set fields to final.
### Modifications
Remove unused setters and make fields to final.
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #3200: [ISSUE #3202] Remove unused setters in enum type
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3200:
URL: https://github.com/apache/incubator-eventmesh/pull/3200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #3200: [ISSUE #3202] Remove unused setters in enum type
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3200:
URL: https://github.com/apache/incubator-eventmesh/pull/3200#issuecomment-1435935798
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/3200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3200](https://codecov.io/gh/apache/incubator-eventmesh/pull/3200?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b87708b) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/4585ba81638f8dd87472414d1441870cc85d0fcd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4585ba8) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head b87708b differs from pull request most recent head c038837. Consider uploading reports for the commit c038837 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3200 +/- ##
============================================
+ Coverage 13.01% 13.03% +0.01%
Complexity 1154 1154
============================================
Files 548 548
Lines 28740 28702 -38
Branches 2843 2843
============================================
Hits 3741 3741
+ Misses 24678 24640 -38
Partials 321 321
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/3200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../eventmesh/common/loadbalance/LoadBalanceType.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9sb2FkYmFsYW5jZS9Mb2FkQmFsYW5jZVR5cGUuamF2YQ==) | `80.00% <ø> (+22.85%)` | :arrow_up: |
| [...he/eventmesh/common/protocol/SubscriptionMode.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9TdWJzY3JpcHRpb25Nb2RlLmphdmE=) | `0.00% <ø> (ø)` | |
| [...he/eventmesh/common/protocol/SubscriptionType.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9TdWJzY3JpcHRpb25UeXBlLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ntmesh/common/protocol/grpc/common/StatusCode.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9ncnBjL2NvbW1vbi9TdGF0dXNDb2RlLmphdmE=) | `0.00% <ø> (ø)` | |
| [...esh/common/protocol/http/common/ClientRetCode.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2NvbW1vbi9DbGllbnRSZXRDb2RlLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ntmesh/common/protocol/http/common/ClientType.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2NvbW1vbi9DbGllbnRUeXBlLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../common/protocol/http/common/EventMeshRetCode.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2NvbW1vbi9FdmVudE1lc2hSZXRDb2RlLmphdmE=) | `0.00% <ø> (ø)` | |
| [...h/common/protocol/http/common/ProtocolVersion.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2NvbW1vbi9Qcm90b2NvbFZlcnNpb24uamF2YQ==) | `50.00% <ø> (+5.00%)` | :arrow_up: |
| [...tmesh/common/protocol/http/common/RequestCode.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2NvbW1vbi9SZXF1ZXN0Q29kZS5qYXZh) | `0.00% <ø> (ø)` | |
| [...ntmesh/common/protocol/http/common/RequestURI.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2NvbW1vbi9SZXF1ZXN0VVJJLmphdmE=) | `0.00% <ø> (ø)` | |
| ... and [1 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/3200?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org