[GitHub] [helix] jiajunwang commented on a change in pull request #564: Avoid redundant writes in AssignmentMetadataStore

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #564: Avoid redundant writes in AssignmentMetadataStore
URL: https://github.com/apache/helix/pull/564#discussion_r342257687
 
 

 ##########
 File path: helix-core/src/test/java/org/apache/helix/controller/rebalancer/waged/TestAssignmentMetadataStore.java
 ##########
 @@ -81,7 +90,7 @@ public void beforeClass() throws Exception {
     _manager.connect();
 
     // create AssignmentMetadataStore
-    _store = new AssignmentMetadataStore(_manager.getMetadataStoreConnectionString(),
+    _store = new MockAssignmentMetadataStore(_manager.getMetadataStoreConnectionString(),
 
 Review comment:
   Moreover, I think even we need this mock, it should be used for testAvoidingRedundantWrite() only. As for the other test method, they should be still using the original assignment store class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org