You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/13 18:18:59 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6269: xtensa: use CONFIG_ARCH_FPU macro for coprocossor and add up_fpucmp

xiaoxiang781216 commented on code in PR #6269:
URL: https://github.com/apache/incubator-nuttx/pull/6269#discussion_r872659845


##########
arch/xtensa/include/irq.h:
##########
@@ -123,7 +123,7 @@
 #  define _REG_CP_START  _REG_OVLY_START
 #endif
 
-#if XCHAL_CP_NUM > 0

Review Comment:
   let's keep all place with reference XCHAL_CP_NUM except up_fpucmp



##########
arch/xtensa/Kconfig:
##########
@@ -13,6 +13,7 @@ config ARCH_CHIP_ESP32
 	bool "Espressif ESP32"
 	select ARCH_FAMILY_LX6
 	select XTENSA_HAVE_INTERRUPTS
+	select ARCH_HAVE_FPU

Review Comment:
   @Ouss4 has esp32 FPU?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org