[GitHub] [flink] haodang commented on issue #9980: [WIP][FLINK-14398][SQL/Legacy Planner]Further split input unboxing code into separate methods

[GitBox <gi...@apache.org>]

haodang commented on issue #9980: [WIP][FLINK-14398][SQL/Legacy Planner]Further split input unboxing code into separate methods
URL: https://github.com/apache/flink/pull/9980#issuecomment-546006276
 
 
   Thank you @wuchong @zentol for the response.  The code is ready for review now.  I was having issues with my IDE last night and wanted push it here to run tests and unblock as I fix things locally.
   
   There is one thing that I'd like to discuss for this version of implementation: technically we haven't split `all` code blocks inside `CodeGenerator#reusableInputUnboxingExprs`, because currently the split happens in `CodeGenerator#generateResultExpression` and more expressions could be added to  `CodeGenerator#reusableInputUnboxingExprs` after `CodeGenerator#generateResultExpression` is called.
   
   The rationale was to minimize splitting and split unboxing input code only relevant to those result setters (which was the root cause of the JIRA issue).  Wanted to hear your thought on this and see if there is an approach that fits the codebase better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services