You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by James Taylor <ja...@apache.org> on 2015/04/17 21:49:05 UTC
please fix IDE compiler errors for pherf and phoenix-server
We document our compiler settings and provide a set of Eclipse
preferences that can be loaded into your IDE in
dev/eclipse_prefs_phoenix.epf. With the current code in master, I'm
getting the compilation errors below.
Would the folks responsible for those areas please fix them and adjust
their IDE settings so that they don't creep back in?
Thanks,
James
Description Resource Path Location Type
The method writeXML() from the type ConfigurationParserTest is never
used locally ConfigurationParserTest.java
/pherf/src/test/java/org/apache/phoenix/pherf line 141 Java Problem
The value of the field DataLoader.properties is not used
DataLoader.java /pherf/src/main/java/org/apache/phoenix/pherf/loaddata
line 61 Java Problem
The value of the field DataLoaderTest.loader is not used
DataLoaderTest.java /pherf/src/test/java/org/apache/phoenix/pherf line
34 Java Problem
The value of the field DataLoaderTest.model is not used
DataLoaderTest.java /pherf/src/test/java/org/apache/phoenix/pherf line
33 Java Problem
The value of the field QueryExecutor.resultUtil is not used
QueryExecutor.java
/pherf/src/main/java/org/apache/phoenix/pherf/workload line 47 Java
Problem
The value of the field QueryServerThread.LOG is not used
QueryServerThread.java
/phoenix-server/src/it/java/org/apache/phoenix/end2end line 30 Java
Problem
The value of the field Result.type is not used Result.java
/pherf/src/main/java/org/apache/phoenix/pherf/result line 30 Java
Problem
Type String[] of the last argument to method printRecord(Object...)
doesn't exactly match the vararg parameter type. Cast to Object[] to
confirm the non-varargs invocation, or pass individual arguments of
type Object for a varargs invocation. CSVResultHandler.java
/pherf/src/main/java/org/apache/phoenix/pherf/result/impl line 126
Java Problem
Re: please fix IDE compiler errors for pherf and phoenix-server
Posted by Cody Marcel <cm...@salesforce.com>.
Sorry my daughter is sick. I will get to in Monday
Sent from my iPhone
> On Apr 18, 2015, at 11:14 AM, James Taylor <ja...@apache.org> wrote:
>
> No I don't think it's harsh. It's the third time I've asked. The
> first two were ignored[1]. It's a 10min task to fix the compiler
> errors and it's been more than two days.
>
> It impacts everyone doing development through Eclipse with the
> documented compiler options. What about new people trying to load the
> project into Eclipse for the first time and it won't compile? I don't
> think it's fair that everyone needs to work around this or that
> someone else is stuck cleaning it up.
>
> Would be great if someone could volunteer to port the HBase
> pre-checkin Jenkins that only let's check-ins through that compile
> according to our IDE settings and that don't break tests.
>
> Thanks,
> James
>
> [1] https://issues.apache.org/jira/browse/PHOENIX-1873
>
>> On Sat, Apr 18, 2015 at 10:42 AM, Jesse Yates <je...@gmail.com> wrote:
>> A little harsh, dont you think? He said he was going to look at it... And
>> technically, it still compiles (in mvn, the source of compilation truth) so
>> it's not blocking anyone
>>
>>> On Sat, Apr 18, 2015, 9:45 AM James Taylor <ja...@apache.org> wrote:
>>>
>>> Cody,
>>> For everyone using the default Eclipse setting, the project won't build in
>>> the IDE right now. The fix you need to make is to modify the Pherf code so
>>> that it compiles. These are very simple changes such as removing local
>>> variables that aren't used. Would appreciate if you could do this so that
>>> all other contributors do not have to take action to work around this.
>>>
>>> James
>>>
>>>> On Friday, April 17, 2015, Cody Marcel <cm...@salesforce.com> wrote:
>>>>
>>>> I'll take a look at my Intellij settings. I did import the prefs from
>>>> eclipse, but the import is not perfect so maybe some were left out.
>>>>
>>>> On Fri, Apr 17, 2015 at 12:49 PM, James Taylor <jamestaylor@apache.org
>>>> <javascript:;>>
>>>> wrote:
>>>>
>>>>> We document our compiler settings and provide a set of Eclipse
>>>>> preferences that can be loaded into your IDE in
>>>>> dev/eclipse_prefs_phoenix.epf. With the current code in master, I'm
>>>>> getting the compilation errors below.
>>>>>
>>>>> Would the folks responsible for those areas please fix them and adjust
>>>>> their IDE settings so that they don't creep back in?
>>>>>
>>>>> Thanks,
>>>>> James
>>>>>
>>>>> Description Resource Path Location Type
>>>>> The method writeXML() from the type ConfigurationParserTest is never
>>>>> used locally ConfigurationParserTest.java
>>>>> /pherf/src/test/java/org/apache/phoenix/pherf line 141 Java Problem
>>>>> The value of the field DataLoader.properties is not used
>>>>> DataLoader.java /pherf/src/main/java/org/apache/phoenix/pherf/loaddata
>>>>> line 61 Java Problem
>>>>> The value of the field DataLoaderTest.loader is not used
>>>>> DataLoaderTest.java /pherf/src/test/java/org/apache/phoenix/pherf line
>>>>> 34 Java Problem
>>>>> The value of the field DataLoaderTest.model is not used
>>>>> DataLoaderTest.java /pherf/src/test/java/org/apache/phoenix/pherf line
>>>>> 33 Java Problem
>>>>> The value of the field QueryExecutor.resultUtil is not used
>>>>> QueryExecutor.java
>>>>> /pherf/src/main/java/org/apache/phoenix/pherf/workload line 47 Java
>>>>> Problem
>>>>> The value of the field QueryServerThread.LOG is not used
>>>>> QueryServerThread.java
>>>>> /phoenix-server/src/it/java/org/apache/phoenix/end2end line 30 Java
>>>>> Problem
>>>>> The value of the field Result.type is not used Result.java
>>>>> /pherf/src/main/java/org/apache/phoenix/pherf/result line 30 Java
>>>>> Problem
>>>>> Type String[] of the last argument to method printRecord(Object...)
>>>>> doesn't exactly match the vararg parameter type. Cast to Object[] to
>>>>> confirm the non-varargs invocation, or pass individual arguments of
>>>>> type Object for a varargs invocation. CSVResultHandler.java
>>>>> /pherf/src/main/java/org/apache/phoenix/pherf/result/impl line 126
>>>>> Java Problem
>>>
Re: please fix IDE compiler errors for pherf and phoenix-server
Posted by James Taylor <ja...@apache.org>.
No I don't think it's harsh. It's the third time I've asked. The
first two were ignored[1]. It's a 10min task to fix the compiler
errors and it's been more than two days.
It impacts everyone doing development through Eclipse with the
documented compiler options. What about new people trying to load the
project into Eclipse for the first time and it won't compile? I don't
think it's fair that everyone needs to work around this or that
someone else is stuck cleaning it up.
Would be great if someone could volunteer to port the HBase
pre-checkin Jenkins that only let's check-ins through that compile
according to our IDE settings and that don't break tests.
Thanks,
James
[1] https://issues.apache.org/jira/browse/PHOENIX-1873
On Sat, Apr 18, 2015 at 10:42 AM, Jesse Yates <je...@gmail.com> wrote:
> A little harsh, dont you think? He said he was going to look at it... And
> technically, it still compiles (in mvn, the source of compilation truth) so
> it's not blocking anyone
>
> On Sat, Apr 18, 2015, 9:45 AM James Taylor <ja...@apache.org> wrote:
>
>> Cody,
>> For everyone using the default Eclipse setting, the project won't build in
>> the IDE right now. The fix you need to make is to modify the Pherf code so
>> that it compiles. These are very simple changes such as removing local
>> variables that aren't used. Would appreciate if you could do this so that
>> all other contributors do not have to take action to work around this.
>>
>> James
>>
>> On Friday, April 17, 2015, Cody Marcel <cm...@salesforce.com> wrote:
>>
>> > I'll take a look at my Intellij settings. I did import the prefs from
>> > eclipse, but the import is not perfect so maybe some were left out.
>> >
>> > On Fri, Apr 17, 2015 at 12:49 PM, James Taylor <jamestaylor@apache.org
>> > <javascript:;>>
>> > wrote:
>> >
>> > > We document our compiler settings and provide a set of Eclipse
>> > > preferences that can be loaded into your IDE in
>> > > dev/eclipse_prefs_phoenix.epf. With the current code in master, I'm
>> > > getting the compilation errors below.
>> > >
>> > > Would the folks responsible for those areas please fix them and adjust
>> > > their IDE settings so that they don't creep back in?
>> > >
>> > > Thanks,
>> > > James
>> > >
>> > > Description Resource Path Location Type
>> > > The method writeXML() from the type ConfigurationParserTest is never
>> > > used locally ConfigurationParserTest.java
>> > > /pherf/src/test/java/org/apache/phoenix/pherf line 141 Java Problem
>> > > The value of the field DataLoader.properties is not used
>> > > DataLoader.java /pherf/src/main/java/org/apache/phoenix/pherf/loaddata
>> > > line 61 Java Problem
>> > > The value of the field DataLoaderTest.loader is not used
>> > > DataLoaderTest.java /pherf/src/test/java/org/apache/phoenix/pherf line
>> > > 34 Java Problem
>> > > The value of the field DataLoaderTest.model is not used
>> > > DataLoaderTest.java /pherf/src/test/java/org/apache/phoenix/pherf line
>> > > 33 Java Problem
>> > > The value of the field QueryExecutor.resultUtil is not used
>> > > QueryExecutor.java
>> > > /pherf/src/main/java/org/apache/phoenix/pherf/workload line 47 Java
>> > > Problem
>> > > The value of the field QueryServerThread.LOG is not used
>> > > QueryServerThread.java
>> > > /phoenix-server/src/it/java/org/apache/phoenix/end2end line 30 Java
>> > > Problem
>> > > The value of the field Result.type is not used Result.java
>> > > /pherf/src/main/java/org/apache/phoenix/pherf/result line 30 Java
>> > > Problem
>> > > Type String[] of the last argument to method printRecord(Object...)
>> > > doesn't exactly match the vararg parameter type. Cast to Object[] to
>> > > confirm the non-varargs invocation, or pass individual arguments of
>> > > type Object for a varargs invocation. CSVResultHandler.java
>> > > /pherf/src/main/java/org/apache/phoenix/pherf/result/impl line 126
>> > > Java Problem
>> > >
>> >
>>
Re: please fix IDE compiler errors for pherf and phoenix-server
Posted by Jesse Yates <je...@gmail.com>.
A little harsh, dont you think? He said he was going to look at it... And
technically, it still compiles (in mvn, the source of compilation truth) so
it's not blocking anyone
On Sat, Apr 18, 2015, 9:45 AM James Taylor <ja...@apache.org> wrote:
> Cody,
> For everyone using the default Eclipse setting, the project won't build in
> the IDE right now. The fix you need to make is to modify the Pherf code so
> that it compiles. These are very simple changes such as removing local
> variables that aren't used. Would appreciate if you could do this so that
> all other contributors do not have to take action to work around this.
>
> James
>
> On Friday, April 17, 2015, Cody Marcel <cm...@salesforce.com> wrote:
>
> > I'll take a look at my Intellij settings. I did import the prefs from
> > eclipse, but the import is not perfect so maybe some were left out.
> >
> > On Fri, Apr 17, 2015 at 12:49 PM, James Taylor <jamestaylor@apache.org
> > <javascript:;>>
> > wrote:
> >
> > > We document our compiler settings and provide a set of Eclipse
> > > preferences that can be loaded into your IDE in
> > > dev/eclipse_prefs_phoenix.epf. With the current code in master, I'm
> > > getting the compilation errors below.
> > >
> > > Would the folks responsible for those areas please fix them and adjust
> > > their IDE settings so that they don't creep back in?
> > >
> > > Thanks,
> > > James
> > >
> > > Description Resource Path Location Type
> > > The method writeXML() from the type ConfigurationParserTest is never
> > > used locally ConfigurationParserTest.java
> > > /pherf/src/test/java/org/apache/phoenix/pherf line 141 Java Problem
> > > The value of the field DataLoader.properties is not used
> > > DataLoader.java /pherf/src/main/java/org/apache/phoenix/pherf/loaddata
> > > line 61 Java Problem
> > > The value of the field DataLoaderTest.loader is not used
> > > DataLoaderTest.java /pherf/src/test/java/org/apache/phoenix/pherf line
> > > 34 Java Problem
> > > The value of the field DataLoaderTest.model is not used
> > > DataLoaderTest.java /pherf/src/test/java/org/apache/phoenix/pherf line
> > > 33 Java Problem
> > > The value of the field QueryExecutor.resultUtil is not used
> > > QueryExecutor.java
> > > /pherf/src/main/java/org/apache/phoenix/pherf/workload line 47 Java
> > > Problem
> > > The value of the field QueryServerThread.LOG is not used
> > > QueryServerThread.java
> > > /phoenix-server/src/it/java/org/apache/phoenix/end2end line 30 Java
> > > Problem
> > > The value of the field Result.type is not used Result.java
> > > /pherf/src/main/java/org/apache/phoenix/pherf/result line 30 Java
> > > Problem
> > > Type String[] of the last argument to method printRecord(Object...)
> > > doesn't exactly match the vararg parameter type. Cast to Object[] to
> > > confirm the non-varargs invocation, or pass individual arguments of
> > > type Object for a varargs invocation. CSVResultHandler.java
> > > /pherf/src/main/java/org/apache/phoenix/pherf/result/impl line 126
> > > Java Problem
> > >
> >
>
Re: please fix IDE compiler errors for pherf and phoenix-server
Posted by James Taylor <ja...@apache.org>.
Cody,
For everyone using the default Eclipse setting, the project won't build in
the IDE right now. The fix you need to make is to modify the Pherf code so
that it compiles. These are very simple changes such as removing local
variables that aren't used. Would appreciate if you could do this so that
all other contributors do not have to take action to work around this.
James
On Friday, April 17, 2015, Cody Marcel <cm...@salesforce.com> wrote:
> I'll take a look at my Intellij settings. I did import the prefs from
> eclipse, but the import is not perfect so maybe some were left out.
>
> On Fri, Apr 17, 2015 at 12:49 PM, James Taylor <jamestaylor@apache.org
> <javascript:;>>
> wrote:
>
> > We document our compiler settings and provide a set of Eclipse
> > preferences that can be loaded into your IDE in
> > dev/eclipse_prefs_phoenix.epf. With the current code in master, I'm
> > getting the compilation errors below.
> >
> > Would the folks responsible for those areas please fix them and adjust
> > their IDE settings so that they don't creep back in?
> >
> > Thanks,
> > James
> >
> > Description Resource Path Location Type
> > The method writeXML() from the type ConfigurationParserTest is never
> > used locally ConfigurationParserTest.java
> > /pherf/src/test/java/org/apache/phoenix/pherf line 141 Java Problem
> > The value of the field DataLoader.properties is not used
> > DataLoader.java /pherf/src/main/java/org/apache/phoenix/pherf/loaddata
> > line 61 Java Problem
> > The value of the field DataLoaderTest.loader is not used
> > DataLoaderTest.java /pherf/src/test/java/org/apache/phoenix/pherf line
> > 34 Java Problem
> > The value of the field DataLoaderTest.model is not used
> > DataLoaderTest.java /pherf/src/test/java/org/apache/phoenix/pherf line
> > 33 Java Problem
> > The value of the field QueryExecutor.resultUtil is not used
> > QueryExecutor.java
> > /pherf/src/main/java/org/apache/phoenix/pherf/workload line 47 Java
> > Problem
> > The value of the field QueryServerThread.LOG is not used
> > QueryServerThread.java
> > /phoenix-server/src/it/java/org/apache/phoenix/end2end line 30 Java
> > Problem
> > The value of the field Result.type is not used Result.java
> > /pherf/src/main/java/org/apache/phoenix/pherf/result line 30 Java
> > Problem
> > Type String[] of the last argument to method printRecord(Object...)
> > doesn't exactly match the vararg parameter type. Cast to Object[] to
> > confirm the non-varargs invocation, or pass individual arguments of
> > type Object for a varargs invocation. CSVResultHandler.java
> > /pherf/src/main/java/org/apache/phoenix/pherf/result/impl line 126
> > Java Problem
> >
>
Re: please fix IDE compiler errors for pherf and phoenix-server
Posted by Cody Marcel <cm...@salesforce.com>.
I'll take a look at my Intellij settings. I did import the prefs from
eclipse, but the import is not perfect so maybe some were left out.
On Fri, Apr 17, 2015 at 12:49 PM, James Taylor <ja...@apache.org>
wrote:
> We document our compiler settings and provide a set of Eclipse
> preferences that can be loaded into your IDE in
> dev/eclipse_prefs_phoenix.epf. With the current code in master, I'm
> getting the compilation errors below.
>
> Would the folks responsible for those areas please fix them and adjust
> their IDE settings so that they don't creep back in?
>
> Thanks,
> James
>
> Description Resource Path Location Type
> The method writeXML() from the type ConfigurationParserTest is never
> used locally ConfigurationParserTest.java
> /pherf/src/test/java/org/apache/phoenix/pherf line 141 Java Problem
> The value of the field DataLoader.properties is not used
> DataLoader.java /pherf/src/main/java/org/apache/phoenix/pherf/loaddata
> line 61 Java Problem
> The value of the field DataLoaderTest.loader is not used
> DataLoaderTest.java /pherf/src/test/java/org/apache/phoenix/pherf line
> 34 Java Problem
> The value of the field DataLoaderTest.model is not used
> DataLoaderTest.java /pherf/src/test/java/org/apache/phoenix/pherf line
> 33 Java Problem
> The value of the field QueryExecutor.resultUtil is not used
> QueryExecutor.java
> /pherf/src/main/java/org/apache/phoenix/pherf/workload line 47 Java
> Problem
> The value of the field QueryServerThread.LOG is not used
> QueryServerThread.java
> /phoenix-server/src/it/java/org/apache/phoenix/end2end line 30 Java
> Problem
> The value of the field Result.type is not used Result.java
> /pherf/src/main/java/org/apache/phoenix/pherf/result line 30 Java
> Problem
> Type String[] of the last argument to method printRecord(Object...)
> doesn't exactly match the vararg parameter type. Cast to Object[] to
> confirm the non-varargs invocation, or pass individual arguments of
> type Object for a varargs invocation. CSVResultHandler.java
> /pherf/src/main/java/org/apache/phoenix/pherf/result/impl line 126
> Java Problem
>