You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "David Blevins (JIRA)" <ji...@apache.org> on 2007/01/04 08:32:28 UTC
[jira] Created: (OPENEJB-434) Remove dependency on Sun Classes in
JarUtils
Remove dependency on Sun Classes in JarUtils
--------------------------------------------
Key: OPENEJB-434
URL: https://issues.apache.org/jira/browse/OPENEJB-434
Project: OpenEJB
Issue Type: Task
Affects Versions: 2.2, 3.0
Reporter: David Blevins
Remove dependency on Sun Classes.
JarUtils uses suntools.jar.Main to add an entry to an existing jar. This could be replaced by creating a new temp jar with JarOutputStream copying all the data from the existing jar and adding the one new entry. Then you swap the two files.
BasicURLClassPath, SystemClassPath and TomcatClassPath directly reference sun.misc.URLClassPath. This reference is obtained using reflection and set accessible, so with a bit more reflection we should be able to remove the reference.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OPENEJB-434) Remove dependency on Sun Classes in
JarUtils
Posted by "karan singh malhi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462762 ]
karan singh malhi commented on OPENEJB-434:
-------------------------------------------
Added a patch .
> Remove dependency on Sun Classes in JarUtils
> --------------------------------------------
>
> Key: OPENEJB-434
> URL: https://issues.apache.org/jira/browse/OPENEJB-434
> Project: OpenEJB
> Issue Type: Task
> Affects Versions: 2.2, 3.0
> Reporter: David Blevins
> Attachments: JarUtils.patch
>
>
> Remove dependency on Sun Classes.
> JarUtils uses suntools.jar.Main to add an entry to an existing jar. This could be replaced by creating a new temp jar with JarOutputStream copying all the data from the existing jar and adding the one new entry. Then you swap the two files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (OPENEJB-434) Remove dependency on Sun Classes in
JarUtils
Posted by "karan singh malhi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
karan singh malhi reopened OPENEJB-434:
---------------------------------------
The patch had bugs in it. Attaching a new patch
> Remove dependency on Sun Classes in JarUtils
> --------------------------------------------
>
> Key: OPENEJB-434
> URL: https://issues.apache.org/jira/browse/OPENEJB-434
> Project: OpenEJB
> Issue Type: Task
> Affects Versions: 2.2, 3.0
> Reporter: David Blevins
> Assigned To: karan singh malhi
> Fix For: 3.0
>
> Attachments: JarUtils.patch, JarUtils.patch, Messages.properties.patch
>
>
> Remove dependency on Sun Classes.
> JarUtils uses suntools.jar.Main to add an entry to an existing jar. This could be replaced by creating a new temp jar with JarOutputStream copying all the data from the existing jar and adding the one new entry. Then you swap the two files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OPENEJB-434) Remove dependency on Sun Classes in
JarUtils
Posted by "Jacek Laskowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466019 ]
Jacek Laskowski commented on OPENEJB-434:
-----------------------------------------
Is it a patch for the latest JarUtils & Co? I've just updated the sources and couldn't apply your patch. I then tried to apply it by hand, but the massive differences between what's in the patch and the files that I was afraid of making mistakes doing it this way.
Please create a patch while in openejb3 directory. Please don't reformat the code as the patch doesn't contain the changes it is made for, but also formatting changes that make the final outcome almost unreadable.
$ svn up
At revision 497772.
> Remove dependency on Sun Classes in JarUtils
> --------------------------------------------
>
> Key: OPENEJB-434
> URL: https://issues.apache.org/jira/browse/OPENEJB-434
> Project: OpenEJB
> Issue Type: Task
> Affects Versions: 2.2, 3.0
> Reporter: David Blevins
> Assigned To: Jacek Laskowski
> Fix For: 3.0
>
> Attachments: JarUtils.patch, JarUtils.patch, JarUtils.patch_final, Messages.properties.patch
>
>
> Remove dependency on Sun Classes.
> JarUtils uses suntools.jar.Main to add an entry to an existing jar. This could be replaced by creating a new temp jar with JarOutputStream copying all the data from the existing jar and adding the one new entry. Then you swap the two files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENEJB-434) Remove dependency on Sun Classes in
JarUtils
Posted by "karan singh malhi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
karan singh malhi updated OPENEJB-434:
--------------------------------------
Attachment: JarUtils.patch
> Remove dependency on Sun Classes in JarUtils
> --------------------------------------------
>
> Key: OPENEJB-434
> URL: https://issues.apache.org/jira/browse/OPENEJB-434
> Project: OpenEJB
> Issue Type: Task
> Affects Versions: 2.2, 3.0
> Reporter: David Blevins
> Attachments: JarUtils.patch
>
>
> Remove dependency on Sun Classes.
> JarUtils uses suntools.jar.Main to add an entry to an existing jar. This could be replaced by creating a new temp jar with JarOutputStream copying all the data from the existing jar and adding the one new entry. Then you swap the two files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (OPENEJB-434) Remove dependency on Sun Classes in
JarUtils
Posted by "David Blevins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Blevins closed OPENEJB-434.
---------------------------------
Assignee: karan singh malhi
> Remove dependency on Sun Classes in JarUtils
> --------------------------------------------
>
> Key: OPENEJB-434
> URL: https://issues.apache.org/jira/browse/OPENEJB-434
> Project: OpenEJB
> Issue Type: Task
> Affects Versions: 2.2, 3.0
> Reporter: David Blevins
> Assigned To: karan singh malhi
> Fix For: 3.0
>
> Attachments: JarUtils.patch
>
>
> Remove dependency on Sun Classes.
> JarUtils uses suntools.jar.Main to add an entry to an existing jar. This could be replaced by creating a new temp jar with JarOutputStream copying all the data from the existing jar and adding the one new entry. Then you swap the two files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENEJB-434) Remove dependency on Sun Classes in
JarUtils
Posted by "David Blevins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Blevins updated OPENEJB-434:
----------------------------------
Description:
Remove dependency on Sun Classes.
JarUtils uses suntools.jar.Main to add an entry to an existing jar. This could be replaced by creating a new temp jar with JarOutputStream copying all the data from the existing jar and adding the one new entry. Then you swap the two files.
was:
Remove dependency on Sun Classes.
JarUtils uses suntools.jar.Main to add an entry to an existing jar. This could be replaced by creating a new temp jar with JarOutputStream copying all the data from the existing jar and adding the one new entry. Then you swap the two files.
BasicURLClassPath, SystemClassPath and TomcatClassPath directly reference sun.misc.URLClassPath. This reference is obtained using reflection and set accessible, so with a bit more reflection we should be able to remove the reference.
> Remove dependency on Sun Classes in JarUtils
> --------------------------------------------
>
> Key: OPENEJB-434
> URL: https://issues.apache.org/jira/browse/OPENEJB-434
> Project: OpenEJB
> Issue Type: Task
> Affects Versions: 2.2, 3.0
> Reporter: David Blevins
>
> Remove dependency on Sun Classes.
> JarUtils uses suntools.jar.Main to add an entry to an existing jar. This could be replaced by creating a new temp jar with JarOutputStream copying all the data from the existing jar and adding the one new entry. Then you swap the two files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENEJB-434) Remove dependency on Sun Classes in
JarUtils
Posted by "karan singh malhi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
karan singh malhi updated OPENEJB-434:
--------------------------------------
Attachment: JarUtils.patch_final
> Remove dependency on Sun Classes in JarUtils
> --------------------------------------------
>
> Key: OPENEJB-434
> URL: https://issues.apache.org/jira/browse/OPENEJB-434
> Project: OpenEJB
> Issue Type: Task
> Affects Versions: 2.2, 3.0
> Reporter: David Blevins
> Assigned To: karan singh malhi
> Fix For: 3.0
>
> Attachments: JarUtils.patch, JarUtils.patch, JarUtils.patch_final, Messages.properties.patch
>
>
> Remove dependency on Sun Classes.
> JarUtils uses suntools.jar.Main to add an entry to an existing jar. This could be replaced by creating a new temp jar with JarOutputStream copying all the data from the existing jar and adding the one new entry. Then you swap the two files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENEJB-434) Remove dependency on Sun Classes in
JarUtils
Posted by "karan singh malhi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
karan singh malhi updated OPENEJB-434:
--------------------------------------
Attachment: JarUtils.patch
> Remove dependency on Sun Classes in JarUtils
> --------------------------------------------
>
> Key: OPENEJB-434
> URL: https://issues.apache.org/jira/browse/OPENEJB-434
> Project: OpenEJB
> Issue Type: Task
> Affects Versions: 2.2, 3.0
> Reporter: David Blevins
> Assigned To: karan singh malhi
> Fix For: 3.0
>
> Attachments: JarUtils.patch, JarUtils.patch, Messages.properties.patch
>
>
> Remove dependency on Sun Classes.
> JarUtils uses suntools.jar.Main to add an entry to an existing jar. This could be replaced by creating a new temp jar with JarOutputStream copying all the data from the existing jar and adding the one new entry. Then you swap the two files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OPENEJB-434) Remove dependency on Sun Classes in
JarUtils
Posted by "karan singh malhi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466577 ]
karan singh malhi commented on OPENEJB-434:
-------------------------------------------
I did svn update this time to rev 48819. File name is JarUtils.patch
> Remove dependency on Sun Classes in JarUtils
> --------------------------------------------
>
> Key: OPENEJB-434
> URL: https://issues.apache.org/jira/browse/OPENEJB-434
> Project: OpenEJB
> Issue Type: Task
> Affects Versions: 2.2, 3.0
> Reporter: David Blevins
> Assigned To: karan singh malhi
> Fix For: 3.0
>
> Attachments: JarUtils.patch, JarUtils.patch, JarUtils.patch, JarUtils.patch_final, Messages.properties.patch
>
>
> Remove dependency on Sun Classes.
> JarUtils uses suntools.jar.Main to add an entry to an existing jar. This could be replaced by creating a new temp jar with JarOutputStream copying all the data from the existing jar and adding the one new entry. Then you swap the two files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (OPENEJB-434) Remove dependency on Sun Classes in
JarUtils
Posted by "Jacek Laskowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacek Laskowski reassigned OPENEJB-434:
---------------------------------------
Assignee: Jacek Laskowski (was: karan singh malhi)
> Remove dependency on Sun Classes in JarUtils
> --------------------------------------------
>
> Key: OPENEJB-434
> URL: https://issues.apache.org/jira/browse/OPENEJB-434
> Project: OpenEJB
> Issue Type: Task
> Affects Versions: 2.2, 3.0
> Reporter: David Blevins
> Assigned To: Jacek Laskowski
> Fix For: 3.0
>
> Attachments: JarUtils.patch, JarUtils.patch, JarUtils.patch_final, Messages.properties.patch
>
>
> Remove dependency on Sun Classes.
> JarUtils uses suntools.jar.Main to add an entry to an existing jar. This could be replaced by creating a new temp jar with JarOutputStream copying all the data from the existing jar and adding the one new entry. Then you swap the two files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (OPENEJB-434) Remove dependency on Sun Classes in
JarUtils
Posted by "Jacek Laskowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacek Laskowski reassigned OPENEJB-434:
---------------------------------------
Assignee: karan singh malhi (was: Jacek Laskowski)
Please create the patch again with the latest sources (at least rev 497772)
> Remove dependency on Sun Classes in JarUtils
> --------------------------------------------
>
> Key: OPENEJB-434
> URL: https://issues.apache.org/jira/browse/OPENEJB-434
> Project: OpenEJB
> Issue Type: Task
> Affects Versions: 2.2, 3.0
> Reporter: David Blevins
> Assigned To: karan singh malhi
> Fix For: 3.0
>
> Attachments: JarUtils.patch, JarUtils.patch, JarUtils.patch_final, Messages.properties.patch
>
>
> Remove dependency on Sun Classes.
> JarUtils uses suntools.jar.Main to add an entry to an existing jar. This could be replaced by creating a new temp jar with JarOutputStream copying all the data from the existing jar and adding the one new entry. Then you swap the two files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENEJB-434) Remove dependency on Sun Classes in
JarUtils
Posted by "karan singh malhi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
karan singh malhi updated OPENEJB-434:
--------------------------------------
Attachment: JarUtils.patch
> Remove dependency on Sun Classes in JarUtils
> --------------------------------------------
>
> Key: OPENEJB-434
> URL: https://issues.apache.org/jira/browse/OPENEJB-434
> Project: OpenEJB
> Issue Type: Task
> Affects Versions: 2.2, 3.0
> Reporter: David Blevins
> Assigned To: karan singh malhi
> Fix For: 3.0
>
> Attachments: JarUtils.patch, JarUtils.patch, JarUtils.patch, JarUtils.patch_final, Messages.properties.patch
>
>
> Remove dependency on Sun Classes.
> JarUtils uses suntools.jar.Main to add an entry to an existing jar. This could be replaced by creating a new temp jar with JarOutputStream copying all the data from the existing jar and adding the one new entry. Then you swap the two files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (OPENEJB-434) Remove dependency on Sun Classes in
JarUtils
Posted by "Jacek Laskowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacek Laskowski resolved OPENEJB-434.
-------------------------------------
Resolution: Fixed
Fix Version/s: 3.0
Sending container/openejb-core/src/main/java/org/apache/openejb/util/JarUtils.java
Transmitting file data .
Committed revision 493837.
Thanks Karan Malhi!
> Remove dependency on Sun Classes in JarUtils
> --------------------------------------------
>
> Key: OPENEJB-434
> URL: https://issues.apache.org/jira/browse/OPENEJB-434
> Project: OpenEJB
> Issue Type: Task
> Affects Versions: 2.2, 3.0
> Reporter: David Blevins
> Fix For: 3.0
>
> Attachments: JarUtils.patch
>
>
> Remove dependency on Sun Classes.
> JarUtils uses suntools.jar.Main to add an entry to an existing jar. This could be replaced by creating a new temp jar with JarOutputStream copying all the data from the existing jar and adding the one new entry. Then you swap the two files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OPENEJB-434) Remove dependency on Sun Classes in
JarUtils
Posted by "karan singh malhi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466892 ]
karan singh malhi commented on OPENEJB-434:
-------------------------------------------
Jacek,
I updated my code to revision 498819 and attached the patch to the JIRA
issue OPENEJB-434
--
Karan Malhi
> Remove dependency on Sun Classes in JarUtils
> --------------------------------------------
>
> Key: OPENEJB-434
> URL: https://issues.apache.org/jira/browse/OPENEJB-434
> Project: OpenEJB
> Issue Type: Task
> Affects Versions: 2.2, 3.0
> Reporter: David Blevins
> Assigned To: karan singh malhi
> Fix For: 3.0
>
> Attachments: JarUtils.patch, JarUtils.patch, JarUtils.patch, JarUtils.patch_final, Messages.properties.patch
>
>
> Remove dependency on Sun Classes.
> JarUtils uses suntools.jar.Main to add an entry to an existing jar. This could be replaced by creating a new temp jar with JarOutputStream copying all the data from the existing jar and adding the one new entry. Then you swap the two files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENEJB-434) Remove dependency on Sun Classes in
JarUtils
Posted by "karan singh malhi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465642 ]
karan singh malhi commented on OPENEJB-434:
-------------------------------------------
The previous patches should be discarded. Please use the file, JarUtils.patch_Final to add the patch.
> Remove dependency on Sun Classes in JarUtils
> --------------------------------------------
>
> Key: OPENEJB-434
> URL: https://issues.apache.org/jira/browse/OPENEJB-434
> Project: OpenEJB
> Issue Type: Task
> Affects Versions: 2.2, 3.0
> Reporter: David Blevins
> Assigned To: karan singh malhi
> Fix For: 3.0
>
> Attachments: JarUtils.patch, JarUtils.patch, JarUtils.patch_final, Messages.properties.patch
>
>
> Remove dependency on Sun Classes.
> JarUtils uses suntools.jar.Main to add an entry to an existing jar. This could be replaced by creating a new temp jar with JarOutputStream copying all the data from the existing jar and adding the one new entry. Then you swap the two files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENEJB-434) Remove dependency on Sun Classes in
JarUtils
Posted by "karan singh malhi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENEJB-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
karan singh malhi updated OPENEJB-434:
--------------------------------------
Attachment: Messages.properties.patch
> Remove dependency on Sun Classes in JarUtils
> --------------------------------------------
>
> Key: OPENEJB-434
> URL: https://issues.apache.org/jira/browse/OPENEJB-434
> Project: OpenEJB
> Issue Type: Task
> Affects Versions: 2.2, 3.0
> Reporter: David Blevins
> Assigned To: karan singh malhi
> Fix For: 3.0
>
> Attachments: JarUtils.patch, JarUtils.patch, Messages.properties.patch
>
>
> Remove dependency on Sun Classes.
> JarUtils uses suntools.jar.Main to add an entry to an existing jar. This could be replaced by creating a new temp jar with JarOutputStream copying all the data from the existing jar and adding the one new entry. Then you swap the two files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira