[GitHub] spark pull request #14733: [SPARK-17170] [SQL] InMemoryTableScanExec driver-...

[JoshRosen <gi...@git.apache.org>]

Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14733#discussion_r77257778
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala ---
    @@ -142,13 +171,16 @@ case class InMemoryTableScanExec(
           val cachedBatchesToScan =
             if (inMemoryPartitionPruningEnabled) {
               cachedBatchIterator.filter { cachedBatch =>
    +            val partitionFilter = newPredicate(
    --- End diff --
    
    Why did you choose to nest this more deeply inside of the `filter` rather than leaving it where it was in `mapPartitionsInternal`? By moving it here, we'll wind up calling `newPredicate` once per batch rather than once per partition, thereby harming performance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org