You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/11/23 01:46:53 UTC
[GitHub] [helix] xyuanlu opened a new pull request #1912: Refactor instanceService to clusterMaintenanceService
xyuanlu opened a new pull request #1912:
URL: https://github.com/apache/helix/pull/1912
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
#1896
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
This PR refactors instanceService to clusterMaintenanceService. Avoid duplicate code when adding new features to clusterMaintenanceService.
### Tests
- [X] The following tests are written for this issue:
Rename TestInstanceService to TestMaintenanceManagementService.java
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on pull request #1912: Refactor instanceService to clusterMaintenanceService
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on pull request #1912:
URL: https://github.com/apache/helix/pull/1912#issuecomment-978499674
Thanks for the review!
This PR is ready to me merged. Approved by @junkaixue
Commit message:
Refactor instanceService to clusterMaintenanceService
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue merged pull request #1912: Refactor instanceService to clusterMaintenanceService
Posted by GitBox <gi...@apache.org>.
junkaixue merged pull request #1912:
URL: https://github.com/apache/helix/pull/1912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue commented on pull request #1912: Refactor instanceService to clusterMaintenanceService
Posted by GitBox <gi...@apache.org>.
junkaixue commented on pull request #1912:
URL: https://github.com/apache/helix/pull/1912#issuecomment-977180400
Overall, lgtm. Please attach the test result of helix-rest module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on pull request #1912: Refactor instanceService to clusterMaintenanceService
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on pull request #1912:
URL: https://github.com/apache/helix/pull/1912#issuecomment-977285966
> Overall, lgtm. Please attach the test result of helix-rest module.
TFTR. Updated with a helix-rest test module result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org