You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/05 10:42:38 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #31041: [SPARK-34010][SQL][DODCS] Use python3 instead of python in SQL documentation build
HyukjinKwon opened a new pull request #31041:
URL: https://github.com/apache/spark/pull/31041
### What changes were proposed in this pull request?
This PR proposes to use python3 instead of python in SQL documentation build.
After SPARK-29672, we use `sql/create-docs.sh` everywhere in Spark dev. We should fix it in `sql/create-docs.sh` too.
This blocks release because the release container does not have `python` but only `python3`.
### Why are the changes needed?
To unblock the release.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
I manually ran the script
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31041: [SPARK-34010][SQL][DODCS] Use python3 instead of python in SQL documentation build
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31041:
URL: https://github.com/apache/spark/pull/31041#issuecomment-754559798
Merged to master, branch-3.1 and branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31041: [SPARK-34010][SQL][DOCS] Use python3 instead of python in SQL documentation build
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31041:
URL: https://github.com/apache/spark/pull/31041#issuecomment-754583854
late lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31041: [SPARK-34010][SQL][DODCS] Use python3 instead of python in SQL documentation build
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31041:
URL: https://github.com/apache/spark/pull/31041#issuecomment-754557246
cc @maropu, @viirya, @cloud-fan, @dongjoon-hyun, do you mind taking a quick look please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31041: [SPARK-34010][SQL][DODCS] Use python3 instead of python in SQL documentation build
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31041:
URL: https://github.com/apache/spark/pull/31041#issuecomment-754559620
I manually tested in my local and it works. I will merge this in for now to run the RC.
I will monitor the builds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31041: [SPARK-34010][SQL][DOCS] Use python3 instead of python in SQL documentation build
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31041:
URL: https://github.com/apache/spark/pull/31041#issuecomment-754840565
+1, late LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #31041: [SPARK-34010][SQL][DODCS] Use python3 instead of python in SQL documentation build
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31041:
URL: https://github.com/apache/spark/pull/31041
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org