You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/05/19 10:03:39 UTC

[GitHub] [airflow] potiuk edited a comment on issue #5302: [WIP][AIRFLOW-4374] Make enum-like-classes inherit from enum

potiuk edited a comment on issue #5302: [WIP][AIRFLOW-4374] Make enum-like-classes inherit from enum
URL: https://github.com/apache/airflow/pull/5302#issuecomment-493743476
 
 
   Yeah. I think that could be much more friendly. Maybe I'd rather check for the type of the value, and add Type annotation Union[TriggerRule, string] to indicate that we support both for now. 
   
   On the other hand, the question is when such deprecation warning should turn into error - if not now with 2.0.0. So I am a bit on the fence here (though leaning towards backwards-compatibility).
   
   Maybe others can also chime-in here with their thoughts and experience how painful it will be for the users to convert  ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services