You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/27 11:17:56 UTC
[GitHub] [shardingsphere] Qianyi951015 opened a new pull request, #23124: Add `IF NOT EXISTS` to `create encrypt rule`
Qianyi951015 opened a new pull request, #23124:
URL: https://github.com/apache/shardingsphere/pull/23124
The sixth task of #22844.
Changes proposed in this pull request:
- Add `IF NOT EXISTS` to `create encrypt rule`
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #23124: Add `IF NOT EXISTS` to `create encrypt rule`
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #23124:
URL: https://github.com/apache/shardingsphere/pull/23124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23124: Add `IF NOT EXISTS` to `create encrypt rule`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23124:
URL: https://github.com/apache/shardingsphere/pull/23124#issuecomment-1365845310
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23124?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23124](https://codecov.io/gh/apache/shardingsphere/pull/23124?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f8c1d4) into [master](https://codecov.io/gh/apache/shardingsphere/commit/28e8fbaa5402d3034f12089ef13e7e9fa295ae8d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (28e8fba) will **increase** coverage by `0.02%`.
> The diff coverage is `80.00%`.
```diff
@@ Coverage Diff @@
## master #23124 +/- ##
============================================
+ Coverage 49.82% 49.84% +0.02%
Complexity 2439 2439
============================================
Files 4111 4111
Lines 57540 57558 +18
Branches 9088 9093 +5
============================================
+ Hits 28668 28689 +21
+ Misses 26352 26345 -7
- Partials 2520 2524 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ql/parser/core/EncryptDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/23124/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9kaXN0c3FsL3BhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9kaXN0c3FsL3BhcnNlci9jb3JlL0VuY3J5cHREaXN0U1FMU3RhdGVtZW50VmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...dler/update/CreateEncryptRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/23124/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9kaXN0c3FsL2hhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9DcmVhdGVFbmNyeXB0UnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `79.16% <84.21%> (+22.49%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org