You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/12/04 23:49:15 UTC

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6321: Enhance JSONRecordReader to handle GZIP compressed JSON files.

fx19880617 commented on a change in pull request #6321:
URL: https://github.com/apache/incubator-pinot/pull/6321#discussion_r536449231



##########
File path: pinot-plugins/pinot-input-format/pinot-json/src/main/java/org/apache/pinot/plugin/inputformat/json/JSONRecordReader.java
##########
@@ -86,12 +91,14 @@ public GenericRow next(GenericRow reuse) {
   public void rewind()
       throws IOException {
     _iterator.close();
+    _inputStream.close();

Review comment:
       do you need to rewind the stream?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org