You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Dave Watson (Created) (JIRA)" <ji...@apache.org> on 2011/12/02 00:48:40 UTC
[jira] [Created] (THRIFT-1445) minor C++ generator variable cleanup
minor C++ generator variable cleanup
-------------------------------------
Key: THRIFT-1445
URL: https://issues.apache.org/jira/browse/THRIFT-1445
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Reporter: Dave Watson
Priority: Minor
Attachments: 0004-thrift-minor-C-generator-variable-cleanup.patch
>From 5d5a0a42e5a20c9fc72d686c880614f6568a992e Mon Sep 17 00:00:00 2001
From: Adam Simpkins <si...@fb.com>
Date: Mon, 14 Jun 2010 19:52:15 +0000
Subject: [PATCH 04/56] minor C++ generator variable cleanup
Summary:
In generate_process_function(), service_func_name is always used as a
string literal. Therefore, construct it with the double quotes
built-in, rather than having to add them everywhere we use it.
Test Plan:
Built [two internal fb projects]
DiffCamp Revision: 122187
Reviewed By: dreiss
CC: dreiss, kholst, thrift-team@lists
Revert Plan:
OK
git-svn-id: svn+ssh://tubbs/svnapps/fbomb/trunk/[internal fb thing]@29905 2248de34-8caa-4a3c-bc55-5e52d9d7b73a
---
compiler/cpp/src/generate/t_cpp_generator.cc | 90 +++++++++++++-------------
1 files changed, 45 insertions(+), 45 deletions(-)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1445) minor C++ generator variable cleanup
Posted by "Jake Farrell (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jake Farrell closed THRIFT-1445.
--------------------------------
Resolution: Fixed
Fix Version/s: 0.8
Assignee: Dave Watson
Committed
> minor C++ generator variable cleanup
> -------------------------------------
>
> Key: THRIFT-1445
> URL: https://issues.apache.org/jira/browse/THRIFT-1445
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Dave Watson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 0004-thrift-minor-C-generator-variable-cleanup.patch
>
>
> From 5d5a0a42e5a20c9fc72d686c880614f6568a992e Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Mon, 14 Jun 2010 19:52:15 +0000
> Subject: [PATCH 04/56] minor C++ generator variable cleanup
> Summary:
> In generate_process_function(), service_func_name is always used as a
> string literal. Therefore, construct it with the double quotes
> built-in, rather than having to add them everywhere we use it.
> Test Plan:
> Built [two internal fb projects]
> DiffCamp Revision: 122187
> Reviewed By: dreiss
> CC: dreiss, kholst, thrift-team@lists
> Revert Plan:
> OK
> git-svn-id: svn+ssh://tubbs/svnapps/fbomb/trunk/[internal fb thing]@29905 2248de34-8caa-4a3c-bc55-5e52d9d7b73a
> ---
> compiler/cpp/src/generate/t_cpp_generator.cc | 90 +++++++++++++-------------
> 1 files changed, 45 insertions(+), 45 deletions(-)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1445) minor C++ generator variable
cleanup
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163311#comment-13163311 ]
Hudson commented on THRIFT-1445:
--------------------------------
Integrated in Thrift #349 (See [https://builds.apache.org/job/Thrift/349/])
Thrift-1445:minor C++ generator variable cleanup
Client: cpp
Patch: Dave Watson
In generate_process_function(), service_func_name is always used as a
string literal. Therefore, construct it with the double quotes
built-in, rather than having to add them everywhere we use it.
> minor C++ generator variable cleanup
> -------------------------------------
>
> Key: THRIFT-1445
> URL: https://issues.apache.org/jira/browse/THRIFT-1445
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Assignee: Dave Watson
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 0004-thrift-minor-C-generator-variable-cleanup.patch
>
>
> From 5d5a0a42e5a20c9fc72d686c880614f6568a992e Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Mon, 14 Jun 2010 19:52:15 +0000
> Subject: [PATCH 04/56] minor C++ generator variable cleanup
> Summary:
> In generate_process_function(), service_func_name is always used as a
> string literal. Therefore, construct it with the double quotes
> built-in, rather than having to add them everywhere we use it.
> Test Plan:
> Built [two internal fb projects]
> DiffCamp Revision: 122187
> Reviewed By: dreiss
> CC: dreiss, kholst, thrift-team@lists
> Revert Plan:
> OK
> git-svn-id: svn+ssh://tubbs/svnapps/fbomb/trunk/[internal fb thing]@29905 2248de34-8caa-4a3c-bc55-5e52d9d7b73a
> ---
> compiler/cpp/src/generate/t_cpp_generator.cc | 90 +++++++++++++-------------
> 1 files changed, 45 insertions(+), 45 deletions(-)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1445) minor C++ generator variable cleanup
Posted by "Dave Watson (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Watson updated THRIFT-1445:
--------------------------------
Attachment: 0004-thrift-minor-C-generator-variable-cleanup.patch
> minor C++ generator variable cleanup
> -------------------------------------
>
> Key: THRIFT-1445
> URL: https://issues.apache.org/jira/browse/THRIFT-1445
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Dave Watson
> Priority: Minor
> Attachments: 0004-thrift-minor-C-generator-variable-cleanup.patch
>
>
> From 5d5a0a42e5a20c9fc72d686c880614f6568a992e Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Mon, 14 Jun 2010 19:52:15 +0000
> Subject: [PATCH 04/56] minor C++ generator variable cleanup
> Summary:
> In generate_process_function(), service_func_name is always used as a
> string literal. Therefore, construct it with the double quotes
> built-in, rather than having to add them everywhere we use it.
> Test Plan:
> Built [two internal fb projects]
> DiffCamp Revision: 122187
> Reviewed By: dreiss
> CC: dreiss, kholst, thrift-team@lists
> Revert Plan:
> OK
> git-svn-id: svn+ssh://tubbs/svnapps/fbomb/trunk/[internal fb thing]@29905 2248de34-8caa-4a3c-bc55-5e52d9d7b73a
> ---
> compiler/cpp/src/generate/t_cpp_generator.cc | 90 +++++++++++++-------------
> 1 files changed, 45 insertions(+), 45 deletions(-)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira