You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/21 10:49:35 UTC

[GitHub] [airflow] turbaszek opened a new issue #11047: Create NoGCPServiceAccountKeyInConfigRule to ease upgrade to Airflow 2.0

turbaszek opened a new issue #11047:
URL: https://github.com/apache/airflow/issues/11047


   
   This issue is part of #8765
   
   ## Rule
   Create `NoGCPServiceAccountKeyInConfigRule` which corresponds to
   > Remove gcp_service_account_keys option in airflow.cfg file
   
   entry in UPDATING.md. This rule should allow users to check if their current configuration needs any adjusting
   before migration to Airflow 2.0.
   
   ## How to guide
   To implement a new rule, create a class that inherits from `airflow.upgrade.rules.base_rule.BaseRule`.
   It will be auto-registered and used by `airflow upgrade-check` command. The custom rule class has to have `title`,
   `description` properties and should implement `check` method which returns a list of error messages in case of
   incompatibility.
   
   For example:
   https://github.com/apache/airflow/blob/ea36166961ca35fc51ddc262ec245590c3e236fb/airflow/upgrade/rules/conn_type_is_not_nullable.py#L25-L42
   
   **Remember** to open the PR against `v1-10-test` branch.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek commented on issue #11047: Create NoGCPServiceAccountKeyInConfigRule to ease upgrade to Airflow 2.0

Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #11047:
URL: https://github.com/apache/airflow/issues/11047#issuecomment-706760017


   Closed via #11230


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] pcandoalmeida commented on issue #11047: Create NoGCPServiceAccountKeyInConfigRule to ease upgrade to Airflow 2.0

Posted by GitBox <gi...@apache.org>.
pcandoalmeida commented on issue #11047:
URL: https://github.com/apache/airflow/issues/11047#issuecomment-697000660


   Hello 👋🏼 would I be able to work on this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek commented on issue #11047: Create NoGCPServiceAccountKeyInConfigRule to ease upgrade to Airflow 2.0

Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #11047:
URL: https://github.com/apache/airflow/issues/11047#issuecomment-697020430


   @pcandoalmeida you are assigned 🎸 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek commented on issue #11047: Create NoGCPServiceAccountKeyInConfigRule to ease upgrade to Airflow 2.0

Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #11047:
URL: https://github.com/apache/airflow/issues/11047#issuecomment-697020430


   @pcandoalmeida you are assigned 🎸 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek closed issue #11047: Create NoGCPServiceAccountKeyInConfigRule to ease upgrade to Airflow 2.0

Posted by GitBox <gi...@apache.org>.
turbaszek closed issue #11047:
URL: https://github.com/apache/airflow/issues/11047


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] pcandoalmeida commented on issue #11047: Create NoGCPServiceAccountKeyInConfigRule to ease upgrade to Airflow 2.0

Posted by GitBox <gi...@apache.org>.
pcandoalmeida commented on issue #11047:
URL: https://github.com/apache/airflow/issues/11047#issuecomment-697000660


   Hello 👋🏼 would I be able to work on this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org