You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@nemo.apache.org by GitBox <gi...@apache.org> on 2018/07/13 08:51:53 UTC

[GitHub] seojangho opened a new pull request #77: [NEMO-161] Make all injectable constructors private

seojangho opened a new pull request #77: [NEMO-161] Make all injectable constructors private
URL: https://github.com/apache/incubator-nemo/pull/77
 
 
   JIRA: [NEMO-161: Make all injectable constructors private](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-161)
   
   **Major changes:**
   - Made all injectable constructors private (e.g. BatchSingleScheduler, SchedulerRunner, ExecutorRegistry, scheduling constraints, ...)
   - Added LocalMessageDispatcher#getInjector, LocalMessageDispatcher#forkInjector, and LocalMessageEnvironment#forkInjector for ease of writing unit tests
   
   **Minor changes to note:**
   - Made NemoBackend() injectable constructor
   
   **Tests for the changes:**
   - Existing tests, modified for private constructors, should continue to work.
   
   **Other comments:**
   - N/A
   
   resolves [NEMO-161](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-161)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services