You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/09/17 21:24:28 UTC
[GitHub] [solr] janhoy opened a new pull request, #1020: SOLR-15920 ReleaseWizard - Upgrade 'consolemenu' dependency to v0.7.1
janhoy opened a new pull request, #1020:
URL: https://github.com/apache/solr/pull/1020
https://issues.apache.org/jira/browse/SOLR-15920
Basically get rid of custom code which is now part of upstream 'consolemenu.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1020: SOLR-15920 ReleaseWizard - Upgrade 'consolemenu' dependency to v0.7.1
Posted by GitBox <gi...@apache.org>.
janhoy commented on code in PR #1020:
URL: https://github.com/apache/solr/pull/1020#discussion_r996356262
##########
dev-tools/scripts/requirements.txt:
##########
@@ -1,8 +1,8 @@
-six>=1.11.0
-Jinja2>=2.10.1
-PyYAML>=5.1
-holidays>=0.9.10
-ics>=0.4
-console-menu==0.5.1
-PyGithub
-jira
\ No newline at end of file
+six==1.16.0
+Jinja2==3.1.1
+PyYAML==6.0
+holidays==0.16
+ics==0.7.2
+console-menu==0.7.1
+PyGithub==1.56
+jira==3.4.1
Review Comment:
I pinned every dependency here.
I releaize that these are shared between release wizard and the other py tools in this folder, so I cannot guarantee that all the other tools work with the pinned version. I tested `githubPRs.py` and it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1020: SOLR-15920 ReleaseWizard - Upgrade 'consolemenu' dependency to v0.7.1
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1020:
URL: https://github.com/apache/solr/pull/1020#issuecomment-1279832669
I see Ishan already did the `UK` change, thanks. So committed a change to `requirements.txt` to pin all lib versions to avoid future surprises.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1020: SOLR-15920 ReleaseWizard - Upgrade 'consolemenu' dependency to v0.7.1
Posted by GitBox <gi...@apache.org>.
janhoy commented on code in PR #1020:
URL: https://github.com/apache/solr/pull/1020#discussion_r996357428
##########
dev-tools/scripts/requirements.txt:
##########
@@ -1,8 +1,8 @@
-six>=1.11.0
-Jinja2>=2.10.1
-PyYAML>=5.1
-holidays>=0.9.10
-ics>=0.4
-console-menu==0.5.1
-PyGithub
-jira
\ No newline at end of file
+six==1.16.0
+Jinja2==3.1.1
+PyYAML==6.0
+holidays==0.16
+ics==0.7.2
+console-menu==0.7.1
+PyGithub==1.56
+jira==3.4.1
Review Comment:
Changed these to [`~=` Compatible Release](https://peps.python.org/pep-0440/#compatible-release) to allow bugfix upgrades.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #1020: SOLR-15920 ReleaseWizard - Upgrade 'consolemenu' dependency to v0.7.1
Posted by GitBox <gi...@apache.org>.
janhoy merged PR #1020:
URL: https://github.com/apache/solr/pull/1020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] sonatype-lift[bot] commented on pull request #1020: SOLR-15920 ReleaseWizard - Upgrade 'consolemenu' dependency to v0.7.1
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on PR #1020:
URL: https://github.com/apache/solr/pull/1020#issuecomment-1279839312
:warning: **314 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/solr/01GFEQJ3SABH8F9Q2JRQEJXH44?tab=technical-debt&utm_source=github.com&utm_campaign=lift-comment&utm_content=apache\%20solr) for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1020: SOLR-15920 ReleaseWizard - Upgrade 'consolemenu' dependency to v0.7.1
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1020:
URL: https://github.com/apache/solr/pull/1020#issuecomment-1261508178
@HoustonPutman I think this is good to go, but would appreciate a quick check. 92 lines deleted :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1020: SOLR-15920 ReleaseWizard - Upgrade 'consolemenu' dependency to v0.7.1
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1020:
URL: https://github.com/apache/solr/pull/1020#issuecomment-1279831355
Mystery solved. We have pip requirement `holidays>=0.9.10` and in `0.15` released this autust they [removed `England`](https://github.com/dr-prodigy/python-holidays/releases/tag/v.0.15)
> Drop support for UK subdivisions as countries (England, Scotland..) (dr-p)
I'll make the change to UK and pin version to 0.15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1020: SOLR-15920 ReleaseWizard - Upgrade 'consolemenu' dependency to v0.7.1
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1020:
URL: https://github.com/apache/solr/pull/1020#issuecomment-1279830212
That’s strange since the holiday rep was not changed. Unless a new dependency upgrade triggered a lib upgrade with this change. The `requirements.txt` should perhaps lock major version of dependencies instead of specifying minimum version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org