You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "auntunt (via GitHub)" <gi...@apache.org> on 2026/10/16 07:16:27 UTC
[PR] Fixed: Misspelled UI label keys show the raw key instead of the label [ofbiz-framework]
auntunt opened a new pull request, #2325:
URL: https://github.com/apache/ofbiz-framework/pull/2325
<!-- claude-projects-attribution: {"github_login":"auntunt"} -->
_Requested by **Li**_
Three form fields referenced label keys that do not exist, so the screen
displayed the key itself as the field title or tooltip:
- PersonTrainingForms.xml: CommmonRequest -> CommonRequest
- EmployeeForms.xml: CommonGrom -> CommonFrom
- SetupForms.xml: ProductNotModificationRecrationCategory -> ProductNotModificationRecreationCategory
This change was prepared with help from an AI coding assistant (Claude Code) and reviewed by me, per the ASF Generative Tooling Guidance.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: Misspelled UI label keys show the raw key instead of the label [ofbiz-framework]
Posted by "auntunt (via GitHub)" <gi...@apache.org>.
auntunt commented on code in PR #2325:
URL: https://github.com/apache/ofbiz-framework/pull/2325#discussion_r4380484246
##########
applications/humanres/widget/forms/EmployeeForms.xml:
##########
@@ -217,7 +217,7 @@
<field name="leaveStatus"><display-entity entity-name="StatusItem" key-field-name="statusId"/></field>
<field name="emplLeaveReasonTypeId"><display/></field>
<field name="leaveTypeId" title="${uiLabelMap.CommonType}"><display-entity entity-name="EmplLeaveType"/></field>
- <field name="fromDate" title="${uiLabelMap.CommonGrom}"></field>
+ <field name="fromDate" title="${uiLabelMap.CommonFrom}"></field>
Review Comment:
Thanks for the review! Updated: `fromDate` now uses `CommonFromDate` in commit de4d71e. Also thanks for pointing this out — the review was very helpful, and I used AI assistance for this change, so the human review caught what I would have missed.
##########
applications/humanres/widget/forms/PersonTrainingForms.xml:
##########
@@ -196,7 +196,7 @@ under the License.
</sub-hyperlink>
</display-entity>
</field>
- <field name="trainingRequestId" title="${uiLabelMap.CommmonRequest}" widget-style="buttontext"/>
+ <field name="trainingRequestId" title="${uiLabelMap.CommonRequest}" widget-style="buttontext"/>
Review Comment:
Thanks! Done in de4d71e: removed the `title` attribute from `trainingRequestId`, consistent with `FindTrainingApprovals` and the other screens. Appreciate the careful review, especially the pointer to the existing pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: Misspelled UI label keys show the raw key instead of the label [ofbiz-framework]
Posted by "golja (via GitHub)" <gi...@apache.org>.
golja commented on code in PR #2325:
URL: https://github.com/apache/ofbiz-framework/pull/2325#discussion_r4376730410
##########
applications/humanres/widget/forms/PersonTrainingForms.xml:
##########
@@ -196,7 +196,7 @@ under the License.
</sub-hyperlink>
</display-entity>
</field>
- <field name="trainingRequestId" title="${uiLabelMap.CommmonRequest}" widget-style="buttontext"/>
+ <field name="trainingRequestId" title="${uiLabelMap.CommonRequest}" widget-style="buttontext"/>
Review Comment:
Since there is no specific label for trainingRequestId, and using the label CommonRequest (which corresponds to “Request”) would not be appropriate for this screen, the 'title' attribute could simply be removed in this case.
Note that this would be consistent with the approach used on other screens, such as FindTrainingApprovals, where no label is specified for the trainingRequestId field.
##########
applications/humanres/widget/forms/EmployeeForms.xml:
##########
@@ -217,7 +217,7 @@
<field name="leaveStatus"><display-entity entity-name="StatusItem" key-field-name="statusId"/></field>
<field name="emplLeaveReasonTypeId"><display/></field>
<field name="leaveTypeId" title="${uiLabelMap.CommonType}"><display-entity entity-name="EmplLeaveType"/></field>
- <field name="fromDate" title="${uiLabelMap.CommonGrom}"></field>
+ <field name="fromDate" title="${uiLabelMap.CommonFrom}"></field>
Review Comment:
The correct label to use in place of “CommonGrom” (which is misspelled) is not “CommonFrom”, but “CommonFromDate”.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: Misspelled UI label keys show the raw key instead of the label [ofbiz-framework]
Posted by "golja (via GitHub)" <gi...@apache.org>.
golja commented on PR #2325:
URL: https://github.com/apache/ofbiz-framework/pull/2325#issuecomment-6425177455
Thanks @auntunt,
I've merged your changes.
Anahita
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: Misspelled UI label keys show the raw key instead of the label [ofbiz-framework]
Posted by "golja (via GitHub)" <gi...@apache.org>.
golja merged PR #2325:
URL: https://github.com/apache/ofbiz-framework/pull/2325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org