You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/09 16:01:35 UTC

[GitHub] [arrow] lidavidm opened a new pull request, #14083: MINOR: [C++] Fix unity build error

lidavidm opened a new pull request, #14083:
URL: https://github.com/apache/arrow/pull/14083

   ```
   /arrow/cpp/src/arrow/compute/exec/bloom_filter.h:252:25: error: type attributes ignored after type is already defined [-Werror=attributes]
     252 | enum class ARROW_EXPORT BloomFilterBuildStrategy {
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] lidavidm merged pull request #14083: MINOR: [C++] Fix unity build error

Posted by GitBox <gi...@apache.org>.
lidavidm merged PR #14083:
URL: https://github.com/apache/arrow/pull/14083


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] ursabot commented on pull request #14083: MINOR: [C++] Fix unity build error

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14083:
URL: https://github.com/apache/arrow/pull/14083#issuecomment-1242826608

   Benchmark runs are scheduled for baseline = f184255cbb9bf911ea2a04910f711e1a924b12b8 and contender = 8a9037d4cd459daef43a083e2e29a7833fb4c62b. 8a9037d4cd459daef43a083e2e29a7833fb4c62b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/682ea1ec211e4afebbd47bf7c0451e86...78ef920014e744a19bb5dd89ccf5c45a/)
   [Failed :arrow_down:1.02% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/bfaecd3a96e343c88a2e2ec34bc86ac6...f8d165c9a57a4a0f99f4838d65555471/)
   [Failed :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/be50a940335f430da38067bc9ebc670a...e50c9cfcd0f34b7295eee6198da5a848/)
   [Finished :arrow_down:1.63% :arrow_up:0.11%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/cb0d653040a54c8a9185e3ba4c89d2aa...5f9ccd749b624f34b5fb15ca2b21782b/)
   Buildkite builds:
   [Finished] [`8a9037d4` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1444)
   [Failed] [`8a9037d4` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1460)
   [Failed] [`8a9037d4` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1444)
   [Finished] [`8a9037d4` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1457)
   [Finished] [`f184255c` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1443)
   [Failed] [`f184255c` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1459)
   [Failed] [`f184255c` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1443)
   [Finished] [`f184255c` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1456)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] lidavidm commented on pull request #14083: MINOR: [C++] Fix unity build error

Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #14083:
URL: https://github.com/apache/arrow/pull/14083#issuecomment-1242812968

   UBSAN failure: ARROW-17675
   
   R failures: I think that's the DuckDB issue
   
   Integration: #14069, though I guess I have to go try patching zlib now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org