You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/04/09 04:20:27 UTC
[GitHub] [hbase] saintstack opened a new pull request #1464: HBASE-24150
Allow module tests run in parallel
saintstack opened a new pull request #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464
Pass --threads=2 to mvn when yetus runs so some parallelism
when dependencies allow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1464:
HBASE-24150 Allow module tests run in parallel
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#discussion_r406351809
##########
File path: dev-support/hbase-personality.sh
##########
@@ -140,7 +140,10 @@ function personality_modules
clear_personality_queue
- extra="-DHBasePatchProcess"
+ # At a few points, hbase modules can run their test suites in parallel
Review comment:
Let me change the comment.
I tried running the mvn clean ... above to find the message you refer to but too blind to see it. Let me add change in pom so its generated here.
On disabling the surefire reporting, you want that in this commit or on a follow-on? Is it this you are referring too?
maven-surefire-report-plugin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1464: HBASE-24150 Allow
module tests run in parallel
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#issuecomment-611671719
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 41s | Docker mode activated. |
| -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 58s | branch-2 passed |
| +1 :green_heart: | compile | 2m 20s | branch-2 passed |
| +1 :green_heart: | shadedjars | 4m 41s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 24s | branch-2 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 32s | the patch passed |
| +1 :green_heart: | compile | 2m 18s | the patch passed |
| +1 :green_heart: | javac | 2m 18s | the patch passed |
| +1 :green_heart: | shadedjars | 4m 42s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 21s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 16m 59s | root in the patch failed. |
| | | 45m 26s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1464/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1464 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 7aeff5c863f8 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 5012241817 |
| Default Java | 1.8.0_232 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1464/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1464/2/testReport/ |
| Max. process+thread count | 592 (vs. ulimit of 12500) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1464/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1464: HBASE-24150 Allow
module tests run in parallel
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#issuecomment-611648681
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1464/2/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1464: HBASE-24150 Allow
module tests run in parallel
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#issuecomment-611322277
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 46s | Docker mode activated. |
| -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch |
||| _ Other Tests _ |
| | | 2m 7s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1464/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1464 |
| Optional Tests | |
| uname | Linux f0856ce1ca6b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 611c62f52a |
| Max. process+thread count | 57 (vs. ulimit of 12500) |
| modules | C: U: |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1464/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1464: HBASE-24150 Allow
module tests run in parallel
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#issuecomment-611648691
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1464/2/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1464: HBASE-24150 Allow
module tests run in parallel
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#issuecomment-611648708
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1464/2/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1464: HBASE-24150 Allow
module tests run in parallel
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#issuecomment-611321949
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1464/1/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1464: HBASE-24150 Allow
module tests run in parallel
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#issuecomment-611658912
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 48s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ branch-2 Compile Tests _ |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 12m 10s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. |
| | | 21m 25s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1464/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1464 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadoopcheck xml |
| uname | Linux d8eaccfc2337 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 5012241817 |
| Max. process+thread count | 63 (vs. ulimit of 12500) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1464/2/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1464:
HBASE-24150 Allow module tests run in parallel
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#discussion_r406368419
##########
File path: dev-support/hbase-personality.sh
##########
@@ -140,7 +140,10 @@ function personality_modules
clear_personality_queue
- extra="-DHBasePatchProcess"
+ # At a few points, hbase modules can run their test suites in parallel
Review comment:
Yeah that's the plugin. Weirdly, now I try but I don't see the warning message. Hmm..
Running with `-T1.0C` I get a failure in
```
[INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (check-aggregate-license) @ hbase-shaded-client ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.EvaluateBeanshell failed with message:
Couldn't evaluate condition: File license = new File("/Users/ndimiduk/repos/apache/hbase/hbase-shaded/hbase-shaded-client/target/maven-shared-archive-resources/META-INF/LICENSE");
// Beanshell does not support try-with-resources,
// so we must close this scanner manually
Scanner scanner = new Scanner(license);
while (scanner.hasNextLine()) {
if (scanner.nextLine().startsWith("ERROR:")) {
scanner.close();
return false;
}
}
scanner.close();
return true;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1464:
HBASE-24150 Allow module tests run in parallel
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#discussion_r406352349
##########
File path: dev-support/hbase_nightly_source-artifact.sh
##########
@@ -125,7 +125,7 @@ fi
# See http://hbase.apache.org/book.html#maven.release
echo "Maven details, in case our JDK doesn't match expectations:"
-mvn --version --offline | tee "${working_dir}/maven_version"
+mvn --threads=2 --version --offline | tee "${working_dir}/maven_version"
Review comment:
Yeah. Dumb change. Undoing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack merged pull request #1464: HBASE-24150 Allow
module tests run in parallel
Posted by GitBox <gi...@apache.org>.
saintstack merged pull request #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1464: HBASE-24150 Allow
module tests run in parallel
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#issuecomment-611322273
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 46s | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch |
||| _ Other Tests _ |
| | | 2m 8s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1464/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1464 |
| Optional Tests | |
| uname | Linux a159c2394bdf 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 611c62f52a |
| Max. process+thread count | 46 (vs. ulimit of 12500) |
| modules | C: U: |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1464/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1464: HBASE-24150 Allow
module tests run in parallel
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#issuecomment-611321993
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1464/1/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1464:
HBASE-24150 Allow module tests run in parallel
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#discussion_r406419800
##########
File path: dev-support/hbase-personality.sh
##########
@@ -140,7 +140,10 @@ function personality_modules
clear_personality_queue
- extra="-DHBasePatchProcess"
+ # At a few points, hbase modules can run their test suites in parallel
Review comment:
For me it's not just a warning, it breaks the build. Yes another issue, but if it consistently breaks runs using `-T`, it would need to be a blocker of this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1464:
HBASE-24150 Allow module tests run in parallel
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#discussion_r406388592
##########
File path: dev-support/hbase-personality.sh
##########
@@ -140,7 +140,10 @@ function personality_modules
clear_personality_queue
- extra="-DHBasePatchProcess"
+ # At a few points, hbase modules can run their test suites in parallel
Review comment:
Yeah, I see those WARNINGs locally too. Another issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1464: HBASE-24150 Allow
module tests run in parallel
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#issuecomment-611322291
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 43s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch |
| +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? |
| | | 2m 15s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1464/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1464 |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux 21fa6e0453e3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 611c62f52a |
| Max. process+thread count | 50 (vs. ulimit of 12500) |
| modules | C: U: |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1464/1/console |
| versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1464: HBASE-24150 Allow
module tests run in parallel
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#issuecomment-611321986
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1464/1/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1464:
HBASE-24150 Allow module tests run in parallel
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#discussion_r406336835
##########
File path: dev-support/hbase-personality.sh
##########
@@ -140,7 +140,10 @@ function personality_modules
clear_personality_queue
- extra="-DHBasePatchProcess"
+ # At a few points, hbase modules can run their test suites in parallel
Review comment:
Not just parallel test suites, but everything. With this change, maven will run up to 2 concurrent modules when the dependency graph permits. I imaging this will be a nice general benefit.
One thing to note though is that some plugins don't support multithreading. IIRC, surefire-reports was one such plugin, and would print warnings in the build. Looks like this patch didn't actually trigger any maven invocation, so I cannot point you at the message. A simple `mvn clean package -DskipTests` should be enough to get the message printed.
Since we use Jenkins to aggregate test results, I suggest we disable/remove surefire-reports (this was something I discussed with @busbey sometime back, but neither of us have gotten to it).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1464:
HBASE-24150 Allow module tests run in parallel
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1464: HBASE-24150 Allow module tests run in parallel
URL: https://github.com/apache/hbase/pull/1464#discussion_r406337176
##########
File path: dev-support/hbase_nightly_source-artifact.sh
##########
@@ -125,7 +125,7 @@ fi
# See http://hbase.apache.org/book.html#maven.release
echo "Maven details, in case our JDK doesn't match expectations:"
-mvn --version --offline | tee "${working_dir}/maven_version"
+mvn --threads=2 --version --offline | tee "${working_dir}/maven_version"
Review comment:
There's no value in `--threads` for grabbing the version info, is there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services