You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2008/11/01 01:29:44 UTC
[jira] Created: (HADOOP-4572) INode and its sub-classes should be
package private
INode and its sub-classes should be package private
---------------------------------------------------
Key: HADOOP-4572
URL: https://issues.apache.org/jira/browse/HADOOP-4572
Project: Hadoop Core
Issue Type: Improvement
Components: dfs
Reporter: Tsz Wo (Nicholas), SZE
INode, INodeFile, INodeDirectory and INodeFileUnderConstruction should be changed from public to package private. As a consequence, some test classes like CreateEditsLog have to be moved to org.apache.hadoop.hdfs.server.namenode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4572) INode and its sub-classes should be
package private
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4572:
-------------------------------------------
Assignee: Tsz Wo (Nicholas), SZE
Release Note: Moved org.apache.hadoop.hdfs.{CreateEditsLog, NNThroughputBenchmark} to org.apache.hadoop.hdfs.server.namenode.
Hadoop Flags: [Incompatible change]
> INode and its sub-classes should be package private
> ---------------------------------------------------
>
> Key: HADOOP-4572
> URL: https://issues.apache.org/jira/browse/HADOOP-4572
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 4572_20081103.patch
>
>
> INode, INodeFile, INodeDirectory and INodeFileUnderConstruction should be changed from public to package private. As a consequence, some test classes like CreateEditsLog have to be moved to org.apache.hadoop.hdfs.server.namenode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4572) INode and its sub-classes should be
package private
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4572:
-------------------------------------------
Attachment: svn_move.sh
svn_move.sh: a script for moving the source files.
> INode and its sub-classes should be package private
> ---------------------------------------------------
>
> Key: HADOOP-4572
> URL: https://issues.apache.org/jira/browse/HADOOP-4572
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.20.0
>
> Attachments: 4572_20081103.patch, svn_move.sh
>
>
> INode, INodeFile, INodeDirectory and INodeFileUnderConstruction should be changed from public to package private. As a consequence, some test classes like CreateEditsLog have to be moved to org.apache.hadoop.hdfs.server.namenode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4572) INode and its sub-classes should be
package private
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645161#action_12645161 ]
Hadoop QA commented on HADOOP-4572:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12393273/4572_20081103.patch
against trunk revision 711482.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 24 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3531/console
This message is automatically generated.
> INode and its sub-classes should be package private
> ---------------------------------------------------
>
> Key: HADOOP-4572
> URL: https://issues.apache.org/jira/browse/HADOOP-4572
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 4572_20081103.patch
>
>
> INode, INodeFile, INodeDirectory and INodeFileUnderConstruction should be changed from public to package private. As a consequence, some test classes like CreateEditsLog have to be moved to org.apache.hadoop.hdfs.server.namenode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4572) INode and its sub-classes should be
package private
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645514#action_12645514 ]
Hudson commented on HADOOP-4572:
--------------------------------
Integrated in Hadoop-trunk #653 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/653/])
. Change INode and its sub-classes to package private. (szetszwo)
> INode and its sub-classes should be package private
> ---------------------------------------------------
>
> Key: HADOOP-4572
> URL: https://issues.apache.org/jira/browse/HADOOP-4572
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.20.0
>
> Attachments: 4572_20081103.patch, svn_move.sh
>
>
> INode, INodeFile, INodeDirectory and INodeFileUnderConstruction should be changed from public to package private. As a consequence, some test classes like CreateEditsLog have to be moved to org.apache.hadoop.hdfs.server.namenode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4572) INode and its sub-classes should be
package private
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4572:
-------------------------------------------
Resolution: Fixed
Fix Version/s: 0.20.0
Hadoop Flags: [Incompatible change, Reviewed] (was: [Reviewed, Incompatible change])
Status: Resolved (was: Patch Available)
I just committed this.
> INode and its sub-classes should be package private
> ---------------------------------------------------
>
> Key: HADOOP-4572
> URL: https://issues.apache.org/jira/browse/HADOOP-4572
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.20.0
>
> Attachments: 4572_20081103.patch, svn_move.sh
>
>
> INode, INodeFile, INodeDirectory and INodeFileUnderConstruction should be changed from public to package private. As a consequence, some test classes like CreateEditsLog have to be moved to org.apache.hadoop.hdfs.server.namenode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4572) INode and its sub-classes should be
package private
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645046#action_12645046 ]
Konstantin Shvachko commented on HADOOP-4572:
---------------------------------------------
+1 This looks good.
> INode and its sub-classes should be package private
> ---------------------------------------------------
>
> Key: HADOOP-4572
> URL: https://issues.apache.org/jira/browse/HADOOP-4572
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 4572_20081103.patch
>
>
> INode, INodeFile, INodeDirectory and INodeFileUnderConstruction should be changed from public to package private. As a consequence, some test classes like CreateEditsLog have to be moved to org.apache.hadoop.hdfs.server.namenode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4572) INode and its sub-classes should be
package private
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4572:
-------------------------------------------
Hadoop Flags: [Incompatible change, Reviewed] (was: [Incompatible change])
Status: Patch Available (was: Open)
> INode and its sub-classes should be package private
> ---------------------------------------------------
>
> Key: HADOOP-4572
> URL: https://issues.apache.org/jira/browse/HADOOP-4572
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 4572_20081103.patch
>
>
> INode, INodeFile, INodeDirectory and INodeFileUnderConstruction should be changed from public to package private. As a consequence, some test classes like CreateEditsLog have to be moved to org.apache.hadoop.hdfs.server.namenode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4572) INode and its sub-classes should be
package private
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4572:
-------------------------------------------
Attachment: 4572_20081103.patch
4572_20081103.patch:
- changed INode, INodeFile, INodeDirectory and INodeFileUnderConstruction to package private.
- moved TestNNThroughputBenchmark, FileNameGenerator, CreateEditsLog and NNThroughputBenchmark to org.apache.hadoop.hdfs.server.namenode.
> INode and its sub-classes should be package private
> ---------------------------------------------------
>
> Key: HADOOP-4572
> URL: https://issues.apache.org/jira/browse/HADOOP-4572
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: 4572_20081103.patch
>
>
> INode, INodeFile, INodeDirectory and INodeFileUnderConstruction should be changed from public to package private. As a consequence, some test classes like CreateEditsLog have to be moved to org.apache.hadoop.hdfs.server.namenode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.