You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/21 03:33:18 UTC

[GitHub] [tvm] yanghaku opened a new issue, #12853: [Bug] target WebGPU cannot enable spirv support

yanghaku opened a new issue, #12853:
URL: https://github.com/apache/tvm/issues/12853

   When I compile the model with target ```' webgpu -keys=webgpu,gpu -max_num_threads=256 '; runtime = ' llvm --system-lib -mtriple=wasm32-emscripten -mattr=+bulk-memory '```, I get the error:  ```Check failed: target->kind->device_type == kDLVulkan (15 vs. 7) : SPIRVSupport can only be checked for vulkan device type```.
   
   I saw the source code in [```src/target/spirv/spirv_support.cc L35```](https://github.com/apache/tvm/blob/d4e3207cca1bae532e6e616eca2e80191e45b437/src/target/spirv/spirv_support.cc#L35)
   
   ```c++
   SPIRVSupport::SPIRVSupport(tvm::Target target) {
     ICHECK_EQ(target->kind->device_type == kDLVulkan || target->kind->device_type == kDLWebGPU, true)
         << "SPIRVSupport can only be checked for vulkan or WebGPU device type";
   
     if (target->GetAttr<Integer>("vulkan_api_version")) {
       vulkan_api_version = target->GetAttr<Integer>("vulkan_api_version").value();
     }
   ......
   ```
   
   Does the assert check not take into account the situation of the webgpu?
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] masahi closed issue #12853: [Bug] target WebGPU cannot enable spirv support

Posted by GitBox <gi...@apache.org>.
masahi closed issue #12853: [Bug] target WebGPU cannot enable spirv support
URL: https://github.com/apache/tvm/issues/12853


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] masahi commented on issue #12853: [Bug] target WebGPU cannot enable spirv support

Posted by GitBox <gi...@apache.org>.
masahi commented on issue #12853:
URL: https://github.com/apache/tvm/issues/12853#issuecomment-1342279132

   Welcome to send a PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] yanghaku commented on issue #12853: [Bug] target WebGPU cannot enable spirv support

Posted by GitBox <gi...@apache.org>.
yanghaku commented on issue #12853:
URL: https://github.com/apache/tvm/issues/12853#issuecomment-1253165818

   when I change the assert check to:
   ```c++
     ICHECK_EQ(target->kind->device_type == kDLVulkan || target->kind->device_type == kDLWebGPU, true)
         << "SPIRVSupport can only be checked for vulkan or WebGPU device type";
   ```
   
   Compiling the model is successful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org