You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@freemarker.apache.org by pradeepmurugesan <gi...@git.apache.org> on 2017/04/12 08:47:00 UTC
[GitHub] incubator-freemarker pull request #20: travis configuration for freemarker
GitHub user pradeepmurugesan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/20
travis configuration for freemarker
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pradeepmurugesan/incubator-freemarker travis
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/20.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20
----
commit b3c8b027aeb4abe5e768f13308ca6632869bdaf1
Author: Pradeep Murugesan <pr...@outlook.com>
Date: 2017-04-12T08:13:56Z
travis configuration for freemarker
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-freemarker pull request #20: travis configuration for freemarker
Posted by ddekany <gi...@git.apache.org>.
Github user ddekany commented on a diff in the pull request:
https://github.com/apache/incubator-freemarker/pull/20#discussion_r111126362
--- Diff: build.xml ---
@@ -133,6 +133,20 @@
<mkdir dir="build"/>
</target>
+ <property name="ivy.install.version" value="2.3.0" />
+ <condition property="ivy.home" value="${env.IVY_HOME}">
--- End diff --
Right, that's the plan. (Of course, running `download-ivy` is always done manually and is optional.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-freemarker pull request #20: travis configuration for freemarker
Posted by ddekany <gi...@git.apache.org>.
Github user ddekany commented on a diff in the pull request:
https://github.com/apache/incubator-freemarker/pull/20#discussion_r111104418
--- Diff: build.xml ---
@@ -133,6 +133,20 @@
<mkdir dir="build"/>
</target>
+ <property name="ivy.install.version" value="2.3.0" />
+ <condition property="ivy.home" value="${env.IVY_HOME}">
--- End diff --
If we utilize the `IVY_HOME` then I think we run into two problems. One is that `download-ivy` will try to overwrite the jar in it. The other is that the jar in `IVY_HOME` is certainly not part of Ant's classpath, so it won't be able to use the ivy tasks. So I guess we just shouldn't use `IVY_HOME`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-freemarker pull request #20: travis configuration for freemarker
Posted by pradeepmurugesan <gi...@git.apache.org>.
Github user pradeepmurugesan commented on a diff in the pull request:
https://github.com/apache/incubator-freemarker/pull/20#discussion_r111116025
--- Diff: build.xml ---
@@ -133,6 +133,20 @@
<mkdir dir="build"/>
</target>
+ <property name="ivy.install.version" value="2.3.0" />
+ <condition property="ivy.home" value="${env.IVY_HOME}">
--- End diff --
Yeah.. got the issue now.. So we just download our version of the ivy library and put it into the .ant/lib directory so that ant will pick it up.
correct me If I am wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-freemarker pull request #20: travis configuration for freemarker
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/20
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---