You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by bb...@apache.org on 2023/01/13 21:35:57 UTC
[kafka] branch trunk updated: Update ProducerConfig.java (#13115)
This is an automated email from the ASF dual-hosted git repository.
bbejeck pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new d2556e02a25 Update ProducerConfig.java (#13115)
d2556e02a25 is described below
commit d2556e02a25af28cf4cc093a190cc0154145121e
Author: Cheryl Simmons <cs...@confluent.io>
AuthorDate: Fri Jan 13 13:35:49 2023 -0800
Update ProducerConfig.java (#13115)
This should be greater than 1 to be consistent with behavior described inmax.in.flight.requests.per.connection.
Reviewers: Bill Bejeck <bb...@apache.org>
---
.../src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java b/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
index e5ad8664126..3ad9d8772cb 100644
--- a/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
+++ b/clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
@@ -258,7 +258,7 @@ public class ProducerConfig extends AbstractConfig {
+ "Enabling idempotence requires this config value to be greater than 0."
+ " If conflicting configurations are set and idempotence is not explicitly enabled, idempotence is disabled."
+ "<p>"
- + "Allowing retries while setting <code>enable.idempotence</code> to <code>false</code> and <code>" + MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION + "</code> to 1 will potentially change the"
+ + "Allowing retries while setting <code>enable.idempotence</code> to <code>false</code> and <code>" + MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION + "</code> to greater than 1 will potentially change the"
+ " ordering of records because if two batches are sent to a single partition, and the first fails and is retried but the second"
+ " succeeds, then the records in the second batch may appear first.";