You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Johan Euphrosine (JIRA)" <ji...@apache.org> on 2009/07/14 12:19:14 UTC
[jira] Updated: (SHINDIG-1112) SignedFetcher doesn't forward
gadgets.io.RequestParameters.HEADERS
[ https://issues.apache.org/jira/browse/SHINDIG-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Euphrosine updated SHINDIG-1112:
--------------------------------------
Description:
When a request a signed, shindig doesn't forwarder gadgets.io.RequestParameters.HEADERS,
Because:
_POST['headers'] are www-form-encoded, key1=value1&key2=value2
And:
BasicRemoteContentFetcher.php expects key1: value1\nkey2: value2
was:
When a request a signed, shindig doesn't forwarder gadgets.io.RequestParameters.HEADERS,
Because:
_POST['headers'] are www-form-encoded, key1=value1&key2=value2
And:
BasicRemoteContentFetcher.php expects key1: value1\nkey2: value2
This patch should correct this issue:
diff -r c55b8bdc0e05 usr/src/shindig-1.0-incubating-php/src/gadgets/SigningFetcher.php
--- a/usr/src/shindig-1.0-incubating-php/src/gadgets/SigningFetcher.php Tue Jul 14 10:39:22 2009 +0200
+++ b/usr/src/shindig-1.0-incubating-php/src/gadgets/SigningFetcher.php Tue Jul 14 12:18:25 2009 +0200
@@ -175,7 +175,7 @@
$url = $parsedUri['scheme'] . '://' . $parsedUri['host'] . (isset($parsedUri['port']) ? ':' . $parsedUri['port'] : '') . $parsedUri['path'] . '?' . $newQuery;
// The headers are transmitted in the POST-data array in the field 'headers'^M
// if no post should be made, the value should be false for this parameter^M
- $postHeaders = ((isset($_POST['headers']) && $method == 'POST') ? $_POST['headers'] : false);
+ $postHeaders = ((isset($_POST['headers']) && $method == 'POST') ? urldecode(str_replace("&", "\n", str_replace("=", ": ", $_POST['headers']))) : false);
return new RemoteContentRequest($url, $postHeaders, $postData);
} catch (Exception $e) {
throw new GadgetException($e);
> SignedFetcher doesn't forward gadgets.io.RequestParameters.HEADERS
> ------------------------------------------------------------------
>
> Key: SHINDIG-1112
> URL: https://issues.apache.org/jira/browse/SHINDIG-1112
> Project: Shindig
> Issue Type: Bug
> Components: PHP
> Affects Versions: 1.0
> Reporter: Johan Euphrosine
>
> When a request a signed, shindig doesn't forwarder gadgets.io.RequestParameters.HEADERS,
> Because:
> _POST['headers'] are www-form-encoded, key1=value1&key2=value2
> And:
> BasicRemoteContentFetcher.php expects key1: value1\nkey2: value2
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.