[GitHub] [tvm] Hzfengsy commented on a diff in pull request #12836: [TIR] Enhance RemoveNoOp pass to remove negative loop

[GitBox <gi...@apache.org>]

Hzfengsy commented on code in PR #12836:
URL: https://github.com/apache/tvm/pull/12836#discussion_r974140918


##########
src/tir/transforms/remove_no_op.cc:
##########
@@ -162,6 +168,9 @@ class NoOpRemover : public StmtMutator {
     }
     return stmt.defined() ? stmt : Evaluate(0);
   }
+
+  std::unordered_map<const VarNode*, arith::IntSet> var_range_map;
+  arith::Analyzer analyzer;

Review Comment:
   ```suggestion
     std::unordered_map<const VarNode*, arith::IntSet> var_range_map_;
     arith::Analyzer analyzer_;
   ```
   Also, please add the document



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org