You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "kirktrue (via GitHub)" <gi...@apache.org> on 2023/10/31 02:52:53 UTC
[PR] KAFKA-15281: Implement the groupMetadata Consumer API [kafka]
kirktrue opened a new pull request, #14672:
URL: https://github.com/apache/kafka/pull/14672
This implements the `Consumer.groupMetadata()` API by means of an event passed to and fulfilled in the consumer network I/O thread. The application thread will block until this event is processed in the background thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15281: Implement the groupMetadata Consumer API [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #14672:
URL: https://github.com/apache/kafka/pull/14672#discussion_r1390251511
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -153,6 +154,13 @@ public int memberEpoch() {
return memberEpoch;
}
+ @Override
+ public ConsumerGroupMetadata groupMetadata() {
+ // TODO: what do we use here, epoch?
Review Comment:
We should return the member epoch. The generationId name is a bit annoying though. I am not sure if we can do something about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15281: Implement the groupMetadata Consumer API [kafka]
Posted by "kirktrue (via GitHub)" <gi...@apache.org>.
kirktrue commented on PR #14672:
URL: https://github.com/apache/kafka/pull/14672#issuecomment-1786396441
@philipnee Can you add the `ctr` tag, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15281: Implement the groupMetadata Consumer API [kafka]
Posted by "kirktrue (via GitHub)" <gi...@apache.org>.
kirktrue closed pull request #14672: KAFKA-15281: Implement the groupMetadata Consumer API
URL: https://github.com/apache/kafka/pull/14672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15281: Implement the groupMetadata Consumer API [kafka]
Posted by "kirktrue (via GitHub)" <gi...@apache.org>.
kirktrue commented on PR #14672:
URL: https://github.com/apache/kafka/pull/14672#issuecomment-1856533985
This was implemented by @cadonna in #14879, so closing this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org