You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/02 18:42:22 UTC
[GitHub] [airflow] raphaelauv opened a new pull request #19987: Remove postgres 9.6 support
raphaelauv opened a new pull request #19987:
URL: https://github.com/apache/airflow/pull/19987
close #19986 https://github.com/apache/airflow/issues/19986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19987: Remove postgres 9.6 support
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19987:
URL: https://github.com/apache/airflow/pull/19987#issuecomment-985079843
here -our rules for Python and Kubernetes https://github.com/apache/airflow/discussions/19871 - and we already removed K8S support for older versions without the intention of making it breaking change https://github.com/apache/airflow/commit/34484678bf16128ec7c0a3fd0dbe9f90b2a64ed7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19987: Remove postgres 9.6 support
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19987:
URL: https://github.com/apache/airflow/pull/19987#issuecomment-984903231
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #19987: Remove postgres 9.6 support
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #19987:
URL: https://github.com/apache/airflow/pull/19987#discussion_r761538202
##########
File path: scripts/ci/libraries/_initialization.sh
##########
@@ -115,7 +115,7 @@ function initialization::initialize_base_variables() {
export CURRENT_PYTHON_MAJOR_MINOR_VERSIONS
# Currently supported versions of Postgres
- CURRENT_POSTGRES_VERSIONS+=("9.6" "13")
+ CURRENT_POSTGRES_VERSIONS+=("10" "13")
Review comment:
Gotcha, cool, makes sense 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #19987: Remove postgres 9.6 support
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #19987:
URL: https://github.com/apache/airflow/pull/19987#discussion_r761535278
##########
File path: scripts/ci/libraries/_initialization.sh
##########
@@ -115,7 +115,7 @@ function initialization::initialize_base_variables() {
export CURRENT_PYTHON_MAJOR_MINOR_VERSIONS
# Currently supported versions of Postgres
- CURRENT_POSTGRES_VERSIONS+=("9.6" "13")
+ CURRENT_POSTGRES_VERSIONS+=("10" "13")
Review comment:
This was deliberate decision.
Those are not consistent because we made a conscious decision that if CI works for "lowest" and "highest" version - it works for those between.
We NEVER saw postgres related version problem. Not that I am aware of (as opposed to our Elephant in the room MySQL which keeps on appearing now and then). this was pure optimization for CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19987: Remove postgres 9.6 support
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19987:
URL: https://github.com/apache/airflow/pull/19987#issuecomment-985077796
> Do we consider it to be a breaking change ?
This is a good question. I do not think we should. When software reaches EOL, we remove it. This is what is going to happen very soon with Python 3.6 and we already agreed it's not technically a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19987: Remove postgres 9.6 support
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19987:
URL: https://github.com/apache/airflow/pull/19987#issuecomment-984902361
Oh nice! Happy to LGTM But I think we need also a message to the devlist asking for a lazy consensus - would you like to send one @raphaelauv ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #19987: Remove postgres 9.6 support
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #19987:
URL: https://github.com/apache/airflow/pull/19987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #19987: Remove postgres 9.6 support
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #19987:
URL: https://github.com/apache/airflow/pull/19987#issuecomment-985079843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #19987: Remove postgres 9.6 support
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #19987:
URL: https://github.com/apache/airflow/pull/19987#discussion_r761461263
##########
File path: scripts/ci/libraries/_initialization.sh
##########
@@ -115,7 +115,7 @@ function initialization::initialize_base_variables() {
export CURRENT_PYTHON_MAJOR_MINOR_VERSIONS
# Currently supported versions of Postgres
- CURRENT_POSTGRES_VERSIONS+=("9.6" "13")
+ CURRENT_POSTGRES_VERSIONS+=("10" "13")
Review comment:
Should this also include 11 and 12, or should they be removed from `BREEZE.rst` instead? Right not it isn't consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #19987: Remove postgres 9.6 support
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #19987:
URL: https://github.com/apache/airflow/pull/19987#discussion_r761535278
##########
File path: scripts/ci/libraries/_initialization.sh
##########
@@ -115,7 +115,7 @@ function initialization::initialize_base_variables() {
export CURRENT_PYTHON_MAJOR_MINOR_VERSIONS
# Currently supported versions of Postgres
- CURRENT_POSTGRES_VERSIONS+=("9.6" "13")
+ CURRENT_POSTGRES_VERSIONS+=("10" "13")
Review comment:
This was deliberate decision.
Those are not consistent because we made a conscious decision that if CI works for "lowest" and "highest" version of Postgres - it works for those between.
We NEVER saw postgres related version problem. Not that I am aware of (as opposed to our Elephant in the room MySQL which keeps on appearing now and then). this was pure optimization for CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #19987: Remove postgres 9.6 support
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #19987:
URL: https://github.com/apache/airflow/pull/19987#issuecomment-984924180
Do we consider it to be a breaking change ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org