You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "uros-b (via GitHub)" <gi...@apache.org> on 2026/08/05 11:06:42 UTC

[PR] [SPARK-58590][PS] Remove obsolete pandas 0.24.0 version notes from datetime accessor docstrings [spark]

uros-b opened a new pull request, #57793:
URL: https://github.com/apache/spark/pull/57793

   ### What changes were proposed in this pull request?
   Removes three identical obsolete notes from the `DatetimeMethods.round`, `floor` and `ceil` docstrings in pandas-on-Spark:
   
   ```
   .. note:: this option only works with pandas 0.24.0+
   ```
   
   ### Why are the changes needed?
   PySpark requires pandas 2.2.0 or newer (`require_minimum_pandas_version` in `python/pyspark/sql/pandas/utils.py`, and `pandas>=2.2.0` in the packaging setup files), so the 0.24.0 condition can never be false. The note is dead and slightly misleading to readers of the API docs.
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   Docstring-only change; no code paths are touched. No tests needed.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   Generated-by: Claude Code (Opus 4.8)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-58590][PS] Remove obsolete pandas 0.24.0 version notes from datetime accessor docstrings [spark]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #57793:
URL: https://github.com/apache/spark/pull/57793#issuecomment-5203001941

   **Merge Summary:**
   - merged into master https://github.com/apache/spark/commit/eb318ba30c0290d4e9812ac9229cb75319f6f6f9
   - merged into branch-4.x https://github.com/apache/spark/commit/3d3d2562b67a96cd66f57b0e52cea87397bf3537
   - merged into branch-4.3 https://github.com/apache/spark/commit/545aa45ffb9d62f1fa2bbb5117eb5964801bf2b5
   
   *Posted by `merge_spark_pr.py`*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-58590][PS] Remove obsolete pandas 0.24.0 version notes from datetime accessor docstrings [spark]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b closed pull request #57793: [SPARK-58590][PS] Remove obsolete pandas 0.24.0 version notes from datetime accessor docstrings
URL: https://github.com/apache/spark/pull/57793


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org