[GitHub] [airflow] potiuk commented on pull request #22542: Optimize direct push workflows in GitHub Actions

[GitBox <gi...@apache.org>]

potiuk commented on pull request #22542:
URL: https://github.com/apache/airflow/pull/22542#issuecomment-1079702548


   Hey everyone (especially @ashb - you wanted to implement it differently but I found a better way)  - this is really nice optimization of the build workflow of ours for "direct pushes", "merges", "scheduled builds" and "PRs not from forks". 
   
   Those do not happen for regular PRs but it will allow to test "build changing" PRs by committers and it will save quite some time for "wait for images" for merge and scheduled builds.
   
   This has been inspired by the changes I had to implement in `v2-2-tests` branch  to make sure that the builds will run fine for "Python 3.6"  (which is not supported in `main` any more)  - it turned out that I could simply add conditional "build images" jobs in the `ci.yml` workflow. All steps for those will be "skipped" in "fork" PRs (because they have no permissions) and in this case the "build-images" workflow is still used but for all builds that are done in the "apache/airlfow"  repo, it's perfectly fine to build images in "ci.yml" workflow.
   
   Also cc: @edithturn  - this will make it much easier to get in changes that also change build scripts - because for all the PRs and pushes done directly in `apache/airflow` (only committers can push there) we will not have to merge to `main` in order to verify that builds changing the build scripts work. Just internal PR from "apache/airlfow" will be enough


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org