You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Maja Kabiljo (JIRA)" <ji...@apache.org> on 2012/09/11 17:41:07 UTC
[jira] [Created] (GIRAPH-323) Check if requests are done before
calling wait
Maja Kabiljo created GIRAPH-323:
-----------------------------------
Summary: Check if requests are done before calling wait
Key: GIRAPH-323
URL: https://issues.apache.org/jira/browse/GIRAPH-323
Project: Giraph
Issue Type: Bug
Reporter: Maja Kabiljo
Assignee: Maja Kabiljo
Priority: Minor
In NettyClient.waitSomeRequests we don't check whether we still have open requests before calling wait. So we can end up waiting for another waitingRequestMsecs even though we are done, because last notifyAll was called before we started waiting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-323) Check if requests are done before
calling wait
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454593#comment-13454593 ]
Hudson commented on GIRAPH-323:
-------------------------------
Integrated in Giraph-trunk-Commit #195 (See [https://builds.apache.org/job/Giraph-trunk-Commit/195/])
GIRAPH-323 Check if requests are done before calling wait (majakabiljo via ereisman) (Revision 1384193)
Result = SUCCESS
ereisman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1384193
Files :
* /giraph/trunk/CHANGELOG
* /giraph/trunk/src/main/java/org/apache/giraph/comm/netty/NettyClient.java
> Check if requests are done before calling wait
> ----------------------------------------------
>
> Key: GIRAPH-323
> URL: https://issues.apache.org/jira/browse/GIRAPH-323
> Project: Giraph
> Issue Type: Bug
> Reporter: Maja Kabiljo
> Assignee: Maja Kabiljo
> Priority: Minor
> Attachments: GIRAPH-323.patch
>
>
> In NettyClient.waitSomeRequests we don't check whether we still have open requests before calling wait. So we can end up waiting for another waitingRequestMsecs even though we are done, because last notifyAll was called before we started waiting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-323) Check if requests are done before
calling wait
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454591#comment-13454591 ]
Eli Reisman commented on GIRAPH-323:
------------------------------------
+1, committed. Thanks Maja!
> Check if requests are done before calling wait
> ----------------------------------------------
>
> Key: GIRAPH-323
> URL: https://issues.apache.org/jira/browse/GIRAPH-323
> Project: Giraph
> Issue Type: Bug
> Reporter: Maja Kabiljo
> Assignee: Maja Kabiljo
> Priority: Minor
> Attachments: GIRAPH-323.patch
>
>
> In NettyClient.waitSomeRequests we don't check whether we still have open requests before calling wait. So we can end up waiting for another waitingRequestMsecs even though we are done, because last notifyAll was called before we started waiting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-323) Check if requests are done before
calling wait
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453286#comment-13453286 ]
Eli Reisman commented on GIRAPH-323:
------------------------------------
Makes sense to me. I'll leave this a day for folks to jump in but otherwise I think we're good here. Thanks Maja!
> Check if requests are done before calling wait
> ----------------------------------------------
>
> Key: GIRAPH-323
> URL: https://issues.apache.org/jira/browse/GIRAPH-323
> Project: Giraph
> Issue Type: Bug
> Reporter: Maja Kabiljo
> Assignee: Maja Kabiljo
> Priority: Minor
> Attachments: GIRAPH-323.patch
>
>
> In NettyClient.waitSomeRequests we don't check whether we still have open requests before calling wait. So we can end up waiting for another waitingRequestMsecs even though we are done, because last notifyAll was called before we started waiting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-323) Check if requests are done before
calling wait
Posted by "Maja Kabiljo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maja Kabiljo updated GIRAPH-323:
--------------------------------
Attachment: GIRAPH-323.patch
> Check if requests are done before calling wait
> ----------------------------------------------
>
> Key: GIRAPH-323
> URL: https://issues.apache.org/jira/browse/GIRAPH-323
> Project: Giraph
> Issue Type: Bug
> Reporter: Maja Kabiljo
> Assignee: Maja Kabiljo
> Priority: Minor
> Attachments: GIRAPH-323.patch
>
>
> In NettyClient.waitSomeRequests we don't check whether we still have open requests before calling wait. So we can end up waiting for another waitingRequestMsecs even though we are done, because last notifyAll was called before we started waiting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira