You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by "Zhe (Joe) Wang" <jw...@hortonworks.com> on 2016/02/26 00:12:10 UTC
Review Request 44048: AMBARI-15193 Auto-start UI edits
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44048/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15193
https://issues.apache.org/jira/browse/AMBARI-15193
Repository: ambari
Description
-------
1. Auto-Start Services, strong
2. Left align the Auto-Start Services switch (so it’s next to the text)
3. Auto-Start Services (remove the word Enabled)
4. Stick with the harvey balls
5. Add tool tip on harvey ball to help the user understand it better
6. Add column titles Service | Component | Status
7. Add Enable All | Disable All links for convenience
8. Any component that is NOT installed, do not display that component
9. The popup text changes
Diffs
-----
ambari-web/app/controllers/main/admin/service_auto_start.js 4071292
ambari-web/app/messages.js 2622043
ambari-web/app/styles/application.less 4e2b5d1
ambari-web/app/templates/main/admin/service_auto_start.hbs 5d9b67c
ambari-web/app/templates/main/admin/service_auto_start/service_auto_start_indicator.hbs PRE-CREATION
ambari-web/app/utils/ajax/ajax.js 3ccd01c
ambari-web/app/views.js 0d3e49b
ambari-web/app/views/main/admin/service_auto_start/component_auto_start.js cc910b8
ambari-web/app/views/main/admin/service_auto_start/service_auto_start_indicator.js PRE-CREATION
Diff: https://reviews.apache.org/r/44048/diff/
Testing
-------
Local ambari-web test passed.
24315 tests complete (22 seconds)
146 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Re: Review Request 44048: AMBARI-15193 Auto-start UI edits
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44048/#review121000
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On Feb. 26, 2016, 10:21 p.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44048/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 10:21 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15193
> https://issues.apache.org/jira/browse/AMBARI-15193
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Auto-Start Services, strong
> 2. Left align the Auto-Start Services switch (so it’s next to the text)
> 3. Auto-Start Services (remove the word Enabled)
> 4. Stick with the harvey balls
> 5. Add tool tip on harvey ball to help the user understand it better
> 6. Add column titles Service | Component | Status
> 7. Add Enable All | Disable All links for convenience
> 8. Any component that is NOT installed, do not display that component
> 9. The popup text changes
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/service_auto_start.js 4071292
> ambari-web/app/messages.js 1cefce2
> ambari-web/app/styles/application.less 75ceacc
> ambari-web/app/templates/main/admin/service_auto_start.hbs 5d9b67c
> ambari-web/app/templates/main/admin/service_auto_start/service_auto_start_indicator.hbs PRE-CREATION
> ambari-web/app/utils/ajax/ajax.js f839e58
> ambari-web/app/views.js 18b43a8
> ambari-web/app/views/main/admin/service_auto_start/component_auto_start.js cc910b8
> ambari-web/app/views/main/admin/service_auto_start/service_auto_start_indicator.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44048/diff/
>
>
> Testing
> -------
>
> Local ambari-web test passed.
> 24315 tests complete (22 seconds)
> 146 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>
Re: Review Request 44048: AMBARI-15193 Auto-start UI edits
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44048/#review121342
-----------------------------------------------------------
Ship it!
Ship It!
- Richard Zang
On Feb. 29, 2016, 10:35 p.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44048/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 10:35 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15193
> https://issues.apache.org/jira/browse/AMBARI-15193
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Auto-Start Services, strong
> 2. Left align the Auto-Start Services switch (so it’s next to the text)
> 3. Auto-Start Services (remove the word Enabled)
> 4. Stick with the harvey balls
> 5. Add tool tip on harvey ball to help the user understand it better
> 6. Add column titles Service | Component | Status
> 7. Add Enable All | Disable All links for convenience
> 8. Any component that is NOT installed, do not display that component
> 9. The popup text changes
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/service_auto_start.js 4071292
> ambari-web/app/messages.js d88b8e3
> ambari-web/app/styles/application.less d8cb4ca
> ambari-web/app/templates/main/admin/service_auto_start.hbs 5d9b67c
> ambari-web/app/templates/main/admin/service_auto_start/service_auto_start_indicator.hbs PRE-CREATION
> ambari-web/app/utils/ajax/ajax.js f839e58
> ambari-web/app/views.js 18b43a8
> ambari-web/app/views/main/admin/service_auto_start/component_auto_start.js cc910b8
> ambari-web/app/views/main/admin/service_auto_start/service_auto_start_indicator.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44048/diff/
>
>
> Testing
> -------
>
> Local ambari-web test passed.
> 24315 tests complete (22 seconds)
> 146 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>
Re: Review Request 44048: AMBARI-15193 Auto-start UI edits
Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44048/
-----------------------------------------------------------
(Updated Feb. 29, 2016, 10:35 p.m.)
Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15193
https://issues.apache.org/jira/browse/AMBARI-15193
Repository: ambari
Description
-------
1. Auto-Start Services, strong
2. Left align the Auto-Start Services switch (so it’s next to the text)
3. Auto-Start Services (remove the word Enabled)
4. Stick with the harvey balls
5. Add tool tip on harvey ball to help the user understand it better
6. Add column titles Service | Component | Status
7. Add Enable All | Disable All links for convenience
8. Any component that is NOT installed, do not display that component
9. The popup text changes
Diffs (updated)
-----
ambari-web/app/controllers/main/admin/service_auto_start.js 4071292
ambari-web/app/messages.js d88b8e3
ambari-web/app/styles/application.less d8cb4ca
ambari-web/app/templates/main/admin/service_auto_start.hbs 5d9b67c
ambari-web/app/templates/main/admin/service_auto_start/service_auto_start_indicator.hbs PRE-CREATION
ambari-web/app/utils/ajax/ajax.js f839e58
ambari-web/app/views.js 18b43a8
ambari-web/app/views/main/admin/service_auto_start/component_auto_start.js cc910b8
ambari-web/app/views/main/admin/service_auto_start/service_auto_start_indicator.js PRE-CREATION
Diff: https://reviews.apache.org/r/44048/diff/
Testing
-------
Local ambari-web test passed.
24315 tests complete (22 seconds)
146 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Re: Review Request 44048: AMBARI-15193 Auto-start UI edits
Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44048/
-----------------------------------------------------------
(Updated Feb. 29, 2016, 10:34 p.m.)
Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15193
https://issues.apache.org/jira/browse/AMBARI-15193
Repository: ambari
Description
-------
1. Auto-Start Services, strong
2. Left align the Auto-Start Services switch (so it’s next to the text)
3. Auto-Start Services (remove the word Enabled)
4. Stick with the harvey balls
5. Add tool tip on harvey ball to help the user understand it better
6. Add column titles Service | Component | Status
7. Add Enable All | Disable All links for convenience
8. Any component that is NOT installed, do not display that component
9. The popup text changes
Diffs (updated)
-----
ambari-web/app/controllers/main/admin/service_auto_start.js 4071292
ambari-web/app/messages.js d88b8e3
ambari-web/app/styles/application.less d8cb4ca
ambari-web/app/templates/main/admin/service_auto_start.hbs 5d9b67c
ambari-web/app/utils/ajax/ajax.js f839e58
ambari-web/app/views.js 18b43a8
ambari-web/app/views/main/admin/service_auto_start/component_auto_start.js cc910b8
Diff: https://reviews.apache.org/r/44048/diff/
Testing
-------
Local ambari-web test passed.
24315 tests complete (22 seconds)
146 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Re: Review Request 44048: AMBARI-15193 Auto-start UI edits
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44048/#review121333
-----------------------------------------------------------
Try to make the switch UI reverse bindable(value driven)
- Richard Zang
On Feb. 26, 2016, 10:21 p.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44048/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 10:21 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15193
> https://issues.apache.org/jira/browse/AMBARI-15193
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Auto-Start Services, strong
> 2. Left align the Auto-Start Services switch (so it’s next to the text)
> 3. Auto-Start Services (remove the word Enabled)
> 4. Stick with the harvey balls
> 5. Add tool tip on harvey ball to help the user understand it better
> 6. Add column titles Service | Component | Status
> 7. Add Enable All | Disable All links for convenience
> 8. Any component that is NOT installed, do not display that component
> 9. The popup text changes
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/service_auto_start.js 4071292
> ambari-web/app/messages.js 1cefce2
> ambari-web/app/styles/application.less 75ceacc
> ambari-web/app/templates/main/admin/service_auto_start.hbs 5d9b67c
> ambari-web/app/templates/main/admin/service_auto_start/service_auto_start_indicator.hbs PRE-CREATION
> ambari-web/app/utils/ajax/ajax.js f839e58
> ambari-web/app/views.js 18b43a8
> ambari-web/app/views/main/admin/service_auto_start/component_auto_start.js cc910b8
> ambari-web/app/views/main/admin/service_auto_start/service_auto_start_indicator.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44048/diff/
>
>
> Testing
> -------
>
> Local ambari-web test passed.
> 24315 tests complete (22 seconds)
> 146 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>
Re: Review Request 44048: AMBARI-15193 Auto-start UI edits
Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44048/
-----------------------------------------------------------
(Updated Feb. 26, 2016, 10:21 p.m.)
Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15193
https://issues.apache.org/jira/browse/AMBARI-15193
Repository: ambari
Description
-------
1. Auto-Start Services, strong
2. Left align the Auto-Start Services switch (so it’s next to the text)
3. Auto-Start Services (remove the word Enabled)
4. Stick with the harvey balls
5. Add tool tip on harvey ball to help the user understand it better
6. Add column titles Service | Component | Status
7. Add Enable All | Disable All links for convenience
8. Any component that is NOT installed, do not display that component
9. The popup text changes
Diffs (updated)
-----
ambari-web/app/controllers/main/admin/service_auto_start.js 4071292
ambari-web/app/messages.js 1cefce2
ambari-web/app/styles/application.less 75ceacc
ambari-web/app/templates/main/admin/service_auto_start.hbs 5d9b67c
ambari-web/app/templates/main/admin/service_auto_start/service_auto_start_indicator.hbs PRE-CREATION
ambari-web/app/utils/ajax/ajax.js f839e58
ambari-web/app/views.js 18b43a8
ambari-web/app/views/main/admin/service_auto_start/component_auto_start.js cc910b8
ambari-web/app/views/main/admin/service_auto_start/service_auto_start_indicator.js PRE-CREATION
Diff: https://reviews.apache.org/r/44048/diff/
Testing
-------
Local ambari-web test passed.
24315 tests complete (22 seconds)
146 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Re: Review Request 44048: AMBARI-15193 Auto-start UI edits
Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
> On Feb. 26, 2016, 9:57 p.m., Srimanth Gunturi wrote:
> > ambari-web/app/controllers/main/admin/service_auto_start.js, line 179
> > <https://reviews.apache.org/r/44048/diff/1/?file=1271644#file1271644line179>
> >
> > I am thinking it should be 'recoveryEnabled'?
That's what I thought, too. But to be consistent with varables (e.g. service_name, component_name, display_name), I removed the bi-direction conversions.
> On Feb. 26, 2016, 9:57 p.m., Srimanth Gunturi wrote:
> > ambari-web/app/utils/ajax/ajax.js, line 2372
> > <https://reviews.apache.org/r/44048/diff/1/?file=1271649#file1271649line2372>
> >
> > Are you sure this has to be removed? Multiple other calls still make use of same structure.
I used that according other calls. But this api is not accepting that. I have to strip it out.
- Zhe (Joe)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44048/#review120972
-----------------------------------------------------------
On Feb. 26, 2016, 10:21 p.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44048/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 10:21 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15193
> https://issues.apache.org/jira/browse/AMBARI-15193
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Auto-Start Services, strong
> 2. Left align the Auto-Start Services switch (so it’s next to the text)
> 3. Auto-Start Services (remove the word Enabled)
> 4. Stick with the harvey balls
> 5. Add tool tip on harvey ball to help the user understand it better
> 6. Add column titles Service | Component | Status
> 7. Add Enable All | Disable All links for convenience
> 8. Any component that is NOT installed, do not display that component
> 9. The popup text changes
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/service_auto_start.js 4071292
> ambari-web/app/messages.js 1cefce2
> ambari-web/app/styles/application.less 75ceacc
> ambari-web/app/templates/main/admin/service_auto_start.hbs 5d9b67c
> ambari-web/app/templates/main/admin/service_auto_start/service_auto_start_indicator.hbs PRE-CREATION
> ambari-web/app/utils/ajax/ajax.js f839e58
> ambari-web/app/views.js 18b43a8
> ambari-web/app/views/main/admin/service_auto_start/component_auto_start.js cc910b8
> ambari-web/app/views/main/admin/service_auto_start/service_auto_start_indicator.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44048/diff/
>
>
> Testing
> -------
>
> Local ambari-web test passed.
> 24315 tests complete (22 seconds)
> 146 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>
Re: Review Request 44048: AMBARI-15193 Auto-start UI edits
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44048/#review120972
-----------------------------------------------------------
ambari-web/app/controllers/main/admin/service_auto_start.js (line 178)
<https://reviews.apache.org/r/44048/#comment182527>
I am thinking it should be 'recoveryEnabled'?
ambari-web/app/messages.js (line 1466)
<https://reviews.apache.org/r/44048/#comment182526>
The value should use a placeholder like '{0} components enabled' instead of just suffixing. In other languages it could end up in the middle etc.
ambari-web/app/utils/ajax/ajax.js
<https://reviews.apache.org/r/44048/#comment182528>
Are you sure this has to be removed? Multiple other calls still make use of same structure.
- Srimanth Gunturi
On Feb. 25, 2016, 11:12 p.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44048/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 11:12 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15193
> https://issues.apache.org/jira/browse/AMBARI-15193
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Auto-Start Services, strong
> 2. Left align the Auto-Start Services switch (so it’s next to the text)
> 3. Auto-Start Services (remove the word Enabled)
> 4. Stick with the harvey balls
> 5. Add tool tip on harvey ball to help the user understand it better
> 6. Add column titles Service | Component | Status
> 7. Add Enable All | Disable All links for convenience
> 8. Any component that is NOT installed, do not display that component
> 9. The popup text changes
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/admin/service_auto_start.js 4071292
> ambari-web/app/messages.js 2622043
> ambari-web/app/styles/application.less 4e2b5d1
> ambari-web/app/templates/main/admin/service_auto_start.hbs 5d9b67c
> ambari-web/app/templates/main/admin/service_auto_start/service_auto_start_indicator.hbs PRE-CREATION
> ambari-web/app/utils/ajax/ajax.js 3ccd01c
> ambari-web/app/views.js 0d3e49b
> ambari-web/app/views/main/admin/service_auto_start/component_auto_start.js cc910b8
> ambari-web/app/views/main/admin/service_auto_start/service_auto_start_indicator.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44048/diff/
>
>
> Testing
> -------
>
> Local ambari-web test passed.
> 24315 tests complete (22 seconds)
> 146 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>