You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/29 22:58:15 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #20566: Reword section covering the envvar secrets in chart docs

potiuk commented on a change in pull request #20566:
URL: https://github.com/apache/airflow/pull/20566#discussion_r776518477



##########
File path: docs/helm-chart/production-guide.rst
##########
@@ -415,18 +415,17 @@ Built-in secrets and environment variables
 ------------------------------------------
 
 The Helm Chart by default uses Kubernetes Secrets to store secrets that are needed by Airflow.
-Content of those secrets is by default turned into environment variables that are read by
+The contents of those secrets are by default turned into environment variables that are read by
 Airflow (some of the environment variables have several variants to support older versions of Airflow).
 
-By default, names of the secret used is determined from the Release Name used when Helm Chart is deployed,
-but you can also set your own names for the secrets to override the variables or disable using the secrets
+By default, the secret names are determined from the Release Name used when the Helm Chart is deployed,
+but you can also use a different secret to set the variables or disable using secrets
 entirely and rely on environment variables (specifically if you want to use ``_CMD`` or ``__SECRET`` variant
 of the environment variable.
 
 However, Airflow supports other variants of setting secret configuration - you can specify a system
 command to retrieve and automatically rotate the secret (by defining variable with ``_CMD`` suffix) or
-to retrieve a variable from secret backed (by defining the variable with ``_SECRET`` suffix). All
-``AIRFLOW__*`` variables implement those patterns.

Review comment:
       Yep. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org