You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Johan Oskarsson (JIRA)" <ji...@apache.org> on 2009/01/14 14:01:18 UTC
[jira] Created: (HIVE-231) Create junit reports for tests
Create junit reports for tests
------------------------------
Key: HIVE-231
URL: https://issues.apache.org/jira/browse/HIVE-231
Project: Hadoop Hive
Issue Type: Test
Components: Testing Infrastructure
Reporter: Johan Oskarsson
Priority: Trivial
Suggestion to create html junit reports for the hive tests. This would give developers an easier overview of what has gone wrong if the build fails then having to look through text files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (HIVE-231) Create junit reports for tests
Posted by Rustam Rakhimov <ru...@gmail.com>.
unsubscribe
[jira] Commented: (HIVE-231) Create junit reports for tests
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663810#action_12663810 ]
Prasad Chakka commented on HIVE-231:
------------------------------------
+1
> Create junit reports for tests
> ------------------------------
>
> Key: HIVE-231
> URL: https://issues.apache.org/jira/browse/HIVE-231
> Project: Hadoop Hive
> Issue Type: Test
> Components: Testing Infrastructure
> Reporter: Johan Oskarsson
> Priority: Trivial
> Attachments: HIVE-231.patch
>
>
> Suggestion to create html junit reports for the hive tests. This would give developers an easier overview of what has gone wrong if the build fails then having to look through text files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-231) Create junit reports for tests
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668322#action_12668322 ]
Ashish Thusoo commented on HIVE-231:
------------------------------------
I think we can just take this one as is and later refine this..
The benefits of this in itself are quite strong...
Am going to run the tests and if everything passes I will commit it.
There is already a +1 from Prasad.
Also if you could do a submit patch once you upload a patch, that would be great. I usually just look at the Patch Available link on the project page to see what is in the submitted stage...
Thanks,
Ashish
> Create junit reports for tests
> ------------------------------
>
> Key: HIVE-231
> URL: https://issues.apache.org/jira/browse/HIVE-231
> Project: Hadoop Hive
> Issue Type: Test
> Components: Testing Infrastructure
> Affects Versions: 0.2.0
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
> Fix For: 0.2.0
>
> Attachments: HIVE-231.patch, HIVE-231.patch
>
>
> Suggestion to create html junit reports for the hive tests. This would give developers an easier overview of what has gone wrong if the build fails then having to look through text files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-231) Create junit reports for tests
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Thusoo updated HIVE-231:
-------------------------------
Fix Version/s: 0.2.0
Affects Version/s: 0.2.0
Status: Patch Available (was: Open)
submitted.
> Create junit reports for tests
> ------------------------------
>
> Key: HIVE-231
> URL: https://issues.apache.org/jira/browse/HIVE-231
> Project: Hadoop Hive
> Issue Type: Test
> Components: Testing Infrastructure
> Affects Versions: 0.2.0
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
> Fix For: 0.2.0
>
> Attachments: HIVE-231.patch, HIVE-231.patch
>
>
> Suggestion to create html junit reports for the hive tests. This would give developers an easier overview of what has gone wrong if the build fails then having to look through text files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-231) Create junit reports for tests
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665784#action_12665784 ]
Johan Oskarsson commented on HIVE-231:
--------------------------------------
Looked at creating a single file and am having problems figuring out how to do it since all the modules are run as subant tasks.
I moved the report creating into build.xml after the subant task calls and that works fine if the build succeeds. If it fails however the report is never created. I can't put the fail tag in build.xml either since the property set by the subant task doesn't exist when the task returns to the parent build.
If that was unclear I can post my (non working) updated patch.
Suggestions are very welcome.
> Create junit reports for tests
> ------------------------------
>
> Key: HIVE-231
> URL: https://issues.apache.org/jira/browse/HIVE-231
> Project: Hadoop Hive
> Issue Type: Test
> Components: Testing Infrastructure
> Reporter: Johan Oskarsson
> Priority: Trivial
> Attachments: HIVE-231.patch
>
>
> Suggestion to create html junit reports for the hive tests. This would give developers an easier overview of what has gone wrong if the build fails then having to look through text files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-231) Create junit reports for tests
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665947#action_12665947 ]
Ashish Thusoo commented on HIVE-231:
------------------------------------
This looks good to me.
One minor comment is that we should add a dependency from testreport target to test, so that ant testreport iteself triggers the test target.
Thoughts?
> Create junit reports for tests
> ------------------------------
>
> Key: HIVE-231
> URL: https://issues.apache.org/jira/browse/HIVE-231
> Project: Hadoop Hive
> Issue Type: Test
> Components: Testing Infrastructure
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
> Attachments: HIVE-231.patch, HIVE-231.patch
>
>
> Suggestion to create html junit reports for the hive tests. This would give developers an easier overview of what has gone wrong if the build fails then having to look through text files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-231) Create junit reports for tests
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663817#action_12663817 ]
Prasad Chakka commented on HIVE-231:
------------------------------------
i have seen these log files take very long to load because they are very big and they are xml. since build will tell which tests failed, developers can figure out which xml file to check so i prefer few smaller xml files than one very big xml file.
> Create junit reports for tests
> ------------------------------
>
> Key: HIVE-231
> URL: https://issues.apache.org/jira/browse/HIVE-231
> Project: Hadoop Hive
> Issue Type: Test
> Components: Testing Infrastructure
> Reporter: Johan Oskarsson
> Priority: Trivial
> Attachments: HIVE-231.patch
>
>
> Suggestion to create html junit reports for the hive tests. This would give developers an easier overview of what has gone wrong if the build fails then having to look through text files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-231) Create junit reports for tests
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Oskarsson updated HIVE-231:
---------------------------------
Attachment: HIVE-231.patch
This patch changes the output format to xml and generates a report once the tests are done.
> Create junit reports for tests
> ------------------------------
>
> Key: HIVE-231
> URL: https://issues.apache.org/jira/browse/HIVE-231
> Project: Hadoop Hive
> Issue Type: Test
> Components: Testing Infrastructure
> Reporter: Johan Oskarsson
> Priority: Trivial
> Attachments: HIVE-231.patch
>
>
> Suggestion to create html junit reports for the hive tests. This would give developers an easier overview of what has gone wrong if the build fails then having to look through text files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-231) Create junit reports for tests
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Oskarsson updated HIVE-231:
---------------------------------
Attachment: HIVE-231.patch
This is the best option I can think of. The testreport target is separate from the testing one. So to use one would type "ant test; ant testreport". This also means the report isn't generated if the user just wants to run the tests, for example in a continuous integration system.
> Create junit reports for tests
> ------------------------------
>
> Key: HIVE-231
> URL: https://issues.apache.org/jira/browse/HIVE-231
> Project: Hadoop Hive
> Issue Type: Test
> Components: Testing Infrastructure
> Reporter: Johan Oskarsson
> Priority: Trivial
> Attachments: HIVE-231.patch, HIVE-231.patch
>
>
> Suggestion to create html junit reports for the hive tests. This would give developers an easier overview of what has gone wrong if the build fails then having to look through text files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-231) Create junit reports for tests
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663819#action_12663819 ]
Raghotham Murthy commented on HIVE-231:
---------------------------------------
if you just run ant test from the top-level-directory its virtually impossible to know which tests failed because there's so much stuff printed on the screen. the report is actually an html file - how big does it get? also, is there an option to create a single report with module level information and links to reports for individual modules?
> Create junit reports for tests
> ------------------------------
>
> Key: HIVE-231
> URL: https://issues.apache.org/jira/browse/HIVE-231
> Project: Hadoop Hive
> Issue Type: Test
> Components: Testing Infrastructure
> Reporter: Johan Oskarsson
> Priority: Trivial
> Attachments: HIVE-231.patch
>
>
> Suggestion to create html junit reports for the hive tests. This would give developers an easier overview of what has gone wrong if the build fails then having to look through text files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-231) Create junit reports for tests
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665949#action_12665949 ]
Ashish Thusoo commented on HIVE-231:
------------------------------------
Also, we may just want to have a report for each of the modules. What I meant by a single report is that for a given module we should have a single report instead of one per test case. That would also address your failure issue. The outer target could just create and uber html that points to each of the single reports...
Thoughts?
> Create junit reports for tests
> ------------------------------
>
> Key: HIVE-231
> URL: https://issues.apache.org/jira/browse/HIVE-231
> Project: Hadoop Hive
> Issue Type: Test
> Components: Testing Infrastructure
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
> Attachments: HIVE-231.patch, HIVE-231.patch
>
>
> Suggestion to create html junit reports for the hive tests. This would give developers an easier overview of what has gone wrong if the build fails then having to look through text files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-231) Create junit reports for tests
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663813#action_12663813 ]
Johan Oskarsson commented on HIVE-231:
--------------------------------------
This patch creates one report per module, the other option is to do a big report. Might make more sense. Thoughts?
> Create junit reports for tests
> ------------------------------
>
> Key: HIVE-231
> URL: https://issues.apache.org/jira/browse/HIVE-231
> Project: Hadoop Hive
> Issue Type: Test
> Components: Testing Infrastructure
> Reporter: Johan Oskarsson
> Priority: Trivial
> Attachments: HIVE-231.patch
>
>
> Suggestion to create html junit reports for the hive tests. This would give developers an easier overview of what has gone wrong if the build fails then having to look through text files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HIVE-231) Create junit reports for tests
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Thusoo reassigned HIVE-231:
----------------------------------
Assignee: Johan Oskarsson
assignment.
> Create junit reports for tests
> ------------------------------
>
> Key: HIVE-231
> URL: https://issues.apache.org/jira/browse/HIVE-231
> Project: Hadoop Hive
> Issue Type: Test
> Components: Testing Infrastructure
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
> Attachments: HIVE-231.patch, HIVE-231.patch
>
>
> Suggestion to create html junit reports for the hive tests. This would give developers an easier overview of what has gone wrong if the build fails then having to look through text files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-231) Create junit reports for tests
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666112#action_12666112 ]
Johan Oskarsson commented on HIVE-231:
--------------------------------------
The problem with adding a dependency from testreport to test is that if a test fails it won't generate the report as mentioned above. I can't find a good way around this, but am open to suggestions.
If you want one report per component instead of one report for the whole project my first patch should do that for you.
Personally I would use this to make sure that new changes by me haven't broken anything. Hive builds always fail for me as per HIVE-189 making it very hard to see if my changes broke anything else. So in my case having one report for the whole project makes more sense.
It's certainly possible to create an overall html file that links to the individual reports but you'd lose the "quick overview" benefits of one big report.
Alternatively we could add both ways of creating reports but that might be overkill.
What do you guys think?
> Create junit reports for tests
> ------------------------------
>
> Key: HIVE-231
> URL: https://issues.apache.org/jira/browse/HIVE-231
> Project: Hadoop Hive
> Issue Type: Test
> Components: Testing Infrastructure
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
> Attachments: HIVE-231.patch, HIVE-231.patch
>
>
> Suggestion to create html junit reports for the hive tests. This would give developers an easier overview of what has gone wrong if the build fails then having to look through text files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-231) Create junit reports for tests
Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663824#action_12663824 ]
Prasad Chakka commented on HIVE-231:
------------------------------------
I don't have strong feelings either way. i am fine with single file as well.
> Create junit reports for tests
> ------------------------------
>
> Key: HIVE-231
> URL: https://issues.apache.org/jira/browse/HIVE-231
> Project: Hadoop Hive
> Issue Type: Test
> Components: Testing Infrastructure
> Reporter: Johan Oskarsson
> Priority: Trivial
> Attachments: HIVE-231.patch
>
>
> Suggestion to create html junit reports for the hive tests. This would give developers an easier overview of what has gone wrong if the build fails then having to look through text files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-231) Create junit reports for tests
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-231:
--------------------------------
Fix Version/s: 0.3.0
(was: 0.6.0)
Affects Version/s: (was: 0.6.0)
> Create junit reports for tests
> ------------------------------
>
> Key: HIVE-231
> URL: https://issues.apache.org/jira/browse/HIVE-231
> Project: Hadoop Hive
> Issue Type: Test
> Components: Testing Infrastructure
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
> Fix For: 0.3.0
>
> Attachments: HIVE-231.patch, HIVE-231.patch
>
>
> Suggestion to create html junit reports for the hive tests. This would give developers an easier overview of what has gone wrong if the build fails then having to look through text files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-231) Create junit reports for tests
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663833#action_12663833 ]
Ashish Thusoo commented on HIVE-231:
------------------------------------
You could get the file for a single test by simply doing -Dtestcase... no? So one single file for the test run should work, no?
> Create junit reports for tests
> ------------------------------
>
> Key: HIVE-231
> URL: https://issues.apache.org/jira/browse/HIVE-231
> Project: Hadoop Hive
> Issue Type: Test
> Components: Testing Infrastructure
> Reporter: Johan Oskarsson
> Priority: Trivial
> Attachments: HIVE-231.patch
>
>
> Suggestion to create html junit reports for the hive tests. This would give developers an easier overview of what has gone wrong if the build fails then having to look through text files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-231) Create junit reports for tests
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663814#action_12663814 ]
Raghotham Murthy commented on HIVE-231:
---------------------------------------
I'd vote for one big report for all modules. If developers want a report for just one module, can they just run ant test within the module's directory?
> Create junit reports for tests
> ------------------------------
>
> Key: HIVE-231
> URL: https://issues.apache.org/jira/browse/HIVE-231
> Project: Hadoop Hive
> Issue Type: Test
> Components: Testing Infrastructure
> Reporter: Johan Oskarsson
> Priority: Trivial
> Attachments: HIVE-231.patch
>
>
> Suggestion to create html junit reports for the hive tests. This would give developers an easier overview of what has gone wrong if the build fails then having to look through text files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-231) Create junit reports for tests
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Thusoo updated HIVE-231:
-------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
committed. Thanks Johan!!
> Create junit reports for tests
> ------------------------------
>
> Key: HIVE-231
> URL: https://issues.apache.org/jira/browse/HIVE-231
> Project: Hadoop Hive
> Issue Type: Test
> Components: Testing Infrastructure
> Affects Versions: 0.2.0
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Priority: Trivial
> Fix For: 0.2.0
>
> Attachments: HIVE-231.patch, HIVE-231.patch
>
>
> Suggestion to create html junit reports for the hive tests. This would give developers an easier overview of what has gone wrong if the build fails then having to look through text files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.