You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2016/04/03 22:22:34 UTC

[Bug 59265] New: totalThreads + activeThreads + warnIndicator tooltip not updated when we change the language

https://bz.apache.org/bugzilla/show_bug.cgi?id=59265

            Bug ID: 59265
           Summary: totalThreads + activeThreads + warnIndicator tooltip
                    not updated when we change the language
           Product: JMeter
           Version: Nightly (Please specify date)
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: minor
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: ra0077@gmail.com

Created attachment 33721
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33721&action=edit
Tooltip not updated

Hi,

When we change the language of JMeter GUI, totalThreads + activeThreads +
warnIndicator tooltip are not updated to the new language

If we check the code source these 3 icons are created in
org.apache.jmeter.gui.MainFrame

And this class don't implement LocaleChangeListener like others (JMeterToolBar,
JMeterMenuBar)

If you have an idea how to fix it, I can try to do it

Antonio

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59265] totalThreads + activeThreads + warnIndicator tooltip not updated when we change the language in the GUI

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59265

--- Comment #5 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Hi sebb,
My answers inline.
Regards
(In reply to Sebb from comment #4)
> (In reply to Philippe Mouawad from comment #3)
> > Changing language in JMeter requires 2 configuration options:
> > - set JMeter property : language=fr
> > - set Java Sytem property : -Duser.language=fr
> > 
> > I propose to disable change through menu option.
> 
> Or we just note it as a known bug; the function mostly works.

I am not sure it's very good for JMeter image to have function that "mostly
works".

For me, unless you set both, a lot of GUI will still be in the original
language.

> 
> It's really not that important, and we may get complaints that the menu item
> has gone.

I think it's not important for English OS, but for other users it can be
annoying.

> 
> But we should investigate why there are both properties. Could we drop the
> JMeter one? Or does that do different things?

Maybe we should drop the JMeter one, it is only used in JMeterUtils#initLocale
Because there is an other annoying issue about it, it only works if put in
jmeter.properties, not in user.properties.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59265] totalThreads + activeThreads + warnIndicator tooltip not updated when we change the language in the GUI

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59265

--- Comment #6 from Sebb <se...@apache.org> ---
(In reply to Philippe Mouawad from comment #5)
> Hi sebb,
> My answers inline.
> Regards
> (In reply to Sebb from comment #4)
> > (In reply to Philippe Mouawad from comment #3)
> > > Changing language in JMeter requires 2 configuration options:
> > > - set JMeter property : language=fr
> > > - set Java Sytem property : -Duser.language=fr
> > > 
> > > I propose to disable change through menu option.
> > 
> > Or we just note it as a known bug; the function mostly works.
> 
> I am not sure it's very good for JMeter image to have function that "mostly
> works".

There are lots of functions that have minor bugs, but we don't just drop them.
Besides, there's quite a lot of work to remove the code and update the
documentation.
I would rather that effort was spent on making the function work.

> For me, unless you set both, a lot of GUI will still be in the original
> language.

That's really a separate issue which can hopefully be solved.

> > 
> > It's really not that important, and we may get complaints that the menu item
> > has gone.
> 
> I think it's not important for English OS, but for other users it can be
> annoying.

Not sure I follow why it is better for English OS.

> > 
> > But we should investigate why there are both properties. Could we drop the
> > JMeter one? Or does that do different things?
> 
> Maybe we should drop the JMeter one, it is only used in
> JMeterUtils#initLocale
> Because there is an other annoying issue about it, it only works if put in
> jmeter.properties, not in user.properties.

OK, I wonder why it was introduced.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59265] totalThreads + activeThreads + warnIndicator tooltip not updated when we change the language

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59265

--- Comment #2 from Antonio Gomes Rodrigues <ra...@gmail.com> ---
Hi Sebb,

I have try to modify language option in jmeter.properties

With no language
JMeter is in French because I use a French operating system
If I switch to English in the GUI, the tooltip is still in French

If I put language=fr, same as above

If I put language=en
JMeter is in English
If I switch to French, the tooltip remains in English whereas it should be in
French

Antonio

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59265] totalThreads + activeThreads + warnIndicator tooltip not updated when we change the language in the GUI

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59265

--- Comment #4 from Sebb <se...@apache.org> ---
(In reply to Philippe Mouawad from comment #3)
> Changing language in JMeter requires 2 configuration options:
> - set JMeter property : language=fr
> - set Java Sytem property : -Duser.language=fr
> 
> I propose to disable change through menu option.

Or we just note it as a known bug; the function mostly works.

It's really not that important, and we may get complaints that the menu item
has gone.

But we should investigate why there are both properties. Could we drop the
JMeter one? Or does that do different things?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59265] totalThreads + activeThreads + warnIndicator tooltip not updated when we change the language in the GUI

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59265

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om

--- Comment #3 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Changing language in JMeter requires 2 configuration options:
- set JMeter property : language=fr
- set Java Sytem property : -Duser.language=fr

I propose to disable change through menu option.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59265] totalThreads + activeThreads + warnIndicator tooltip not updated when we change the language in the GUI

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59265

Antonio Gomes Rodrigues <ra...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|totalThreads +              |totalThreads +
                   |activeThreads +             |activeThreads +
                   |warnIndicator tooltip not   |warnIndicator tooltip not
                   |updated when we change the  |updated when we change the
                   |language                    |language in the GUI

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59265] totalThreads + activeThreads + warnIndicator tooltip not updated when we change the language

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59265

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #1 from Sebb <se...@apache.org> ---
Does the tooltip change correctly if you set the language before starting
JMeter?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59265] totalThreads + activeThreads + warnIndicator tooltip not updated when we change the language

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59265

Antonio Gomes Rodrigues <ra...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.