You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/05/18 20:14:45 UTC
[jira] Created: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
address all findbugs warnings in persistence classes
----------------------------------------------------
Key: ZOOKEEPER-408
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
Project: Zookeeper
Issue Type: Sub-task
Reporter: Patrick Hunt
Assignee: Mahadev konar
Fix For: 3.2.0
trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715735#action_12715735 ]
Hadoop QA commented on ZOOKEEPER-408:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12409680/ZOOKEEPER-408.patch
against trunk revision 781173.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 27 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/99/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/99/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/99/console
This message is automatically generated.
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-408:
------------------------------------
+1 please commit.
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-408:
------------------------------------
Status: Open (was: Patch Available)
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-408:
------------------------------------
Status: Patch Available (was: Open)
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-408:
-----------------------------------
Attachment: ZOOKEEPER-408.patch
Addressed issues in persistence package. Still some issues in datanode/datatree, Mahadev
you are more familiar with this code, can you address?
Also, should we change upgrade code or just ignore it? Seems like ignore would be good as
this is legacy code... thoughts?
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-408:
------------------------------------
Status: Patch Available (was: Open)
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-408:
------------------------------------
Status: Patch Available (was: Open)
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715812#action_12715812 ]
Benjamin Reed commented on ZOOKEEPER-408:
-----------------------------------------
-1 turns out that SyncRequestProcessor.snapCount can't be final; tests try to set it.
when i removed the final, ClientTest hangs
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-408:
------------------------------------
Status: Open (was: Patch Available)
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-408:
------------------------------------
Hadoop Flags: [Reviewed]
+1 good job
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-408:
------------------------------------
Status: Open (was: Patch Available)
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720905#action_12720905 ]
Hadoop QA commented on ZOOKEEPER-408:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12410981/ZOOKEEPER-408.patch
against trunk revision 785741.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 51 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to cause Findbugs to fail.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/120/testReport/
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/120/console
This message is automatically generated.
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-408:
------------------------------------
Status: Patch Available (was: Open)
retyring to see if the test failure is temporary..
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-408:
------------------------------------
Attachment: ZOOKEEPER-408.patch
missed out on a compilation problem.
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-408:
---------------------------------------------
Attachment: ZOOKEEPER-408.patch
I have excluded the bug warning of AuthFastLeaderElection. In my opinion, the way it is implement is good.
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-408:
------------------------------------
Status: Open (was: Patch Available)
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-408:
------------------------------------
Attachment: ZOOKEEPER-408.patch
fixed the tests (removed a line which shouldnt have been removed).
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722555#action_12722555 ]
Hudson commented on ZOOKEEPER-408:
----------------------------------
Integrated in ZooKeeper-trunk #354 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/354/])
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-408:
------------------------------------
Attachment: ZOOKEEPER-408.patch
this patch fixes all but one of the remaining findbugs warnings (some of them being legitimate, so had to add to finbugs exclude file).
the remaning one is in AuthFastLeaderElection. Ill let flavio take a look at it before I make changes in that code..
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-408:
------------------------------------
Status: Patch Available (was: Open)
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721028#action_12721028 ]
Hadoop QA commented on ZOOKEEPER-408:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12410998/ZOOKEEPER-408.patch
against trunk revision 785871.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 51 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/123/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/123/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/123/console
This message is automatically generated.
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-408:
--------------------------------------
Assignee: Mahadev konar (was: Patrick Hunt)
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715918#action_12715918 ]
Hudson commented on ZOOKEEPER-408:
----------------------------------
Integrated in ZooKeeper-trunk #334 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/334/])
reverting patch since it breaks the build
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-408:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this.thanks pat and flavio.
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-408:
------------------------------------
Attachment: ZOOKEEPER-408.patch
fixed the compilation problems and some more findbugs warnnings. Now the count should be 0 for findbugs warnings.
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-408:
--------------------------------------
Assignee: Patrick Hunt (was: Mahadev konar)
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.2.0
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-408) address all findbugs warnings in
persistence classes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720924#action_12720924 ]
Hadoop QA commented on ZOOKEEPER-408:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12410985/ZOOKEEPER-408.patch
against trunk revision 785741.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 51 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/121/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/121/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/121/console
This message is automatically generated.
> address all findbugs warnings in persistence classes
> ----------------------------------------------------
>
> Key: ZOOKEEPER-408
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408
> Project: Zookeeper
> Issue Type: Sub-task
> Reporter: Patrick Hunt
> Assignee: Mahadev konar
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch
>
>
> trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java
> trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java
> trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java
> trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.