[GitHub] [ignite-3] AMashenkov commented on a change in pull request #518: IGNITE-14830 Introduce index internal API

[GitBox <gi...@apache.org>]

AMashenkov commented on a change in pull request #518:
URL: https://github.com/apache/ignite-3/pull/518#discussion_r798505572



##########
File path: modules/index-api/src/main/java/org/apache/ignite/internal/idx/IndexManager.java
##########
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.idx;
+
+import java.util.List;
+import java.util.UUID;
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Consumer;
+import org.apache.ignite.configuration.schemas.table.TableIndexChange;
+import org.apache.ignite.internal.idx.event.IndexEvent;
+import org.apache.ignite.internal.idx.event.IndexEventParameters;
+import org.apache.ignite.internal.manager.Producer;
+import org.apache.ignite.lang.IndexAlreadyExistsException;
+import org.apache.ignite.lang.IndexNotFoundException;
+import org.apache.ignite.lang.NodeStoppingException;
+
+/**
+ * Internal index manager facade provides low-level methods for indexes operations.
+ */
+public interface IndexManager extends Producer<IndexEvent, IndexEventParameters> {
+    /**
+     * Creates a new index with the specified name.
+     *
+     * @param idxCanonicalName Index canonical name.
+     * @param tblCanonicalName Table canonical name.
+     * @param idxChange        Index configuration.
+     * @return Index.
+     * @throws IndexAlreadyExistsException if the index exists.
+     */
+    InternalSortedIndex createIndex(

Review comment:
       Do we need synchronous methods in internal API?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org