[GitHub] [nifi] vitalyzhakov commented on pull request #6329: NIFI-10360 VOLUME declaration prevents updating flow from CI

[GitBox <gi...@apache.org>]

vitalyzhakov commented on PR #6329:
URL: https://github.com/apache/nifi/pull/6329#issuecomment-1226075915

   Hello, @exceptionfactory !
   
   Thanks for your work and fast answer!
   
   Can we suppose, that this best practice on official site has a mistake?
   [Opinion in the internet](https://boxboat.com/2017/01/23/volumes-and-dockerfiles-dont-mix/) are different for using VOLUME in Dockerfile. [Same opinion](https://stackoverflow.com/questions/44060341/is-it-a-docker-best-practice-to-use-volume-for-the-code).
   
   Maybe we should discuss about use cases?
   > The associated NiFi Jira issue shows copying the contents of the conf directory into the image itself, which is not the best approach for mutable and sensitive configuration files.
   
   If user want to store data on host filesystem, he can use volume declaration in runtime.
   
   >An alternative solution might include creating an alternative base image
   
   I want to make this project some better (10M images downloaded * 50 MB ~ 500 TB disk space)  and don't want to [multiply entities beyond necessity](https://en.wikipedia.org/wiki/Occam%27s_razor)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org