You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/08/29 03:47:31 UTC
Review Request: Updated most uses of 'double' to represent a duration in
seconds to use 'Duration' instead.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6815/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Description
-------
See summary.
Diffs
-----
src/exec/exec.cpp c9f87fa
src/flags/loader.hpp d7be7b9
src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 1f46e08
src/linux/cgroups.hpp 5391c22
src/linux/cgroups.cpp 9cedea5
src/log/coordinator.cpp 838852f
src/log/log.hpp dcbf0b1
src/log/replica.cpp e379d51
src/logging/logging.cpp 6909b0b
src/master/constants.hpp 9214bab
src/master/frameworks_manager.cpp 6973389
src/master/hierarchical_allocator_process.hpp 86c9b1e
src/master/master.cpp d3eab98
src/mesos/main.cpp 747e98e
src/sched/sched.cpp a147e90
src/slave/constants.hpp ab83972
src/slave/flags.hpp 0c7917f
src/slave/gc.hpp 6704742
src/slave/gc.cpp 9c01024
src/slave/reaper.cpp 4acabad
src/slave/slave.cpp 4efd41e
src/tests/cgroups_tests.cpp 0c56481
src/tests/fault_tolerance_tests.cpp 3cbab2b
src/tests/log_tests.cpp 85b2329
src/tests/master_tests.cpp 36dd6a0
src/zookeeper/group.cpp 8ae23f3
src/zookeeper/zookeeper.cpp 621deaf
third_party/libprocess/include/process/delay.hpp f9f2c5e
third_party/libprocess/include/process/future.hpp cf0f522
third_party/libprocess/include/process/latch.hpp f0afe78
third_party/libprocess/include/process/process.hpp 9c90e76
third_party/libprocess/include/process/timeout.hpp 4a1f113
third_party/libprocess/include/process/timer.hpp 72f7711
third_party/libprocess/include/stout/duration.hpp PRE-CREATION
third_party/libprocess/src/latch.cpp 2f9135d
third_party/libprocess/src/process.cpp 2b2d521
third_party/libprocess/src/tests.cpp 8f4b2ae
Diff: https://reviews.apache.org/r/6815/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Updated most uses of 'double' to represent a duration in
seconds to use 'Duration' instead.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Aug. 30, 2012, 12:49 a.m., Vinod Kone wrote:
> > src/flags/loader.hpp, line 122
> > <https://reviews.apache.org/r/6815/diff/2/?file=147027#file147027line122>
> >
> > new rule for spacing?
Nope, fixed in a subsequent review!
> On Aug. 30, 2012, 12:49 a.m., Vinod Kone wrote:
> > src/log/coordinator.cpp, line 299
> > <https://reviews.apache.org/r/6815/diff/2/?file=147032#file147032line299>
> >
> > s/0.0/0
Done.
> On Aug. 30, 2012, 12:49 a.m., Vinod Kone wrote:
> > src/log/coordinator.cpp, line 420
> > <https://reviews.apache.org/r/6815/diff/2/?file=147032#file147032line420>
> >
> > s/0.0/0
Done.
> On Aug. 30, 2012, 12:49 a.m., Vinod Kone wrote:
> > src/logging/logging.cpp, line 142
> > <https://reviews.apache.org/r/6815/diff/2/?file=147035#file147035line142>
> >
> > s/0.0/0
Done.
> On Aug. 30, 2012, 12:49 a.m., Vinod Kone wrote:
> > src/master/hierarchical_allocator_process.hpp, line 176
> > <https://reviews.apache.org/r/6815/diff/2/?file=147038#file147038line176>
> >
> > s/0.0/0
Done.
> On Aug. 30, 2012, 12:49 a.m., Vinod Kone wrote:
> > src/master/hierarchical_allocator_process.hpp, line 439
> > <https://reviews.apache.org/r/6815/diff/2/?file=147038#file147038line439>
> >
> > s/0.0/0
Done.
> On Aug. 30, 2012, 12:49 a.m., Vinod Kone wrote:
> > src/master/hierarchical_allocator_process.hpp, line 445
> > <https://reviews.apache.org/r/6815/diff/2/?file=147038#file147038line445>
> >
> > Filter should also just accept timeout
Yup, it does this in a subsequent review.
> On Aug. 30, 2012, 12:49 a.m., Vinod Kone wrote:
> > third_party/libprocess/include/process/timer.hpp, line 80
> > <https://reviews.apache.org/r/6815/diff/2/?file=147059#file147059line80>
> >
> > s/because/as/
Okay, but I went with 'since' instead.
> On Aug. 30, 2012, 12:49 a.m., Vinod Kone wrote:
> > third_party/libprocess/src/process.cpp, line 1433
> > <https://reviews.apache.org/r/6815/diff/2/?file=147062#file147062line1433>
> >
> > s/30/30.0/
Done.
> On Aug. 30, 2012, 12:49 a.m., Vinod Kone wrote:
> > third_party/libprocess/src/process.cpp, line 1449
> > <https://reviews.apache.org/r/6815/diff/2/?file=147062#file147062line1449>
> >
> > s/30/30.0/
Done.
> On Aug. 30, 2012, 12:49 a.m., Vinod Kone wrote:
> > third_party/libprocess/src/tests.cpp, line 645
> > <https://reviews.apache.org/r/6815/diff/2/?file=147063#file147063line645>
> >
> > s/5/5.0/g
Done.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6815/#review10864
-----------------------------------------------------------
On Aug. 29, 2012, 7:06 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6815/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2012, 7:06 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/exec/exec.cpp c9f87fa
> src/flags/loader.hpp d7be7b9
> src/java/jni/org_apache_mesos_Log.cpp 3928b31
> src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 1f46e08
> src/linux/cgroups.hpp 5391c22
> src/linux/cgroups.cpp 9cedea5
> src/log/coordinator.cpp 838852f
> src/log/log.hpp dcbf0b1
> src/log/replica.cpp e379d51
> src/logging/logging.cpp 6909b0b
> src/master/constants.hpp 9214bab
> src/master/frameworks_manager.cpp 6973389
> src/master/hierarchical_allocator_process.hpp 86c9b1e
> src/master/master.cpp d3eab98
> src/mesos/main.cpp 747e98e
> src/sched/sched.cpp a147e90
> src/slave/constants.hpp ab83972
> src/slave/flags.hpp 0c7917f
> src/slave/gc.hpp 6704742
> src/slave/gc.cpp 9c01024
> src/slave/reaper.cpp 4acabad
> src/slave/slave.cpp 4efd41e
> src/tests/cgroups_tests.cpp 0c56481
> src/tests/fault_tolerance_tests.cpp 3cbab2b
> src/tests/log_tests.cpp 85b2329
> src/tests/master_tests.cpp 36dd6a0
> src/zookeeper/group.cpp 8ae23f3
> src/zookeeper/zookeeper.cpp 621deaf
> third_party/libprocess/include/process/delay.hpp f9f2c5e
> third_party/libprocess/include/process/future.hpp cf0f522
> third_party/libprocess/include/process/latch.hpp f0afe78
> third_party/libprocess/include/process/process.hpp 9c90e76
> third_party/libprocess/include/process/timeout.hpp 4a1f113
> third_party/libprocess/include/process/timer.hpp 72f7711
> third_party/libprocess/include/stout/duration.hpp PRE-CREATION
> third_party/libprocess/src/latch.cpp 2f9135d
> third_party/libprocess/src/process.cpp 2b2d521
> third_party/libprocess/src/tests.cpp 8f4b2ae
>
> Diff: https://reviews.apache.org/r/6815/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Updated most uses of 'double' to represent a duration in
seconds to use 'Duration' instead.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6815/#review10864
-----------------------------------------------------------
Ship it!
thanx for taking this on!
src/flags/loader.hpp
<https://reviews.apache.org/r/6815/#comment23400>
new rule for spacing?
src/java/jni/org_apache_mesos_Log.cpp
<https://reviews.apache.org/r/6815/#comment23401>
s/duration/time/ :)))))
src/log/coordinator.cpp
<https://reviews.apache.org/r/6815/#comment23402>
s/0.0/0
src/log/coordinator.cpp
<https://reviews.apache.org/r/6815/#comment23403>
s/0.0/0
src/logging/logging.cpp
<https://reviews.apache.org/r/6815/#comment23404>
s/0.0/0
src/master/hierarchical_allocator_process.hpp
<https://reviews.apache.org/r/6815/#comment23410>
s/0.0/0
src/master/hierarchical_allocator_process.hpp
<https://reviews.apache.org/r/6815/#comment23412>
s/0.0/0
src/master/hierarchical_allocator_process.hpp
<https://reviews.apache.org/r/6815/#comment23405>
Filter should also just accept timeout
third_party/libprocess/include/process/timer.hpp
<https://reviews.apache.org/r/6815/#comment23406>
s/because/as/
third_party/libprocess/src/process.cpp
<https://reviews.apache.org/r/6815/#comment23407>
s/30/30.0/
third_party/libprocess/src/process.cpp
<https://reviews.apache.org/r/6815/#comment23409>
s/30/30.0/
third_party/libprocess/src/tests.cpp
<https://reviews.apache.org/r/6815/#comment23408>
s/5/5.0/g
- Vinod Kone
On Aug. 29, 2012, 7:06 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6815/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2012, 7:06 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/exec/exec.cpp c9f87fa
> src/flags/loader.hpp d7be7b9
> src/java/jni/org_apache_mesos_Log.cpp 3928b31
> src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 1f46e08
> src/linux/cgroups.hpp 5391c22
> src/linux/cgroups.cpp 9cedea5
> src/log/coordinator.cpp 838852f
> src/log/log.hpp dcbf0b1
> src/log/replica.cpp e379d51
> src/logging/logging.cpp 6909b0b
> src/master/constants.hpp 9214bab
> src/master/frameworks_manager.cpp 6973389
> src/master/hierarchical_allocator_process.hpp 86c9b1e
> src/master/master.cpp d3eab98
> src/mesos/main.cpp 747e98e
> src/sched/sched.cpp a147e90
> src/slave/constants.hpp ab83972
> src/slave/flags.hpp 0c7917f
> src/slave/gc.hpp 6704742
> src/slave/gc.cpp 9c01024
> src/slave/reaper.cpp 4acabad
> src/slave/slave.cpp 4efd41e
> src/tests/cgroups_tests.cpp 0c56481
> src/tests/fault_tolerance_tests.cpp 3cbab2b
> src/tests/log_tests.cpp 85b2329
> src/tests/master_tests.cpp 36dd6a0
> src/zookeeper/group.cpp 8ae23f3
> src/zookeeper/zookeeper.cpp 621deaf
> third_party/libprocess/include/process/delay.hpp f9f2c5e
> third_party/libprocess/include/process/future.hpp cf0f522
> third_party/libprocess/include/process/latch.hpp f0afe78
> third_party/libprocess/include/process/process.hpp 9c90e76
> third_party/libprocess/include/process/timeout.hpp 4a1f113
> third_party/libprocess/include/process/timer.hpp 72f7711
> third_party/libprocess/include/stout/duration.hpp PRE-CREATION
> third_party/libprocess/src/latch.cpp 2f9135d
> third_party/libprocess/src/process.cpp 2b2d521
> third_party/libprocess/src/tests.cpp 8f4b2ae
>
> Diff: https://reviews.apache.org/r/6815/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Updated most uses of 'double' to represent a duration in
seconds to use 'Duration' instead.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6815/
-----------------------------------------------------------
(Updated Aug. 29, 2012, 7:06 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Replaced use of Duration/Seconds with Timeout in replicated log.
Description
-------
See summary.
Diffs (updated)
-----
src/exec/exec.cpp c9f87fa
src/flags/loader.hpp d7be7b9
src/java/jni/org_apache_mesos_Log.cpp 3928b31
src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 1f46e08
src/linux/cgroups.hpp 5391c22
src/linux/cgroups.cpp 9cedea5
src/log/coordinator.cpp 838852f
src/log/log.hpp dcbf0b1
src/log/replica.cpp e379d51
src/logging/logging.cpp 6909b0b
src/master/constants.hpp 9214bab
src/master/frameworks_manager.cpp 6973389
src/master/hierarchical_allocator_process.hpp 86c9b1e
src/master/master.cpp d3eab98
src/mesos/main.cpp 747e98e
src/sched/sched.cpp a147e90
src/slave/constants.hpp ab83972
src/slave/flags.hpp 0c7917f
src/slave/gc.hpp 6704742
src/slave/gc.cpp 9c01024
src/slave/reaper.cpp 4acabad
src/slave/slave.cpp 4efd41e
src/tests/cgroups_tests.cpp 0c56481
src/tests/fault_tolerance_tests.cpp 3cbab2b
src/tests/log_tests.cpp 85b2329
src/tests/master_tests.cpp 36dd6a0
src/zookeeper/group.cpp 8ae23f3
src/zookeeper/zookeeper.cpp 621deaf
third_party/libprocess/include/process/delay.hpp f9f2c5e
third_party/libprocess/include/process/future.hpp cf0f522
third_party/libprocess/include/process/latch.hpp f0afe78
third_party/libprocess/include/process/process.hpp 9c90e76
third_party/libprocess/include/process/timeout.hpp 4a1f113
third_party/libprocess/include/process/timer.hpp 72f7711
third_party/libprocess/include/stout/duration.hpp PRE-CREATION
third_party/libprocess/src/latch.cpp 2f9135d
third_party/libprocess/src/process.cpp 2b2d521
third_party/libprocess/src/tests.cpp 8f4b2ae
Diff: https://reviews.apache.org/r/6815/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman