You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2017/09/02 11:39:33 UTC

[GitHub] zeppelin pull request #2560: [ZEPPELIN-2876]. Integrate with Livy 0.4.0

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/2560

    [ZEPPELIN-2876]. Integrate with Livy 0.4.0

    ### What is this PR for?
    
    This is to integrate livy 0.4.0 which is livy's first apache release. Since the package name is changed, I can not support both livy 0.3.0 and 0.4.0 in the integration test, but since the rest api is not changed. Ideally livy before 0.4.0 should still work. 
    
    Regarding the integration test, unfortunately I have to comment out some test due to livy's issue, I will enable it after next livy version release. 
    
    
    ### What type of PR is it?
    [Bug Fix | Improvement]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-2876
    
    ### How should this be tested?
    integration test is added
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-2876

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2560.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2560
    
----
commit 8508d371a08682954c477f5998454f4dd3eed988
Author: Jeff Zhang <zj...@apache.org>
Date:   2017-08-23T12:34:15Z

    [ZEPPELIN-2876]. Integrate with Livy 0.4.0

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2560: [ZEPPELIN-2876]. Integrate with Livy 0.4.0

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2560
  
    Actually this livy interprete support both livy 0.2.0 / 0.3.0 /0.4.0, because livy's rest api doesn't change, only its java package name changes. So I can not add integration test for both of these versions. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2560: [ZEPPELIN-2876]. Integrate with Livy 0.4.0

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2560
  
    Sure yes, rest all LGTM


---

[GitHub] zeppelin issue #2560: [ZEPPELIN-2876]. Integrate with Livy 0.4.0

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2560
  
    feasibility ask: Like we support python2, and python3 do you think it makes sense to have 2 different interpreters (at-least for now) one that supports Livy-0.2.0/0.3.0 and other as Livy-4?
    
    The reason I'm asking this is because what I see in this PR is, this PR is trying to download Livy-0.4.0 for integration/unit tests but most of the integration tests are turned off.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2560: [ZEPPELIN-2876]. Integrate with Livy 0.4.0

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2560
  
    Will commit if no more discussion. 


---

[GitHub] zeppelin pull request #2560: [ZEPPELIN-2876]. Integrate with Livy 0.4.0

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2560


---